Skip to content

Fix HttpHandlerDiagnosticListenerTests.TestW3CHeadersTraceStateAndCorrelationContext - #112753

Merged
antonfirsov merged 6 commits into
dotnet:mainfrom
antonfirsov:fix-TestW3CHeadersTraceStateAndCorrelationContext
Feb 24, 2025
Merged

Fix HttpHandlerDiagnosticListenerTests.TestW3CHeadersTraceStateAndCorrelationContext#112753
antonfirsov merged 6 commits into
dotnet:mainfrom
antonfirsov:fix-TestW3CHeadersTraceStateAndCorrelationContext

Conversation

@antonfirsov

@antonfirsovantonfirsov commented Feb 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

It's unclear to me how did this test pass before, but given it's testing W3C tracestate format behavior on .NET Framework, ActivityIdFormat.W3C should be explicitly set as DefaultIdFormat in the test. This will ensure that the Request-Id header (that is specific to the Hierarchical format) will be absent, making the last Assert pass.

Fixes#112426

CopilotAI reviewed Feb 20, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@antonfirsov

antonfirsov commented Feb 20, 2025

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Feb 20, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh

tarekgh commented Feb 20, 2025

Copy link
Copy Markdown
Member

@antonfirsov the issue #112426 is opened against .NET 8.0. This PR will force closing the issue which will make the failure still show in .NET 8 builds. Will you port this fix to 8.0 and possibly 9.0?

CC @noahfalk

@tarekghtarekgh added this to the 10.0.0 milestone Feb 20, 2025
@antonfirsov

antonfirsov commented Feb 20, 2025

Copy link
Copy Markdown
ContributorAuthor

Will you port this fix to 8.0 and possibly 9.0?

Sure, thanks for the heads-up!

This was referenced Feb 20, 2025
Open
Open
Open
@antonfirsovantonfirsov mentioned this pull request Feb 21, 2025
Open
antonfirsov
antonfirsov commented Feb 21, 2025
View reviewed changes
Comment threadsrc/libraries/System.Diagnostics.DiagnosticSource/tests/HttpHandlerDiagnosticListenerTests.cs
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/112792")]

@antonfirsovantonfirsovFeb 21, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost missed that this test is also failing. It seems to be a product bug, disabling for now. cc @tarekgh in case you have concerns.

@antonfirsov

antonfirsov commented Feb 21, 2025

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Feb 21, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Feb 21, 2025
Closed
3 tasks
@antonfirsov

antonfirsov commented Feb 22, 2025

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Feb 22, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Feb 22, 2025
Closed
@build-analysisbuild-analysisBot mentioned this pull request Feb 24, 2025
Closed
@antonfirsov

antonfirsov commented Feb 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/ba-g unrelated test failures reported in #112837

@antonfirsov
antonfirsov merged commit 0b80e90 into dotnet:mainFeb 24, 2025
@antonfirsov

antonfirsov commented Feb 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to release/8.0-staging

@antonfirsov

antonfirsov commented Feb 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to release/9.0-staging

@github-actions

github-actionsBot commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13507132223

@github-actions

github-actionsBot commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13507133492

This was referenced Feb 24, 2025
Merged
Merged
antonfirsov pushed a commit that referenced this pull request Mar 11, 2025
@github-actions
[release/9.0-staging] Fix HttpHandlerDiagnosticListenerTests.TestW3CH…
6758abd
…eadersTraceStateAndCorrelationContext (#112882)
Backport of #112753 to release/9.0-staging
antonfirsov pushed a commit that referenced this pull request Mar 12, 2025
@github-actions
[release/8.0-staging] Fix HttpHandlerDiagnosticListenerTests.TestW3CH…
c8cdafd
…eadersTraceStateAndCorrelationContext (#112881)
Backport of #112753 to release/8.0-staging
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@tarekghtarekghtarekgh approved these changes

Assignees

@antonfirsovantonfirsov

Labels

area-System.Diagnostics

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

[8.0] [.NET Framework 4.8] [x86] System.Diagnostics HttpHandler test failure: Remote process failed with an unhandled exception

3 participants

@antonfirsov@tarekgh