Skip to content

Remove use of --no-lock with Homebrew. - #113277

Merged
vcsjones merged 3 commits into
mainfrom
remove-brew-nolock
Mar 8, 2025
Merged

Remove use of --no-lock with Homebrew.#113277
vcsjones merged 3 commits into
mainfrom
remove-brew-nolock

Conversation

@vcsjones

@vcsjonesvcsjones commented Mar 7, 2025

Copy link
Copy Markdown
Member

Homebrew removed lock file generation in Homebrew/homebrew-bundle#1509, and left --no-lock as a no-op. It was removed entirely in Homebrew/homebrew-bundle@98d8ad7, which causes errors when passing this option.

Associated arcade PR: dotnet/arcade#15608

Closes#113276

CopilotAI review requested due to automatic review settings March 7, 2025 21:24
@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 7, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Homebrew installation instructions by removing the obsolete --no-lock flag, which is no longer needed following changes in Homebrew Bundle.

  • Removed the --no-lock option from the brew bundle command in the macOS requirements documentation.

Reviewed Changes

FileDescription
docs/workflow/requirements/macos-requirements.mdUpdated command to remove the deprecated --no-lock flag.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@vcsjonesvcsjones added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 7, 2025
@am11

am11 commented Mar 7, 2025

Copy link
Copy Markdown
Member

Thanks, please also open in arcade so it's not overwritten by the next arcade update. 🙂
(we can merge this PR as well, bot only overwrites files doesn't merge them)

Comment threaddocs/workflow/requirements/macos-requirements.md Outdated
@am11
am11 requested a review from jkoritzinskyMarch 7, 2025 21:59
@vcsjones
vcsjones merged commit 7eb07dd into mainMar 8, 2025
@vcsjones
vcsjones deleted the remove-brew-nolock branch March 8, 2025 03:23
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brew command passes (now invalid) --no-lock parameter

5 participants

@vcsjones@am11@akoeplinger@jkoritzinsky