JIT: Graph-based loop inversion by amanasifkhalid · Pull Request #113709 · dotnet/runtime

src/coreclr/jit/compiler.cpp

-Original file line number
+Diff line change
@@ Expand Up @@
  //
  DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault);
- // Invert loops
- //
- DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops);
  // Run some flow graph optimizations (but don't reorder)
  //
  DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow);
@@ Expand All @@
  //
  DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase);
+ // Invert loops
+ //
+ DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops);
  // Scale block weights and mark run rarely blocks.
  //
  DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights);
@@ Expand Down @@

src/coreclr/jit/compiler.h

-Original file line number
+Diff line change
@@ Expand Up / @@ -7095,7 +7095,7 @@ class Compiler @@
  OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree);
- bool optInvertWhileLoop(BasicBlock* block);
+ bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop);
  bool optIfConvert(BasicBlock* block);
 private:
@@ Expand Down @@

src/coreclr/jit/fgdiagnostic.cpp

-Original file line number
+Diff line change
@@ Expand Up / @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() @@
  loop->VisitRegularExitBlocks([=](BasicBlock* exit) {
  for (BasicBlock* pred : exit->PredBlocks())
  {
- assert(loop->ContainsBlock(pred));
+ if (!loop->ContainsBlock(pred))
+ {
+ JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n",
+ loop->GetIndex(), exit->bbNum, pred->bbNum);
+ assert(!"Loop exit has non-loop predecessor");
+ }
  }
  return BasicBlockVisit::Continue;
  });
@@ Expand Down @@

src/coreclr/jit/fgopt.cpp

Original file line numberDiff line numberDiff line change
@@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump)
 }
#endif // DEBUG

 // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR
 if (costIsTooHigh)
 {
 return false;
 return true;
 }

 /* Looks good - duplicate the conditional block */
@@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump)
 {
 // Clone/substitute the expression.
 Statement* stmt = gtCloneStmt(curStmt);

 // cloneExpr doesn't handle everything.
 if (stmt == nullptr)
 {
 return false;
 }
 assert(stmt != nullptr);

 if (fgNodeThreading == NodeThreading::AllTrees)
 {
Expand DownExpand Up@@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump)
 condTree = condTree->gtGetOp1();

 // This condTree has to be a RelOp comparison.
 if (condTree->OperIsCompare() == false)
 // If not, return true since we created new nodes.
 if (!condTree->OperIsCompare())
 {
 return false;
 return true;
 }

 // Join the two linked lists.
Expand Down

blocks (function() { function addCopyButtons() { document.querySelectorAll('pre code').forEach(function(codeBlock) { if (codeBlock.parentElement.hasAttribute('data-copy-added')) return; codeBlock.parentElement.setAttribute('data-copy-added', 'true'); var btn = document.createElement('button'); btn.textContent = 'Copy'; btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;'; btn.onmouseover = function() { this.style.opacity = '1'; }; btn.onmouseout = function() { this.style.opacity = '0.7'; }; btn.onclick = function() { navigator.clipboard.writeText(codeBlock.textContent).then(function() { btn.textContent = 'Copied!'; setTimeout(function() { btn.textContent = 'Copy'; }, 1500); }); }; codeBlock.parentElement.style.position = 'relative'; codeBlock.parentElement.appendChild(btn); }); } addCopyButtons(); // Re-run on dynamic content var observer = new MutationObserver(addCopyButtons); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests557 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights JIT: Graph-based loop inversion#113709 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed amanasifkhalid wants to merge 21 commits into dotnet:main from amanasifkhalid:loop-inversion-graph-based Conversation 15 Commits 21 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed JIT: Graph-based loop inversion #113709 Show file tree Hide file tree Changes from all commits Commits Show all changes 21 commits Select commit Hold shift + click to select a range a0e3e4d JIT: Make loop inversion graph based jakobbotsch Oct 29, 20245df0255 Remove debug code jakobbotsch Oct 29, 2024b75aea7 Fix release build jakobbotsch Oct 29, 2024d75f60e Avoid inverting already-inverted loops, duplicate weight manipulation… jakobbotsch Oct 30, 2024ddc0ea2 Add a couple of quirks jakobbotsch Oct 30, 202499a4321 Run jit-format jakobbotsch Oct 30, 2024757d14c Add a metric for loops inverted jakobbotsch Oct 30, 20242c82f09 Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 6, 2025e0074ff Reuse preheader for zero-trip test jakobbotsch Jan 6, 20251931c5a Compact latch block if possible jakobbotsch Jan 6, 202506854ab Run jit-format jakobbotsch Jan 6, 20256c24c53 Remove quirks jakobbotsch Jan 6, 2025f59243f Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 7, 20251437856 Merge from main; fix profile maintenance amanasifkhalid Mar 18, 2025b79fc7a Leave fgRenumberBlocks in for now amanasifkhalid Mar 18, 20258a9a547 Simplify profile maintenance amanasifkhalid Mar 19, 2025fe411d2 Remove fgRenumberBlocks call amanasifkhalid Mar 20, 202541a6246 Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 20, 20257d1e7c8 Fix fgOptimizeBranch amanasifkhalid Mar 20, 20250f12f5d Fix another spot in fgOptimizeBranch amanasifkhalid Mar 20, 2025effd81e Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 25, 2025 File filter Filter by extension Filter by extension .cpp (4) .h (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/coreclr/jit/compiler.cpp compiler.cpp src/coreclr/jit/compiler.h compiler.h src/coreclr/jit/fgdiagnostic.cpp fgdiagnostic.cpp src/coreclr/jit/fgopt.cpp fgopt.cpp src/coreclr/jit/optimizer.cpp optimizer.cpp There are no files selected for viewing 8 changes: 4 additions & 4 deletions 8 src/coreclr/jit/compiler.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4635,10 +4635,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Run some flow graph optimizations (but don't reorder) // DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow); Expand All @@ -4657,6 +4653,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Scale block weights and mark run rarely blocks. // DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights); Expand Down 2 changes: 1 addition & 1 deletion 2 src/coreclr/jit/compiler.h Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -7095,7 +7095,7 @@ class Compiler OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree); bool optInvertWhileLoop(BasicBlock* block); bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop); bool optIfConvert(BasicBlock* block); private: Expand Down 7 changes: 6 additions & 1 deletion 7 src/coreclr/jit/fgdiagnostic.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() loop->VisitRegularExitBlocks([=](BasicBlock* exit) { for (BasicBlock* pred : exit->PredBlocks()) { assert(loop->ContainsBlock(pred)); if (!loop->ContainsBlock(pred)) { JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n", loop->GetIndex(), exit->bbNum, pred->bbNum); assert(!"Loop exit has non-loop predecessor"); } } return BasicBlockVisit::Continue; }); Expand Down 15 changes: 6 additions & 9 deletions 15 src/coreclr/jit/fgopt.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) } #endif // DEBUG // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR if (costIsTooHigh) { return false; return true; } /* Looks good - duplicate the conditional block */ Expand All @@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) { // Clone/substitute the expression. Statement* stmt = gtCloneStmt(curStmt); // cloneExpr doesn't handle everything. if (stmt == nullptr) { return false; } assert(stmt != nullptr); if (fgNodeThreading == NodeThreading::AllTrees) { Expand DownExpand Up @@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) condTree = condTree->gtGetOp1(); // This condTree has to be a RelOp comparison. if (condTree->OperIsCompare() == false) // If not, return true since we created new nodes. if (!condTree->OperIsCompare()) { return false; return true; } // Join the two linked lists. Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests557 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights JIT: Graph-based loop inversion#113709 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed amanasifkhalid wants to merge 21 commits into dotnet:main from amanasifkhalid:loop-inversion-graph-based Conversation 15 Commits 21 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed JIT: Graph-based loop inversion #113709 Show file tree Hide file tree Changes from all commits Commits Show all changes 21 commits Select commit Hold shift + click to select a range a0e3e4d JIT: Make loop inversion graph based jakobbotsch Oct 29, 20245df0255 Remove debug code jakobbotsch Oct 29, 2024b75aea7 Fix release build jakobbotsch Oct 29, 2024d75f60e Avoid inverting already-inverted loops, duplicate weight manipulation… jakobbotsch Oct 30, 2024ddc0ea2 Add a couple of quirks jakobbotsch Oct 30, 202499a4321 Run jit-format jakobbotsch Oct 30, 2024757d14c Add a metric for loops inverted jakobbotsch Oct 30, 20242c82f09 Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 6, 2025e0074ff Reuse preheader for zero-trip test jakobbotsch Jan 6, 20251931c5a Compact latch block if possible jakobbotsch Jan 6, 202506854ab Run jit-format jakobbotsch Jan 6, 20256c24c53 Remove quirks jakobbotsch Jan 6, 2025f59243f Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 7, 20251437856 Merge from main; fix profile maintenance amanasifkhalid Mar 18, 2025b79fc7a Leave fgRenumberBlocks in for now amanasifkhalid Mar 18, 20258a9a547 Simplify profile maintenance amanasifkhalid Mar 19, 2025fe411d2 Remove fgRenumberBlocks call amanasifkhalid Mar 20, 202541a6246 Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 20, 20257d1e7c8 Fix fgOptimizeBranch amanasifkhalid Mar 20, 20250f12f5d Fix another spot in fgOptimizeBranch amanasifkhalid Mar 20, 2025effd81e Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 25, 2025 File filter Filter by extension Filter by extension .cpp (4) .h (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/coreclr/jit/compiler.cpp compiler.cpp src/coreclr/jit/compiler.h compiler.h src/coreclr/jit/fgdiagnostic.cpp fgdiagnostic.cpp src/coreclr/jit/fgopt.cpp fgopt.cpp src/coreclr/jit/optimizer.cpp optimizer.cpp There are no files selected for viewing 8 changes: 4 additions & 4 deletions 8 src/coreclr/jit/compiler.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4635,10 +4635,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Run some flow graph optimizations (but don't reorder) // DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow); Expand All @@ -4657,6 +4653,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Scale block weights and mark run rarely blocks. // DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights); Expand Down 2 changes: 1 addition & 1 deletion 2 src/coreclr/jit/compiler.h Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -7095,7 +7095,7 @@ class Compiler OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree); bool optInvertWhileLoop(BasicBlock* block); bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop); bool optIfConvert(BasicBlock* block); private: Expand Down 7 changes: 6 additions & 1 deletion 7 src/coreclr/jit/fgdiagnostic.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() loop->VisitRegularExitBlocks([=](BasicBlock* exit) { for (BasicBlock* pred : exit->PredBlocks()) { assert(loop->ContainsBlock(pred)); if (!loop->ContainsBlock(pred)) { JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n", loop->GetIndex(), exit->bbNum, pred->bbNum); assert(!"Loop exit has non-loop predecessor"); } } return BasicBlockVisit::Continue; }); Expand Down 15 changes: 6 additions & 9 deletions 15 src/coreclr/jit/fgopt.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) } #endif // DEBUG // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR if (costIsTooHigh) { return false; return true; } /* Looks good - duplicate the conditional block */ Expand All @@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) { // Clone/substitute the expression. Statement* stmt = gtCloneStmt(curStmt); // cloneExpr doesn't handle everything. if (stmt == nullptr) { return false; } assert(stmt != nullptr); if (fgNodeThreading == NodeThreading::AllTrees) { Expand DownExpand Up @@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) condTree = condTree->gtGetOp1(); // This condTree has to be a RelOp comparison. if (condTree->OperIsCompare() == false) // If not, return true since we created new nodes. if (!condTree->OperIsCompare()) { return false; return true; } // Join the two linked lists. Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests557 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights JIT: Graph-based loop inversion#113709 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed amanasifkhalid wants to merge 21 commits into dotnet:main from amanasifkhalid:loop-inversion-graph-based Conversation 15 Commits 21 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed JIT: Graph-based loop inversion #113709 Show file tree Hide file tree Changes from all commits Commits Show all changes 21 commits Select commit Hold shift + click to select a range a0e3e4d JIT: Make loop inversion graph based jakobbotsch Oct 29, 20245df0255 Remove debug code jakobbotsch Oct 29, 2024b75aea7 Fix release build jakobbotsch Oct 29, 2024d75f60e Avoid inverting already-inverted loops, duplicate weight manipulation… jakobbotsch Oct 30, 2024ddc0ea2 Add a couple of quirks jakobbotsch Oct 30, 202499a4321 Run jit-format jakobbotsch Oct 30, 2024757d14c Add a metric for loops inverted jakobbotsch Oct 30, 20242c82f09 Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 6, 2025e0074ff Reuse preheader for zero-trip test jakobbotsch Jan 6, 20251931c5a Compact latch block if possible jakobbotsch Jan 6, 202506854ab Run jit-format jakobbotsch Jan 6, 20256c24c53 Remove quirks jakobbotsch Jan 6, 2025f59243f Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 7, 20251437856 Merge from main; fix profile maintenance amanasifkhalid Mar 18, 2025b79fc7a Leave fgRenumberBlocks in for now amanasifkhalid Mar 18, 20258a9a547 Simplify profile maintenance amanasifkhalid Mar 19, 2025fe411d2 Remove fgRenumberBlocks call amanasifkhalid Mar 20, 202541a6246 Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 20, 20257d1e7c8 Fix fgOptimizeBranch amanasifkhalid Mar 20, 20250f12f5d Fix another spot in fgOptimizeBranch amanasifkhalid Mar 20, 2025effd81e Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 25, 2025 File filter Filter by extension Filter by extension .cpp (4) .h (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/coreclr/jit/compiler.cpp compiler.cpp src/coreclr/jit/compiler.h compiler.h src/coreclr/jit/fgdiagnostic.cpp fgdiagnostic.cpp src/coreclr/jit/fgopt.cpp fgopt.cpp src/coreclr/jit/optimizer.cpp optimizer.cpp There are no files selected for viewing 8 changes: 4 additions & 4 deletions 8 src/coreclr/jit/compiler.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4635,10 +4635,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Run some flow graph optimizations (but don't reorder) // DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow); Expand All @@ -4657,6 +4653,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Scale block weights and mark run rarely blocks. // DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights); Expand Down 2 changes: 1 addition & 1 deletion 2 src/coreclr/jit/compiler.h Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -7095,7 +7095,7 @@ class Compiler OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree); bool optInvertWhileLoop(BasicBlock* block); bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop); bool optIfConvert(BasicBlock* block); private: Expand Down 7 changes: 6 additions & 1 deletion 7 src/coreclr/jit/fgdiagnostic.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() loop->VisitRegularExitBlocks([=](BasicBlock* exit) { for (BasicBlock* pred : exit->PredBlocks()) { assert(loop->ContainsBlock(pred)); if (!loop->ContainsBlock(pred)) { JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n", loop->GetIndex(), exit->bbNum, pred->bbNum); assert(!"Loop exit has non-loop predecessor"); } } return BasicBlockVisit::Continue; }); Expand Down 15 changes: 6 additions & 9 deletions 15 src/coreclr/jit/fgopt.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) } #endif // DEBUG // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR if (costIsTooHigh) { return false; return true; } /* Looks good - duplicate the conditional block */ Expand All @@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) { // Clone/substitute the expression. Statement* stmt = gtCloneStmt(curStmt); // cloneExpr doesn't handle everything. if (stmt == nullptr) { return false; } assert(stmt != nullptr); if (fgNodeThreading == NodeThreading::AllTrees) { Expand DownExpand Up @@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) condTree = condTree->gtGetOp1(); // This condTree has to be a RelOp comparison. if (condTree->OperIsCompare() == false) // If not, return true since we created new nodes. if (!condTree->OperIsCompare()) { return false; return true; } // Join the two linked lists. Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests557 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights JIT: Graph-based loop inversion#113709 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed amanasifkhalid wants to merge 21 commits into dotnet:main from amanasifkhalid:loop-inversion-graph-based Conversation 15 Commits 21 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed JIT: Graph-based loop inversion #113709 Show file tree Hide file tree Changes from all commits Commits Show all changes 21 commits Select commit Hold shift + click to select a range a0e3e4d JIT: Make loop inversion graph based jakobbotsch Oct 29, 20245df0255 Remove debug code jakobbotsch Oct 29, 2024b75aea7 Fix release build jakobbotsch Oct 29, 2024d75f60e Avoid inverting already-inverted loops, duplicate weight manipulation… jakobbotsch Oct 30, 2024ddc0ea2 Add a couple of quirks jakobbotsch Oct 30, 202499a4321 Run jit-format jakobbotsch Oct 30, 2024757d14c Add a metric for loops inverted jakobbotsch Oct 30, 20242c82f09 Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 6, 2025e0074ff Reuse preheader for zero-trip test jakobbotsch Jan 6, 20251931c5a Compact latch block if possible jakobbotsch Jan 6, 202506854ab Run jit-format jakobbotsch Jan 6, 20256c24c53 Remove quirks jakobbotsch Jan 6, 2025f59243f Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 7, 20251437856 Merge from main; fix profile maintenance amanasifkhalid Mar 18, 2025b79fc7a Leave fgRenumberBlocks in for now amanasifkhalid Mar 18, 20258a9a547 Simplify profile maintenance amanasifkhalid Mar 19, 2025fe411d2 Remove fgRenumberBlocks call amanasifkhalid Mar 20, 202541a6246 Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 20, 20257d1e7c8 Fix fgOptimizeBranch amanasifkhalid Mar 20, 20250f12f5d Fix another spot in fgOptimizeBranch amanasifkhalid Mar 20, 2025effd81e Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 25, 2025 File filter Filter by extension Filter by extension .cpp (4) .h (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/coreclr/jit/compiler.cpp compiler.cpp src/coreclr/jit/compiler.h compiler.h src/coreclr/jit/fgdiagnostic.cpp fgdiagnostic.cpp src/coreclr/jit/fgopt.cpp fgopt.cpp src/coreclr/jit/optimizer.cpp optimizer.cpp There are no files selected for viewing 8 changes: 4 additions & 4 deletions 8 src/coreclr/jit/compiler.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4635,10 +4635,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Run some flow graph optimizations (but don't reorder) // DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow); Expand All @@ -4657,6 +4653,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Scale block weights and mark run rarely blocks. // DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights); Expand Down 2 changes: 1 addition & 1 deletion 2 src/coreclr/jit/compiler.h Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -7095,7 +7095,7 @@ class Compiler OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree); bool optInvertWhileLoop(BasicBlock* block); bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop); bool optIfConvert(BasicBlock* block); private: Expand Down 7 changes: 6 additions & 1 deletion 7 src/coreclr/jit/fgdiagnostic.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() loop->VisitRegularExitBlocks([=](BasicBlock* exit) { for (BasicBlock* pred : exit->PredBlocks()) { assert(loop->ContainsBlock(pred)); if (!loop->ContainsBlock(pred)) { JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n", loop->GetIndex(), exit->bbNum, pred->bbNum); assert(!"Loop exit has non-loop predecessor"); } } return BasicBlockVisit::Continue; }); Expand Down 15 changes: 6 additions & 9 deletions 15 src/coreclr/jit/fgopt.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) } #endif // DEBUG // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR if (costIsTooHigh) { return false; return true; } /* Looks good - duplicate the conditional block */ Expand All @@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) { // Clone/substitute the expression. Statement* stmt = gtCloneStmt(curStmt); // cloneExpr doesn't handle everything. if (stmt == nullptr) { return false; } assert(stmt != nullptr); if (fgNodeThreading == NodeThreading::AllTrees) { Expand DownExpand Up @@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) condTree = condTree->gtGetOp1(); // This condTree has to be a RelOp comparison. if (condTree->OperIsCompare() == false) // If not, return true since we created new nodes. if (!condTree->OperIsCompare()) { return false; return true; } // Join the two linked lists. Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests557 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights JIT: Graph-based loop inversion#113709 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed amanasifkhalid wants to merge 21 commits into dotnet:main from amanasifkhalid:loop-inversion-graph-based Conversation 15 Commits 21 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed JIT: Graph-based loop inversion #113709 Show file tree Hide file tree Changes from all commits Commits Show all changes 21 commits Select commit Hold shift + click to select a range a0e3e4d JIT: Make loop inversion graph based jakobbotsch Oct 29, 20245df0255 Remove debug code jakobbotsch Oct 29, 2024b75aea7 Fix release build jakobbotsch Oct 29, 2024d75f60e Avoid inverting already-inverted loops, duplicate weight manipulation… jakobbotsch Oct 30, 2024ddc0ea2 Add a couple of quirks jakobbotsch Oct 30, 202499a4321 Run jit-format jakobbotsch Oct 30, 2024757d14c Add a metric for loops inverted jakobbotsch Oct 30, 20242c82f09 Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 6, 2025e0074ff Reuse preheader for zero-trip test jakobbotsch Jan 6, 20251931c5a Compact latch block if possible jakobbotsch Jan 6, 202506854ab Run jit-format jakobbotsch Jan 6, 20256c24c53 Remove quirks jakobbotsch Jan 6, 2025f59243f Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 7, 20251437856 Merge from main; fix profile maintenance amanasifkhalid Mar 18, 2025b79fc7a Leave fgRenumberBlocks in for now amanasifkhalid Mar 18, 20258a9a547 Simplify profile maintenance amanasifkhalid Mar 19, 2025fe411d2 Remove fgRenumberBlocks call amanasifkhalid Mar 20, 202541a6246 Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 20, 20257d1e7c8 Fix fgOptimizeBranch amanasifkhalid Mar 20, 20250f12f5d Fix another spot in fgOptimizeBranch amanasifkhalid Mar 20, 2025effd81e Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 25, 2025 File filter Filter by extension Filter by extension .cpp (4) .h (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/coreclr/jit/compiler.cpp compiler.cpp src/coreclr/jit/compiler.h compiler.h src/coreclr/jit/fgdiagnostic.cpp fgdiagnostic.cpp src/coreclr/jit/fgopt.cpp fgopt.cpp src/coreclr/jit/optimizer.cpp optimizer.cpp There are no files selected for viewing 8 changes: 4 additions & 4 deletions 8 src/coreclr/jit/compiler.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4635,10 +4635,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Run some flow graph optimizations (but don't reorder) // DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow); Expand All @@ -4657,6 +4653,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Scale block weights and mark run rarely blocks. // DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights); Expand Down 2 changes: 1 addition & 1 deletion 2 src/coreclr/jit/compiler.h Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -7095,7 +7095,7 @@ class Compiler OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree); bool optInvertWhileLoop(BasicBlock* block); bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop); bool optIfConvert(BasicBlock* block); private: Expand Down 7 changes: 6 additions & 1 deletion 7 src/coreclr/jit/fgdiagnostic.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() loop->VisitRegularExitBlocks([=](BasicBlock* exit) { for (BasicBlock* pred : exit->PredBlocks()) { assert(loop->ContainsBlock(pred)); if (!loop->ContainsBlock(pred)) { JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n", loop->GetIndex(), exit->bbNum, pred->bbNum); assert(!"Loop exit has non-loop predecessor"); } } return BasicBlockVisit::Continue; }); Expand Down 15 changes: 6 additions & 9 deletions 15 src/coreclr/jit/fgopt.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) } #endif // DEBUG // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR if (costIsTooHigh) { return false; return true; } /* Looks good - duplicate the conditional block */ Expand All @@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) { // Clone/substitute the expression. Statement* stmt = gtCloneStmt(curStmt); // cloneExpr doesn't handle everything. if (stmt == nullptr) { return false; } assert(stmt != nullptr); if (fgNodeThreading == NodeThreading::AllTrees) { Expand DownExpand Up @@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) condTree = condTree->gtGetOp1(); // This condTree has to be a RelOp comparison. if (condTree->OperIsCompare() == false) // If not, return true since we created new nodes. if (!condTree->OperIsCompare()) { return false; return true; } // Join the two linked lists. Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests557 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights JIT: Graph-based loop inversion#113709 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed amanasifkhalid wants to merge 21 commits into dotnet:main from amanasifkhalid:loop-inversion-graph-based Conversation 15 Commits 21 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed JIT: Graph-based loop inversion #113709 Show file tree Hide file tree Changes from all commits Commits Show all changes 21 commits Select commit Hold shift + click to select a range a0e3e4d JIT: Make loop inversion graph based jakobbotsch Oct 29, 20245df0255 Remove debug code jakobbotsch Oct 29, 2024b75aea7 Fix release build jakobbotsch Oct 29, 2024d75f60e Avoid inverting already-inverted loops, duplicate weight manipulation… jakobbotsch Oct 30, 2024ddc0ea2 Add a couple of quirks jakobbotsch Oct 30, 202499a4321 Run jit-format jakobbotsch Oct 30, 2024757d14c Add a metric for loops inverted jakobbotsch Oct 30, 20242c82f09 Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 6, 2025e0074ff Reuse preheader for zero-trip test jakobbotsch Jan 6, 20251931c5a Compact latch block if possible jakobbotsch Jan 6, 202506854ab Run jit-format jakobbotsch Jan 6, 20256c24c53 Remove quirks jakobbotsch Jan 6, 2025f59243f Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 7, 20251437856 Merge from main; fix profile maintenance amanasifkhalid Mar 18, 2025b79fc7a Leave fgRenumberBlocks in for now amanasifkhalid Mar 18, 20258a9a547 Simplify profile maintenance amanasifkhalid Mar 19, 2025fe411d2 Remove fgRenumberBlocks call amanasifkhalid Mar 20, 202541a6246 Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 20, 20257d1e7c8 Fix fgOptimizeBranch amanasifkhalid Mar 20, 20250f12f5d Fix another spot in fgOptimizeBranch amanasifkhalid Mar 20, 2025effd81e Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 25, 2025 File filter Filter by extension Filter by extension .cpp (4) .h (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/coreclr/jit/compiler.cpp compiler.cpp src/coreclr/jit/compiler.h compiler.h src/coreclr/jit/fgdiagnostic.cpp fgdiagnostic.cpp src/coreclr/jit/fgopt.cpp fgopt.cpp src/coreclr/jit/optimizer.cpp optimizer.cpp There are no files selected for viewing 8 changes: 4 additions & 4 deletions 8 src/coreclr/jit/compiler.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4635,10 +4635,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Run some flow graph optimizations (but don't reorder) // DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow); Expand All @@ -4657,6 +4653,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Scale block weights and mark run rarely blocks. // DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights); Expand Down 2 changes: 1 addition & 1 deletion 2 src/coreclr/jit/compiler.h Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -7095,7 +7095,7 @@ class Compiler OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree); bool optInvertWhileLoop(BasicBlock* block); bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop); bool optIfConvert(BasicBlock* block); private: Expand Down 7 changes: 6 additions & 1 deletion 7 src/coreclr/jit/fgdiagnostic.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() loop->VisitRegularExitBlocks([=](BasicBlock* exit) { for (BasicBlock* pred : exit->PredBlocks()) { assert(loop->ContainsBlock(pred)); if (!loop->ContainsBlock(pred)) { JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n", loop->GetIndex(), exit->bbNum, pred->bbNum); assert(!"Loop exit has non-loop predecessor"); } } return BasicBlockVisit::Continue; }); Expand Down 15 changes: 6 additions & 9 deletions 15 src/coreclr/jit/fgopt.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) } #endif // DEBUG // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR if (costIsTooHigh) { return false; return true; } /* Looks good - duplicate the conditional block */ Expand All @@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) { // Clone/substitute the expression. Statement* stmt = gtCloneStmt(curStmt); // cloneExpr doesn't handle everything. if (stmt == nullptr) { return false; } assert(stmt != nullptr); if (fgNodeThreading == NodeThreading::AllTrees) { Expand DownExpand Up @@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) condTree = condTree->gtGetOp1(); // This condTree has to be a RelOp comparison. if (condTree->OperIsCompare() == false) // If not, return true since we created new nodes. if (!condTree->OperIsCompare()) { return false; return true; } // Join the two linked lists. Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests557 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights JIT: Graph-based loop inversion#113709 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed amanasifkhalid wants to merge 21 commits into dotnet:main from amanasifkhalid:loop-inversion-graph-based Conversation 15 Commits 21 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed JIT: Graph-based loop inversion #113709 Show file tree Hide file tree Changes from all commits Commits Show all changes 21 commits Select commit Hold shift + click to select a range a0e3e4d JIT: Make loop inversion graph based jakobbotsch Oct 29, 20245df0255 Remove debug code jakobbotsch Oct 29, 2024b75aea7 Fix release build jakobbotsch Oct 29, 2024d75f60e Avoid inverting already-inverted loops, duplicate weight manipulation… jakobbotsch Oct 30, 2024ddc0ea2 Add a couple of quirks jakobbotsch Oct 30, 202499a4321 Run jit-format jakobbotsch Oct 30, 2024757d14c Add a metric for loops inverted jakobbotsch Oct 30, 20242c82f09 Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 6, 2025e0074ff Reuse preheader for zero-trip test jakobbotsch Jan 6, 20251931c5a Compact latch block if possible jakobbotsch Jan 6, 202506854ab Run jit-format jakobbotsch Jan 6, 20256c24c53 Remove quirks jakobbotsch Jan 6, 2025f59243f Merge branch 'main' of github.com:dotnet/runtime into port-loop-inver… jakobbotsch Jan 7, 20251437856 Merge from main; fix profile maintenance amanasifkhalid Mar 18, 2025b79fc7a Leave fgRenumberBlocks in for now amanasifkhalid Mar 18, 20258a9a547 Simplify profile maintenance amanasifkhalid Mar 19, 2025fe411d2 Remove fgRenumberBlocks call amanasifkhalid Mar 20, 202541a6246 Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 20, 20257d1e7c8 Fix fgOptimizeBranch amanasifkhalid Mar 20, 20250f12f5d Fix another spot in fgOptimizeBranch amanasifkhalid Mar 20, 2025effd81e Merge branch 'main' into loop-inversion-graph-based amanasifkhalid Mar 25, 2025 File filter Filter by extension Filter by extension .cpp (4) .h (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/coreclr/jit/compiler.cpp compiler.cpp src/coreclr/jit/compiler.h compiler.h src/coreclr/jit/fgdiagnostic.cpp fgdiagnostic.cpp src/coreclr/jit/fgopt.cpp fgopt.cpp src/coreclr/jit/optimizer.cpp optimizer.cpp There are no files selected for viewing 8 changes: 4 additions & 4 deletions 8 src/coreclr/jit/compiler.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4635,10 +4635,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_EMPTY_TRY_CATCH_FAULT_2, &Compiler::fgRemoveEmptyTryCatchOrTryFault); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Run some flow graph optimizations (but don't reorder) // DoPhase(this, PHASE_OPTIMIZE_FLOW, &Compiler::optOptimizeFlow); Expand All @@ -4657,6 +4653,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl // DoPhase(this, PHASE_FIND_LOOPS, &Compiler::optFindLoopsPhase); // Invert loops // DoPhase(this, PHASE_INVERT_LOOPS, &Compiler::optInvertLoops); // Scale block weights and mark run rarely blocks. // DoPhase(this, PHASE_SET_BLOCK_WEIGHTS, &Compiler::optSetBlockWeights); Expand Down 2 changes: 1 addition & 1 deletion 2 src/coreclr/jit/compiler.h Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -7095,7 +7095,7 @@ class Compiler OptInvertCountTreeInfoType optInvertCountTreeInfo(GenTree* tree); bool optInvertWhileLoop(BasicBlock* block); bool optTryInvertWhileLoop(FlowGraphNaturalLoop* loop); bool optIfConvert(BasicBlock* block); private: Expand Down 7 changes: 6 additions & 1 deletion 7 src/coreclr/jit/fgdiagnostic.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -4737,7 +4737,12 @@ void Compiler::fgDebugCheckLoops() loop->VisitRegularExitBlocks([=](BasicBlock* exit) { for (BasicBlock* pred : exit->PredBlocks()) { assert(loop->ContainsBlock(pred)); if (!loop->ContainsBlock(pred)) { JITDUMP("Loop " FMT_LP " exit " FMT_BB " has non-loop predecessor " FMT_BB "\n", loop->GetIndex(), exit->bbNum, pred->bbNum); assert(!"Loop exit has non-loop predecessor"); } } return BasicBlockVisit::Continue; }); Expand Down 15 changes: 6 additions & 9 deletions 15 src/coreclr/jit/fgopt.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2662,9 +2662,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) } #endif // DEBUG // Computing the duplication cost may have triggered node reordering, so return true to indicate we modified IR if (costIsTooHigh) { return false; return true; } /* Looks good - duplicate the conditional block */ Expand All @@ -2678,12 +2679,7 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) { // Clone/substitute the expression. Statement* stmt = gtCloneStmt(curStmt); // cloneExpr doesn't handle everything. if (stmt == nullptr) { return false; } assert(stmt != nullptr); if (fgNodeThreading == NodeThreading::AllTrees) { Expand DownExpand Up @@ -2714,9 +2710,10 @@ bool Compiler::fgOptimizeBranch(BasicBlock* bJump) condTree = condTree->gtGetOp1(); // This condTree has to be a RelOp comparison. if (condTree->OperIsCompare() == false) // If not, return true since we created new nodes. if (!condTree->OperIsCompare()) { return false; return true; } // Join the two linked lists. Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time.