JIT: Don't compact away block in cond-to-return folding by amanasifkhalid · Pull Request #113931 · dotnet/runtime

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

amanasifkhalid · 2025-03-26T17:18:53Z

Fixes#113923. If we are considering folding a conditional block with successors that loop back to it, don't try to compact the successors, as that will quietly remove the conditional block from the flowgraph. Instead, skip compaction, and let the cond-to-return shape check fail.

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/coreclr/jit/optimizebools.cpp: Language not supported

EgorBo · 2025-03-26T18:22:40Z


-retTrueBb = block->GetTrueTarget();
-retFalseBb = block->GetFalseTarget();
+assert(block->TrueTargetIs(retTrueBb));


there is Same here - bail out if the block is no longer BBJ_COND after compacting. comment with a condition that you can remove I presume

I don't think we can remove this: Suppose the true target jumps to the false target, and we compact the false target into the true target. This will make the conditional block degenerate, since it now branches to the same target in either case. fgReplaceJumpTarget will detect this, and convert the block into a BBJ_ALWAYS, so I think we need to check for this case in the caller.

EgorBo

Good catch, totally forgot that BBJ_COND can point to itself

EgorBo · 2025-03-26T18:44:31Z

 // By the time we get to the retFalseBb, it might be removed by fgCompactBlock()
 // so we need to check if it is still valid.
- if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb))
+ if (!retFalseBb->HasFlag(BBF_REMOVED) && fgCanCompactBlock(retFalseBb) && !retFalseBb->TargetIs(block))


presumably you also don't need !retFalseBb->HasFlag(BBF_REMOVED) check

I think we still need this too in the case of the diamond shape: If the true target jumps to the false target and we compact them, retFalseBb will be removed from the flowgraph. This check currently defends against this case.

amanasifkhalid · 2025-03-26T19:13:45Z

No diffs

amanasifkhalid · 2025-03-26T20:25:47Z

/ba-g timeouts on Azure Linux 3 queues

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Don't compact away block in cond-to-return folding
233c963

CopilotAI review requested due to automatic review settings March 26, 2025 17:18

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2025

CopilotAI reviewed Mar 26, 2025
View reviewed changes

dotnet-policy-serviceBot assigned amanasifkhalid Mar 26, 2025

EgorBo reviewed Mar 26, 2025
View reviewed changes

EgorBo approved these changes Mar 26, 2025
View reviewed changes

EgorBo reviewed Mar 26, 2025
View reviewed changes

amanasifkhalid merged commit ef1a8ab into dotnet:mainMar 26, 2025

amanasifkhalid deleted the cond-return-fold-compaction branch March 26, 2025 20:26

This was referenced Mar 26, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.Requests test timeout #113883
Closed

github-actionsBot locked and limited conversation to collaborators Apr 26, 2025

Uh oh!

Conversation

amanasifkhalid commented Mar 26, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EgorBo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Mar 26, 2025

Uh oh!

amanasifkhalid commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amanasifkhalid commented Mar 26, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EgorBo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Mar 26, 2025

Uh oh!

amanasifkhalid commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amanasifkhalid commented Mar 26, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EgorBo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Mar 26, 2025

Uh oh!