Skip to content

Add CPUID for AvxVnniInt8 and AvxVnniInt16 - #113956

Merged
tannergooding merged 48 commits into
dotnet:mainfrom
khushal1996:kcm-avxvnniint8-cpuid
Jul 7, 2025
Merged

Add CPUID for AvxVnniInt8 and AvxVnniInt16#113956
tannergooding merged 48 commits into
dotnet:mainfrom
khushal1996:kcm-avxvnniint8-cpuid

Conversation

@khushal1996

@khushal1996khushal1996 commented Mar 27, 2025•
edited by tannergooding
Loading

Copy link
Copy Markdown
Member

This PR adds support for CPUID for AVX-VNNI-INT8 & AVX-VNNI-INT16 ISAs

This resolves#112586

Design

image
image

The changes are made in a way to enable the 2 ISAs when

  1. Avx10.2 is enabled or
  2. CPUID for both ISAs are enabled

This is w.r.t the discussions done in API proposal #112586

Testing

Note1: Emitter unit tests not ran since they are added and verified along with AVX10.2 PR #111209

Note2: Superpmi results are not accurate since we are adding a new CPUID and it leads to a new jiteeversionguid. Even after changing the jiteeversion manually, superpmi run shows errors and failures based on the old mch files which can be ignored.

Run JIT subtree with AVXVNNIINT* enabled / disabled

AVXVNNIINT* Enabled
image

AVXVNNIINT* disabled
image

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 27, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Mar 27, 2025
@khushal1996
khushal1996force-pushed the kcm-avxvnniint8-cpuid branch from 6714249 to 141d643CompareMarch 27, 2025 02:06
This was referenced Mar 27, 2025
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
@khushal1996
khushal1996 marked this pull request as ready for review March 27, 2025 06:07
@khushal1996

khushal1996 commented Mar 27, 2025

Copy link
Copy Markdown
MemberAuthor

@tannergooding This is first of the 2 PRs needed for AVX VNNI INT* API introduction #112586

tannergooding
tannergooding reviewed Mar 27, 2025
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsic.cpp Outdated
saucecontrol
saucecontrol reviewed Mar 27, 2025
View reviewed changes
Comment threadsrc/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt Outdated
@khushal1996
khushal1996force-pushed the kcm-avxvnniint8-cpuid branch from 141d643 to 98fc970CompareApril 14, 2025 21:40
@khushal1996

khushal1996 commented Apr 14, 2025

Copy link
Copy Markdown
MemberAuthor

@tannergooding@saucecontrol I have added the CPUID, API surface, JIT handling and template tests here.

@tannergooding
tannergooding self-requested a review April 14, 2025 21:44
@tannergoodingtannergooding self-assigned this Apr 14, 2025
saucecontrol
saucecontrol reviewed Apr 14, 2025
View reviewed changes
Comment threadsrc/coreclr/tools/Common/InstructionSetHelpers.cs Outdated
This was referenced Apr 15, 2025
Open
Open
Closed
Open
Open
Open
Open
@khushal1996
khushal1996force-pushed the kcm-avxvnniint8-cpuid branch from e6cf454 to 90fa072CompareApril 18, 2025 02:13
@build-analysisbuild-analysisBot mentioned this pull request Apr 18, 2025
Closed
3 tasks
tannergooding
tannergooding reviewed Jun 18, 2025
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenxarch.cpp Outdated
tannergooding
tannergooding reviewed Jun 18, 2025
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsiccodegenxarch.cpp
tannergooding
tannergooding reviewed Jun 18, 2025
View reviewed changes
Comment threadsrc/native/minipal/cpufeatures.c Outdated
tannergooding
tannergooding approved these changes Jun 18, 2025
View reviewed changes

@tannergoodingtannergooding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus a couple nits on ways to simplify the diffs.

CC. @dotnet/jit-contrib for secondary review

This was referenced Jun 23, 2025
Closed
Closed
Closed
@tannergooding
tannergooding requested review from EgorBo and removed request for saucecontrolJune 23, 2025 14:44
@EgorBo

EgorBo commented Jul 1, 2025

Copy link
Copy Markdown
Member

@khushal1996 could you please resolve the merge conflict?

tannergooding
tannergooding reviewed Jul 1, 2025
View reviewed changes
Comment threadsrc/coreclr/jit/emitxarch.cpp
@tannergooding

tannergooding commented Jul 6, 2025

Copy link
Copy Markdown
Member

Resolved the merge conflicts. I'll get this merged once CI completes

@khushal1996

khushal1996 commented Jul 6, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks @tannergooding for picking this up. Let me know if you want me to take over if the CI fails.

This was referenced Jul 7, 2025
Open
Open
Closed
Closed
Open
@tannergooding
tannergooding merged commit c6f6a09 into dotnet:mainJul 7, 2025
158 of 167 checks passed
@khushal1996

khushal1996 commented Jul 7, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for helping with the review and fixes @tannergooding

@tannergooding

tannergooding commented Jul 7, 2025

Copy link
Copy Markdown
Member

Thanks as well for getting the feature implemented and done @khushal1996. Fixes were just some minor merge conflict fixes from other cleanup/simplifications that had happened

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@EgorBoEgorBoEgorBo approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@marafmarafAwaiting requested review from maraf
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@janvorlijanvorliAwaiting requested review from janvorli
@kgkgAwaiting requested review from kg
+1 more reviewer
@saucecontrolsaucecontrolsaucecontrol left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.Intrinsicscommunity-contributionIndicates that the PR has been added by a community memberlinkable-frameworkIssues associated with delivering a linker friendly framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add AVX-VNNI-INT8 and AVX-VNNI-INT16 API

5 participants

@khushal1996@tannergooding@EgorBo@saucecontrol@teo-tsirpanis