Uh oh!
There was an error while loading. Please reload this page.
[release/9.0] Move DAC signing identity to PME - #114031
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the signing identity for diagnostic binaries to use the new PME configuration.
- Updated connected service and authentication IDs to the PME values.
- Revised certificate and tenant information accordingly.
Comments suppressed due to low confidence (2)
eng/pipelines/coreclr/templates/sign-diagnostic-files.yml:18
- Verify that the new connected service name 'diagnostics-esrp-kvcertuser-pme' is correctly set up in your environment to ensure proper connectivity.
ConnectedServiceName: 'diagnostics-esrp-kvcertuser-pme'
eng/pipelines/coreclr/templates/sign-diagnostic-files.yml:23
- Confirm that the updated AuthSignCertName 'dac-dnceng-esrpclient-cert' matches the PME certificate configuration and that the corresponding certificate is available.
AuthSignCertName: 'dac-dnceng-esrpclient-cert'
hoyosjs
commented
Mar 29, 2025
MemberAuthor
/backport to release/8.0-staging |
Contributor
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14141875850 |
jkoritzinsky
approved these changes
Mar 29, 2025
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. please get a code review. we can treat this as tell mode
tommcdon
approved these changes
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for SFI requirement of ESRP isolation to production tenants.