[cDAC] Support passing global string values by max-charlamb · Pull Request #114085 · dotnet/runtime

max-charlamb · 2025-03-31T21:36:20Z

Will be used in #113899 to pass target runtime identifier.

To support passing global strings, I have modified the data descriptor spec. Previously globals were of the form

[ VALUE | [int], "type name" ]
or
VALUE | [int]

Where the VALUE may be a JSON numeric constant integer or a string containing a signed or unsigned decimal or hex (with prefix 0x or 0X) integer constant.

I have modified VALUE to be less constrained: VALUE may be either a number or a string. JSON numeric constants are always parsed as numbers. JSON strings are always parsed as strings and may additionally parse as a hex (with prefix 0x or 0X) or decimal number.

To fit the new spec, the cDAC data contract implementation was modified in three main:

The datadescriptor.h and datadescriptor.cpp in the runtime.
- Added mechanism CDAC_GLOBAL_STRING(name, value) to pass global strings which are a mapping of a string (name) to string (value). Both strings exist in the existing string pool.
The cdac-build-tool which takes the obj file and converts it to a JSON human readable contract.
- Modified to parse global strings from the obj and properly convert to JSON.
The parser inside of cdacreader which reads the JSON into a Target.
- Modified to parse global strings and allow fetching existing stringy number globals as strings.

With this change existing stringy numbers can be parsed as either a number or a string.

Example:

{
"globals": {
"stringValue" : "Hello world",
"stringyInt" : "1234",
"stringyHex" : "0x1234",
"int" : 1234
}
}

target.ReadGlobalString("stringValue");// "Hello world"target.ReadGlobal<ulong>("stringValue");// Exception!! cannot be parsed as a numbertarget.ReadGlobalString("stringyInt");// "1234"target.ReadGlobal<ulong>("stringyInt");// 1234target.ReadGlobalString("stringyHex");// "0x1234"target.ReadGlobal<ulong>("stringyHex");// 4660 (0x1234)target.ReadGlobalString("int");// Exception!! no string representation for JSON Numberstarget.ReadGlobal<ulong>("int");// 1234

Copilot

Pull Request Overview

This PR adds support for passing global string values to the data contract reader and descriptor model. Key changes include:

Introducing new fields and APIs for global strings in targets and builders.
Enhancing test coverage with new tests for reading global string values.
Updating the build tool and parser to handle global string specifications in the data descriptor blob.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/native/managed/cdacreader/tests/TestPlaceholderTarget.cs	Added global strings field and TryReadGlobalString method.
src/native/managed/cdacreader/tests/ContractDescriptor/TargetTests.cs	Added tests to validate global string value reading.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorHelpers.cs	Added helper for JSON serialization of global strings.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorBuilder.cs	Extended builder API to include global strings.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs	Integrated global strings into target reading.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs	Added global strings support in JSON serialization and diagnostics.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs	Defined abstract TryReadGlobalString method.
src/coreclr/tools/cdac-build-tool/data-descriptor-blob.md	Updated blob specification to include GlobalStringSpec.
src/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs	Modified header reading and parsing logic to handle global string specs.
src/coreclr/tools/cdac-build-tool/DataDescriptorModel.cs	Extended descriptor model to incorporate global strings.

Files not reviewed (4)

src/coreclr/debug/runtimeinfo/datadescriptor.cpp: Language not supported
src/coreclr/debug/runtimeinfo/datadescriptor.h: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.blob.c: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.data.h: Language not supported

dotnet-policy-service · 2025-03-31T21:36:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

davmason · 2025-04-02T19:33:20Z

+ return new GlobalDescriptor { NumericValue = valueCase1, Kind = GlobalDescriptor.KindEnum.Direct };
+ // Case 2: string
+ if (TryGetStringFromToken(ref reader, out string valueCase2))
+ return new GlobalDescriptor { StringValue = valueCase2, Kind = GlobalDescriptor.KindEnum.String };


I don't like the algorithm of "try a number, if it fails it is a string." Since we own the spec we should be able to do better. Is there a reason we have to have the implicit string type and can't just use the explicit one?

You mean the type of the json node or the optional string representing the type of the value?

I meant the optional string, could we have a string by itself be a number and only treat it as a string if we add the optional type

max-charlamb · 2025-04-03T20:51:05Z

Closing as this content was combined in #113899

max-charlamb · 2025-03-31T21:36:20Z

Will be used in #113899 to pass target runtime identifier.

To support passing global strings, I have modified the data descriptor spec. Previously globals were of the form

[ VALUE | [int], "type name" ]
or
VALUE | [int]

Where the VALUE may be a JSON numeric constant integer or a string containing a signed or unsigned decimal or hex (with prefix 0x or 0X) integer constant.

I have modified VALUE to be less constrained: VALUE may be either a number or a string. JSON numeric constants are always parsed as numbers. JSON strings are always parsed as strings and may additionally parse as a hex (with prefix 0x or 0X) or decimal number.

To fit the new spec, the cDAC data contract implementation was modified in three main:

The datadescriptor.h and datadescriptor.cpp in the runtime.
- Added mechanism CDAC_GLOBAL_STRING(name, value) to pass global strings which are a mapping of a string (name) to string (value). Both strings exist in the existing string pool.
The cdac-build-tool which takes the obj file and converts it to a JSON human readable contract.
- Modified to parse global strings from the obj and properly convert to JSON.
The parser inside of cdacreader which reads the JSON into a Target.
- Modified to parse global strings and allow fetching existing stringy number globals as strings.

With this change existing stringy numbers can be parsed as either a number or a string.

Example:

{
"globals": {
"stringValue" : "Hello world",
"stringyInt" : "1234",
"stringyHex" : "0x1234",
"int" : 1234
}
}

target.ReadGlobalString("stringValue");// "Hello world"target.ReadGlobal<ulong>("stringValue");// Exception!! cannot be parsed as a numbertarget.ReadGlobalString("stringyInt");// "1234"target.ReadGlobal<ulong>("stringyInt");// 1234target.ReadGlobalString("stringyHex");// "0x1234"target.ReadGlobal<ulong>("stringyHex");// 4660 (0x1234)target.ReadGlobalString("int");// Exception!! no string representation for JSON Numberstarget.ReadGlobal<ulong>("int");// 1234

Copilot

Pull Request Overview

This PR adds support for passing global string values to the data contract reader and descriptor model. Key changes include:

Introducing new fields and APIs for global strings in targets and builders.
Enhancing test coverage with new tests for reading global string values.
Updating the build tool and parser to handle global string specifications in the data descriptor blob.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/native/managed/cdacreader/tests/TestPlaceholderTarget.cs	Added global strings field and TryReadGlobalString method.
src/native/managed/cdacreader/tests/ContractDescriptor/TargetTests.cs	Added tests to validate global string value reading.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorHelpers.cs	Added helper for JSON serialization of global strings.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorBuilder.cs	Extended builder API to include global strings.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs	Integrated global strings into target reading.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs	Added global strings support in JSON serialization and diagnostics.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs	Defined abstract TryReadGlobalString method.
src/coreclr/tools/cdac-build-tool/data-descriptor-blob.md	Updated blob specification to include GlobalStringSpec.
src/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs	Modified header reading and parsing logic to handle global string specs.
src/coreclr/tools/cdac-build-tool/DataDescriptorModel.cs	Extended descriptor model to incorporate global strings.

Files not reviewed (4)

src/coreclr/debug/runtimeinfo/datadescriptor.cpp: Language not supported
src/coreclr/debug/runtimeinfo/datadescriptor.h: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.blob.c: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.data.h: Language not supported

dotnet-policy-service · 2025-03-31T21:36:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

davmason · 2025-04-02T19:33:20Z

+ return new GlobalDescriptor { NumericValue = valueCase1, Kind = GlobalDescriptor.KindEnum.Direct };
+ // Case 2: string
+ if (TryGetStringFromToken(ref reader, out string valueCase2))
+ return new GlobalDescriptor { StringValue = valueCase2, Kind = GlobalDescriptor.KindEnum.String };


I don't like the algorithm of "try a number, if it fails it is a string." Since we own the spec we should be able to do better. Is there a reason we have to have the implicit string type and can't just use the explicit one?

You mean the type of the json node or the optional string representing the type of the value?

I meant the optional string, could we have a string by itself be a number and only treat it as a string if we add the optional type

max-charlamb · 2025-04-03T20:51:05Z

Closing as this content was combined in #113899

max-charlamb · 2025-03-31T21:36:20Z

Will be used in #113899 to pass target runtime identifier.

To support passing global strings, I have modified the data descriptor spec. Previously globals were of the form

[ VALUE | [int], "type name" ]
or
VALUE | [int]

Where the VALUE may be a JSON numeric constant integer or a string containing a signed or unsigned decimal or hex (with prefix 0x or 0X) integer constant.

I have modified VALUE to be less constrained: VALUE may be either a number or a string. JSON numeric constants are always parsed as numbers. JSON strings are always parsed as strings and may additionally parse as a hex (with prefix 0x or 0X) or decimal number.

To fit the new spec, the cDAC data contract implementation was modified in three main:

The datadescriptor.h and datadescriptor.cpp in the runtime.
- Added mechanism CDAC_GLOBAL_STRING(name, value) to pass global strings which are a mapping of a string (name) to string (value). Both strings exist in the existing string pool.
The cdac-build-tool which takes the obj file and converts it to a JSON human readable contract.
- Modified to parse global strings from the obj and properly convert to JSON.
The parser inside of cdacreader which reads the JSON into a Target.
- Modified to parse global strings and allow fetching existing stringy number globals as strings.

With this change existing stringy numbers can be parsed as either a number or a string.

Example:

{
"globals": {
"stringValue" : "Hello world",
"stringyInt" : "1234",
"stringyHex" : "0x1234",
"int" : 1234
}
}

target.ReadGlobalString("stringValue");// "Hello world"target.ReadGlobal<ulong>("stringValue");// Exception!! cannot be parsed as a numbertarget.ReadGlobalString("stringyInt");// "1234"target.ReadGlobal<ulong>("stringyInt");// 1234target.ReadGlobalString("stringyHex");// "0x1234"target.ReadGlobal<ulong>("stringyHex");// 4660 (0x1234)target.ReadGlobalString("int");// Exception!! no string representation for JSON Numberstarget.ReadGlobal<ulong>("int");// 1234

Copilot

Pull Request Overview

This PR adds support for passing global string values to the data contract reader and descriptor model. Key changes include:

Introducing new fields and APIs for global strings in targets and builders.
Enhancing test coverage with new tests for reading global string values.
Updating the build tool and parser to handle global string specifications in the data descriptor blob.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/native/managed/cdacreader/tests/TestPlaceholderTarget.cs	Added global strings field and TryReadGlobalString method.
src/native/managed/cdacreader/tests/ContractDescriptor/TargetTests.cs	Added tests to validate global string value reading.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorHelpers.cs	Added helper for JSON serialization of global strings.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorBuilder.cs	Extended builder API to include global strings.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs	Integrated global strings into target reading.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs	Added global strings support in JSON serialization and diagnostics.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs	Defined abstract TryReadGlobalString method.
src/coreclr/tools/cdac-build-tool/data-descriptor-blob.md	Updated blob specification to include GlobalStringSpec.
src/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs	Modified header reading and parsing logic to handle global string specs.
src/coreclr/tools/cdac-build-tool/DataDescriptorModel.cs	Extended descriptor model to incorporate global strings.

Files not reviewed (4)

src/coreclr/debug/runtimeinfo/datadescriptor.cpp: Language not supported
src/coreclr/debug/runtimeinfo/datadescriptor.h: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.blob.c: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.data.h: Language not supported

dotnet-policy-service · 2025-03-31T21:36:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

davmason · 2025-04-02T19:33:20Z

+ return new GlobalDescriptor { NumericValue = valueCase1, Kind = GlobalDescriptor.KindEnum.Direct };
+ // Case 2: string
+ if (TryGetStringFromToken(ref reader, out string valueCase2))
+ return new GlobalDescriptor { StringValue = valueCase2, Kind = GlobalDescriptor.KindEnum.String };


I don't like the algorithm of "try a number, if it fails it is a string." Since we own the spec we should be able to do better. Is there a reason we have to have the implicit string type and can't just use the explicit one?

You mean the type of the json node or the optional string representing the type of the value?

I meant the optional string, could we have a string by itself be a number and only treat it as a string if we add the optional type

max-charlamb · 2025-04-03T20:51:05Z

Closing as this content was combined in #113899

max-charlamb · 2025-03-31T21:36:20Z

Will be used in #113899 to pass target runtime identifier.

To support passing global strings, I have modified the data descriptor spec. Previously globals were of the form

[ VALUE | [int], "type name" ]
or
VALUE | [int]

Where the VALUE may be a JSON numeric constant integer or a string containing a signed or unsigned decimal or hex (with prefix 0x or 0X) integer constant.

I have modified VALUE to be less constrained: VALUE may be either a number or a string. JSON numeric constants are always parsed as numbers. JSON strings are always parsed as strings and may additionally parse as a hex (with prefix 0x or 0X) or decimal number.

To fit the new spec, the cDAC data contract implementation was modified in three main:

The datadescriptor.h and datadescriptor.cpp in the runtime.
- Added mechanism CDAC_GLOBAL_STRING(name, value) to pass global strings which are a mapping of a string (name) to string (value). Both strings exist in the existing string pool.
The cdac-build-tool which takes the obj file and converts it to a JSON human readable contract.
- Modified to parse global strings from the obj and properly convert to JSON.
The parser inside of cdacreader which reads the JSON into a Target.
- Modified to parse global strings and allow fetching existing stringy number globals as strings.

With this change existing stringy numbers can be parsed as either a number or a string.

Example:

{
"globals": {
"stringValue" : "Hello world",
"stringyInt" : "1234",
"stringyHex" : "0x1234",
"int" : 1234
}
}

target.ReadGlobalString("stringValue");// "Hello world"target.ReadGlobal<ulong>("stringValue");// Exception!! cannot be parsed as a numbertarget.ReadGlobalString("stringyInt");// "1234"target.ReadGlobal<ulong>("stringyInt");// 1234target.ReadGlobalString("stringyHex");// "0x1234"target.ReadGlobal<ulong>("stringyHex");// 4660 (0x1234)target.ReadGlobalString("int");// Exception!! no string representation for JSON Numberstarget.ReadGlobal<ulong>("int");// 1234

Copilot

Pull Request Overview

This PR adds support for passing global string values to the data contract reader and descriptor model. Key changes include:

Introducing new fields and APIs for global strings in targets and builders.
Enhancing test coverage with new tests for reading global string values.
Updating the build tool and parser to handle global string specifications in the data descriptor blob.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/native/managed/cdacreader/tests/TestPlaceholderTarget.cs	Added global strings field and TryReadGlobalString method.
src/native/managed/cdacreader/tests/ContractDescriptor/TargetTests.cs	Added tests to validate global string value reading.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorHelpers.cs	Added helper for JSON serialization of global strings.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorBuilder.cs	Extended builder API to include global strings.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs	Integrated global strings into target reading.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs	Added global strings support in JSON serialization and diagnostics.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs	Defined abstract TryReadGlobalString method.
src/coreclr/tools/cdac-build-tool/data-descriptor-blob.md	Updated blob specification to include GlobalStringSpec.
src/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs	Modified header reading and parsing logic to handle global string specs.
src/coreclr/tools/cdac-build-tool/DataDescriptorModel.cs	Extended descriptor model to incorporate global strings.

Files not reviewed (4)

src/coreclr/debug/runtimeinfo/datadescriptor.cpp: Language not supported
src/coreclr/debug/runtimeinfo/datadescriptor.h: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.blob.c: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.data.h: Language not supported

dotnet-policy-service · 2025-03-31T21:36:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

davmason · 2025-04-02T19:33:20Z

+ return new GlobalDescriptor { NumericValue = valueCase1, Kind = GlobalDescriptor.KindEnum.Direct };
+ // Case 2: string
+ if (TryGetStringFromToken(ref reader, out string valueCase2))
+ return new GlobalDescriptor { StringValue = valueCase2, Kind = GlobalDescriptor.KindEnum.String };


I don't like the algorithm of "try a number, if it fails it is a string." Since we own the spec we should be able to do better. Is there a reason we have to have the implicit string type and can't just use the explicit one?

You mean the type of the json node or the optional string representing the type of the value?

I meant the optional string, could we have a string by itself be a number and only treat it as a string if we add the optional type

max-charlamb · 2025-04-03T20:51:05Z

Closing as this content was combined in #113899

max-charlamb · 2025-03-31T21:36:20Z

Will be used in #113899 to pass target runtime identifier.

To support passing global strings, I have modified the data descriptor spec. Previously globals were of the form

[ VALUE | [int], "type name" ]
or
VALUE | [int]

Where the VALUE may be a JSON numeric constant integer or a string containing a signed or unsigned decimal or hex (with prefix 0x or 0X) integer constant.

I have modified VALUE to be less constrained: VALUE may be either a number or a string. JSON numeric constants are always parsed as numbers. JSON strings are always parsed as strings and may additionally parse as a hex (with prefix 0x or 0X) or decimal number.

To fit the new spec, the cDAC data contract implementation was modified in three main:

The datadescriptor.h and datadescriptor.cpp in the runtime.
- Added mechanism CDAC_GLOBAL_STRING(name, value) to pass global strings which are a mapping of a string (name) to string (value). Both strings exist in the existing string pool.
The cdac-build-tool which takes the obj file and converts it to a JSON human readable contract.
- Modified to parse global strings from the obj and properly convert to JSON.
The parser inside of cdacreader which reads the JSON into a Target.
- Modified to parse global strings and allow fetching existing stringy number globals as strings.

With this change existing stringy numbers can be parsed as either a number or a string.

Example:

{
"globals": {
"stringValue" : "Hello world",
"stringyInt" : "1234",
"stringyHex" : "0x1234",
"int" : 1234
}
}

target.ReadGlobalString("stringValue");// "Hello world"target.ReadGlobal<ulong>("stringValue");// Exception!! cannot be parsed as a numbertarget.ReadGlobalString("stringyInt");// "1234"target.ReadGlobal<ulong>("stringyInt");// 1234target.ReadGlobalString("stringyHex");// "0x1234"target.ReadGlobal<ulong>("stringyHex");// 4660 (0x1234)target.ReadGlobalString("int");// Exception!! no string representation for JSON Numberstarget.ReadGlobal<ulong>("int");// 1234

Copilot

Pull Request Overview

This PR adds support for passing global string values to the data contract reader and descriptor model. Key changes include:

Introducing new fields and APIs for global strings in targets and builders.
Enhancing test coverage with new tests for reading global string values.
Updating the build tool and parser to handle global string specifications in the data descriptor blob.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/native/managed/cdacreader/tests/TestPlaceholderTarget.cs	Added global strings field and TryReadGlobalString method.
src/native/managed/cdacreader/tests/ContractDescriptor/TargetTests.cs	Added tests to validate global string value reading.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorHelpers.cs	Added helper for JSON serialization of global strings.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorBuilder.cs	Extended builder API to include global strings.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs	Integrated global strings into target reading.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs	Added global strings support in JSON serialization and diagnostics.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs	Defined abstract TryReadGlobalString method.
src/coreclr/tools/cdac-build-tool/data-descriptor-blob.md	Updated blob specification to include GlobalStringSpec.
src/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs	Modified header reading and parsing logic to handle global string specs.
src/coreclr/tools/cdac-build-tool/DataDescriptorModel.cs	Extended descriptor model to incorporate global strings.

Files not reviewed (4)

src/coreclr/debug/runtimeinfo/datadescriptor.cpp: Language not supported
src/coreclr/debug/runtimeinfo/datadescriptor.h: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.blob.c: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.data.h: Language not supported

dotnet-policy-service · 2025-03-31T21:36:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

davmason · 2025-04-02T19:33:20Z

+ return new GlobalDescriptor { NumericValue = valueCase1, Kind = GlobalDescriptor.KindEnum.Direct };
+ // Case 2: string
+ if (TryGetStringFromToken(ref reader, out string valueCase2))
+ return new GlobalDescriptor { StringValue = valueCase2, Kind = GlobalDescriptor.KindEnum.String };


I don't like the algorithm of "try a number, if it fails it is a string." Since we own the spec we should be able to do better. Is there a reason we have to have the implicit string type and can't just use the explicit one?

You mean the type of the json node or the optional string representing the type of the value?

I meant the optional string, could we have a string by itself be a number and only treat it as a string if we add the optional type

max-charlamb · 2025-04-03T20:51:05Z

Closing as this content was combined in #113899

max-charlamb · 2025-03-31T21:36:20Z

Will be used in #113899 to pass target runtime identifier.

To support passing global strings, I have modified the data descriptor spec. Previously globals were of the form

[ VALUE | [int], "type name" ]
or
VALUE | [int]

Where the VALUE may be a JSON numeric constant integer or a string containing a signed or unsigned decimal or hex (with prefix 0x or 0X) integer constant.

I have modified VALUE to be less constrained: VALUE may be either a number or a string. JSON numeric constants are always parsed as numbers. JSON strings are always parsed as strings and may additionally parse as a hex (with prefix 0x or 0X) or decimal number.

To fit the new spec, the cDAC data contract implementation was modified in three main:

The datadescriptor.h and datadescriptor.cpp in the runtime.
- Added mechanism CDAC_GLOBAL_STRING(name, value) to pass global strings which are a mapping of a string (name) to string (value). Both strings exist in the existing string pool.
The cdac-build-tool which takes the obj file and converts it to a JSON human readable contract.
- Modified to parse global strings from the obj and properly convert to JSON.
The parser inside of cdacreader which reads the JSON into a Target.
- Modified to parse global strings and allow fetching existing stringy number globals as strings.

With this change existing stringy numbers can be parsed as either a number or a string.

Example:

{
"globals": {
"stringValue" : "Hello world",
"stringyInt" : "1234",
"stringyHex" : "0x1234",
"int" : 1234
}
}

target.ReadGlobalString("stringValue");// "Hello world"target.ReadGlobal<ulong>("stringValue");// Exception!! cannot be parsed as a numbertarget.ReadGlobalString("stringyInt");// "1234"target.ReadGlobal<ulong>("stringyInt");// 1234target.ReadGlobalString("stringyHex");// "0x1234"target.ReadGlobal<ulong>("stringyHex");// 4660 (0x1234)target.ReadGlobalString("int");// Exception!! no string representation for JSON Numberstarget.ReadGlobal<ulong>("int");// 1234

Copilot

Pull Request Overview

This PR adds support for passing global string values to the data contract reader and descriptor model. Key changes include:

Introducing new fields and APIs for global strings in targets and builders.
Enhancing test coverage with new tests for reading global string values.
Updating the build tool and parser to handle global string specifications in the data descriptor blob.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/native/managed/cdacreader/tests/TestPlaceholderTarget.cs	Added global strings field and TryReadGlobalString method.
src/native/managed/cdacreader/tests/ContractDescriptor/TargetTests.cs	Added tests to validate global string value reading.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorHelpers.cs	Added helper for JSON serialization of global strings.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorBuilder.cs	Extended builder API to include global strings.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs	Integrated global strings into target reading.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs	Added global strings support in JSON serialization and diagnostics.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs	Defined abstract TryReadGlobalString method.
src/coreclr/tools/cdac-build-tool/data-descriptor-blob.md	Updated blob specification to include GlobalStringSpec.
src/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs	Modified header reading and parsing logic to handle global string specs.
src/coreclr/tools/cdac-build-tool/DataDescriptorModel.cs	Extended descriptor model to incorporate global strings.

Files not reviewed (4)

src/coreclr/debug/runtimeinfo/datadescriptor.cpp: Language not supported
src/coreclr/debug/runtimeinfo/datadescriptor.h: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.blob.c: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.data.h: Language not supported

dotnet-policy-service · 2025-03-31T21:36:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

davmason · 2025-04-02T19:33:20Z

+ return new GlobalDescriptor { NumericValue = valueCase1, Kind = GlobalDescriptor.KindEnum.Direct };
+ // Case 2: string
+ if (TryGetStringFromToken(ref reader, out string valueCase2))
+ return new GlobalDescriptor { StringValue = valueCase2, Kind = GlobalDescriptor.KindEnum.String };


I don't like the algorithm of "try a number, if it fails it is a string." Since we own the spec we should be able to do better. Is there a reason we have to have the implicit string type and can't just use the explicit one?

You mean the type of the json node or the optional string representing the type of the value?

I meant the optional string, could we have a string by itself be a number and only treat it as a string if we add the optional type

max-charlamb · 2025-04-03T20:51:05Z

Closing as this content was combined in #113899

max-charlamb · 2025-03-31T21:36:20Z

Will be used in #113899 to pass target runtime identifier.

To support passing global strings, I have modified the data descriptor spec. Previously globals were of the form

[ VALUE | [int], "type name" ]
or
VALUE | [int]

Where the VALUE may be a JSON numeric constant integer or a string containing a signed or unsigned decimal or hex (with prefix 0x or 0X) integer constant.

I have modified VALUE to be less constrained: VALUE may be either a number or a string. JSON numeric constants are always parsed as numbers. JSON strings are always parsed as strings and may additionally parse as a hex (with prefix 0x or 0X) or decimal number.

To fit the new spec, the cDAC data contract implementation was modified in three main:

The datadescriptor.h and datadescriptor.cpp in the runtime.
- Added mechanism CDAC_GLOBAL_STRING(name, value) to pass global strings which are a mapping of a string (name) to string (value). Both strings exist in the existing string pool.
The cdac-build-tool which takes the obj file and converts it to a JSON human readable contract.
- Modified to parse global strings from the obj and properly convert to JSON.
The parser inside of cdacreader which reads the JSON into a Target.
- Modified to parse global strings and allow fetching existing stringy number globals as strings.

With this change existing stringy numbers can be parsed as either a number or a string.

Example:

{
"globals": {
"stringValue" : "Hello world",
"stringyInt" : "1234",
"stringyHex" : "0x1234",
"int" : 1234
}
}

target.ReadGlobalString("stringValue");// "Hello world"target.ReadGlobal<ulong>("stringValue");// Exception!! cannot be parsed as a numbertarget.ReadGlobalString("stringyInt");// "1234"target.ReadGlobal<ulong>("stringyInt");// 1234target.ReadGlobalString("stringyHex");// "0x1234"target.ReadGlobal<ulong>("stringyHex");// 4660 (0x1234)target.ReadGlobalString("int");// Exception!! no string representation for JSON Numberstarget.ReadGlobal<ulong>("int");// 1234

Copilot

Pull Request Overview

This PR adds support for passing global string values to the data contract reader and descriptor model. Key changes include:

Introducing new fields and APIs for global strings in targets and builders.
Enhancing test coverage with new tests for reading global string values.
Updating the build tool and parser to handle global string specifications in the data descriptor blob.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/native/managed/cdacreader/tests/TestPlaceholderTarget.cs	Added global strings field and TryReadGlobalString method.
src/native/managed/cdacreader/tests/ContractDescriptor/TargetTests.cs	Added tests to validate global string value reading.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorHelpers.cs	Added helper for JSON serialization of global strings.
src/native/managed/cdacreader/tests/ContractDescriptor/ContractDescriptorBuilder.cs	Extended builder API to include global strings.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs	Integrated global strings into target reading.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader/ContractDescriptorParser.cs	Added global strings support in JSON serialization and diagnostics.
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Target.cs	Defined abstract TryReadGlobalString method.
src/coreclr/tools/cdac-build-tool/data-descriptor-blob.md	Updated blob specification to include GlobalStringSpec.
src/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs	Modified header reading and parsing logic to handle global string specs.
src/coreclr/tools/cdac-build-tool/DataDescriptorModel.cs	Extended descriptor model to incorporate global strings.

Files not reviewed (4)

src/coreclr/debug/runtimeinfo/datadescriptor.cpp: Language not supported
src/coreclr/debug/runtimeinfo/datadescriptor.h: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.blob.c: Language not supported
src/coreclr/tools/cdac-build-tool/sample/sample.data.h: Language not supported

dotnet-policy-service · 2025-03-31T21:36:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

davmason · 2025-04-02T19:33:20Z

+ return new GlobalDescriptor { NumericValue = valueCase1, Kind = GlobalDescriptor.KindEnum.Direct };
+ // Case 2: string
+ if (TryGetStringFromToken(ref reader, out string valueCase2))
+ return new GlobalDescriptor { StringValue = valueCase2, Kind = GlobalDescriptor.KindEnum.String };


I don't like the algorithm of "try a number, if it fails it is a string." Since we own the spec we should be able to do better. Is there a reason we have to have the implicit string type and can't just use the explicit one?

You mean the type of the json node or the optional string representing the type of the value?

I meant the optional string, could we have a string by itself be a number and only treat it as a string if we add the optional type

max-charlamb · 2025-04-03T20:51:05Z

Closing as this content was combined in #113899

CopilotAI review requested due to automatic review settings March 31, 2025 21:36

ghost added the area-Diagnostics-coreclr label Mar 31, 2025

max-charlamb requested review from a team and davidwrighton March 31, 2025 21:36

dotnet-policy-serviceBot assigned max-charlamb Mar 31, 2025

CopilotAI reviewed Mar 31, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs Outdated

kg mentioned this pull request Apr 3, 2025
SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241
Closed

This was referenced Apr 1, 2025
[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402
Open
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
Test failure with message "MONO_WASM: Out of memory" on string constructor #113474
Closed

max-charlamb mentioned this pull request Apr 1, 2025
[cDAC] Adds DAC like entrypoint with new COM interface #113899
Merged

This was referenced Apr 2, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.Net.Requests test timeout #113883
Closed

max-charlamb force-pushed the cdac-strings branch from 7eef3b3 to c25c6b1Compare April 2, 2025 16:58

davmason reviewed Apr 2, 2025
View reviewed changes

This was referenced Apr 2, 2025
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.WebSockets.Client.Tests timeout #114153
Closed

Max Charlamb added 2 commits April 3, 2025 15:35

implement runtime/cdac-built-tool portion of passing strings
feaa548

implement cdacreader portion of passing strings
799e5d4

max-charlamb force-pushed the cdac-strings branch from c25c6b1 to 799e5d4Compare April 3, 2025 19:35

max-charlamb closed this Apr 3, 2025

This was referenced Apr 3, 2025
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
Unable to checkout dotnet/dnceng#4115
Open

github-actionsBot locked and limited conversation to collaborators May 4, 2025

max-charlamb deleted the cdac-strings branch August 20, 2025 13:43

CopilotAI review requested due to automatic review settings March 31, 2025 21:36

ghost added the area-Diagnostics-coreclr label Mar 31, 2025

max-charlamb requested review from a team and davidwrighton March 31, 2025 21:36

dotnet-policy-serviceBot assigned max-charlamb Mar 31, 2025

CopilotAI reviewed Mar 31, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs Outdated

kg mentioned this pull request Apr 3, 2025
SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241
Closed

This was referenced Apr 1, 2025
[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402
Open
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
Test failure with message "MONO_WASM: Out of memory" on string constructor #113474
Closed

max-charlamb mentioned this pull request Apr 1, 2025
[cDAC] Adds DAC like entrypoint with new COM interface #113899
Merged

This was referenced Apr 2, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.Net.Requests test timeout #113883
Closed

max-charlamb force-pushed the cdac-strings branch from 7eef3b3 to c25c6b1Compare April 2, 2025 16:58

davmason reviewed Apr 2, 2025
View reviewed changes

This was referenced Apr 2, 2025
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.WebSockets.Client.Tests timeout #114153
Closed

Max Charlamb added 2 commits April 3, 2025 15:35

implement runtime/cdac-built-tool portion of passing strings
feaa548

implement cdacreader portion of passing strings
799e5d4

max-charlamb force-pushed the cdac-strings branch from c25c6b1 to 799e5d4Compare April 3, 2025 19:35

max-charlamb closed this Apr 3, 2025

This was referenced Apr 3, 2025
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
Unable to checkout dotnet/dnceng#4115
Open

github-actionsBot locked and limited conversation to collaborators May 4, 2025

max-charlamb deleted the cdac-strings branch August 20, 2025 13:43

CopilotAI review requested due to automatic review settings March 31, 2025 21:36

ghost added the area-Diagnostics-coreclr label Mar 31, 2025

max-charlamb requested review from a team and davidwrighton March 31, 2025 21:36

dotnet-policy-serviceBot assigned max-charlamb Mar 31, 2025

CopilotAI reviewed Mar 31, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs Outdated

kg mentioned this pull request Apr 3, 2025
SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241
Closed

This was referenced Apr 1, 2025
[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402
Open
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
Test failure with message "MONO_WASM: Out of memory" on string constructor #113474
Closed

max-charlamb mentioned this pull request Apr 1, 2025
[cDAC] Adds DAC like entrypoint with new COM interface #113899
Merged

This was referenced Apr 2, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.Net.Requests test timeout #113883
Closed

max-charlamb force-pushed the cdac-strings branch from 7eef3b3 to c25c6b1Compare April 2, 2025 16:58

davmason reviewed Apr 2, 2025
View reviewed changes

This was referenced Apr 2, 2025
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.WebSockets.Client.Tests timeout #114153
Closed

Max Charlamb added 2 commits April 3, 2025 15:35

implement runtime/cdac-built-tool portion of passing strings
feaa548

implement cdacreader portion of passing strings
799e5d4

max-charlamb force-pushed the cdac-strings branch from c25c6b1 to 799e5d4Compare April 3, 2025 19:35

max-charlamb closed this Apr 3, 2025

This was referenced Apr 3, 2025
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
Unable to checkout dotnet/dnceng#4115
Open

github-actionsBot locked and limited conversation to collaborators May 4, 2025

max-charlamb deleted the cdac-strings branch August 20, 2025 13:43

CopilotAI review requested due to automatic review settings March 31, 2025 21:36

ghost added the area-Diagnostics-coreclr label Mar 31, 2025

max-charlamb requested review from a team and davidwrighton March 31, 2025 21:36

dotnet-policy-serviceBot assigned max-charlamb Mar 31, 2025

CopilotAI reviewed Mar 31, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs Outdated

kg mentioned this pull request Apr 3, 2025
SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241
Closed

This was referenced Apr 1, 2025
[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402
Open
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
Test failure with message "MONO_WASM: Out of memory" on string constructor #113474
Closed

max-charlamb mentioned this pull request Apr 1, 2025
[cDAC] Adds DAC like entrypoint with new COM interface #113899
Merged

This was referenced Apr 2, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.Net.Requests test timeout #113883
Closed

max-charlamb force-pushed the cdac-strings branch from 7eef3b3 to c25c6b1Compare April 2, 2025 16:58

davmason reviewed Apr 2, 2025
View reviewed changes

This was referenced Apr 2, 2025
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.WebSockets.Client.Tests timeout #114153
Closed

Max Charlamb added 2 commits April 3, 2025 15:35

implement runtime/cdac-built-tool portion of passing strings
feaa548

implement cdacreader portion of passing strings
799e5d4

max-charlamb force-pushed the cdac-strings branch from c25c6b1 to 799e5d4Compare April 3, 2025 19:35

max-charlamb closed this Apr 3, 2025

This was referenced Apr 3, 2025
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
Unable to checkout dotnet/dnceng#4115
Open

github-actionsBot locked and limited conversation to collaborators May 4, 2025

max-charlamb deleted the cdac-strings branch August 20, 2025 13:43

CopilotAI review requested due to automatic review settings March 31, 2025 21:36

ghost added the area-Diagnostics-coreclr label Mar 31, 2025

max-charlamb requested review from a team and davidwrighton March 31, 2025 21:36

dotnet-policy-serviceBot assigned max-charlamb Mar 31, 2025

CopilotAI reviewed Mar 31, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs Outdated

kg mentioned this pull request Apr 3, 2025
SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241
Closed

This was referenced Apr 1, 2025
[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402
Open
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
Test failure with message "MONO_WASM: Out of memory" on string constructor #113474
Closed

max-charlamb mentioned this pull request Apr 1, 2025
[cDAC] Adds DAC like entrypoint with new COM interface #113899
Merged

This was referenced Apr 2, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.Net.Requests test timeout #113883
Closed

max-charlamb force-pushed the cdac-strings branch from 7eef3b3 to c25c6b1Compare April 2, 2025 16:58

davmason reviewed Apr 2, 2025
View reviewed changes

This was referenced Apr 2, 2025
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.WebSockets.Client.Tests timeout #114153
Closed

Max Charlamb added 2 commits April 3, 2025 15:35

implement runtime/cdac-built-tool portion of passing strings
feaa548

implement cdacreader portion of passing strings
799e5d4

max-charlamb force-pushed the cdac-strings branch from c25c6b1 to 799e5d4Compare April 3, 2025 19:35

max-charlamb closed this Apr 3, 2025

This was referenced Apr 3, 2025
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
Unable to checkout dotnet/dnceng#4115
Open

github-actionsBot locked and limited conversation to collaborators May 4, 2025

max-charlamb deleted the cdac-strings branch August 20, 2025 13:43

CopilotAI review requested due to automatic review settings March 31, 2025 21:36

ghost added the area-Diagnostics-coreclr label Mar 31, 2025

max-charlamb requested review from a team and davidwrighton March 31, 2025 21:36

dotnet-policy-serviceBot assigned max-charlamb Mar 31, 2025

CopilotAI reviewed Mar 31, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs Outdated

kg mentioned this pull request Apr 3, 2025
SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241
Closed

This was referenced Apr 1, 2025
[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402
Open
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
Test failure with message "MONO_WASM: Out of memory" on string constructor #113474
Closed

max-charlamb mentioned this pull request Apr 1, 2025
[cDAC] Adds DAC like entrypoint with new COM interface #113899
Merged

This was referenced Apr 2, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.Net.Requests test timeout #113883
Closed

max-charlamb force-pushed the cdac-strings branch from 7eef3b3 to c25c6b1Compare April 2, 2025 16:58

davmason reviewed Apr 2, 2025
View reviewed changes

This was referenced Apr 2, 2025
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.WebSockets.Client.Tests timeout #114153
Closed

Max Charlamb added 2 commits April 3, 2025 15:35

implement runtime/cdac-built-tool portion of passing strings
feaa548

implement cdacreader portion of passing strings
799e5d4

max-charlamb force-pushed the cdac-strings branch from c25c6b1 to 799e5d4Compare April 3, 2025 19:35

max-charlamb closed this Apr 3, 2025

This was referenced Apr 3, 2025
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
Unable to checkout dotnet/dnceng#4115
Open

github-actionsBot locked and limited conversation to collaborators May 4, 2025

max-charlamb deleted the cdac-strings branch August 20, 2025 13:43

CopilotAI review requested due to automatic review settings March 31, 2025 21:36

ghost added the area-Diagnostics-coreclr label Mar 31, 2025

max-charlamb requested review from a team and davidwrighton March 31, 2025 21:36

dotnet-policy-serviceBot assigned max-charlamb Mar 31, 2025

CopilotAI reviewed Mar 31, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/cdac-build-tool/ObjectFileScraper.cs Outdated

kg mentioned this pull request Apr 3, 2025
SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241
Closed

This was referenced Apr 1, 2025
[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402
Open
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
Test failure with message "MONO_WASM: Out of memory" on string constructor #113474
Closed

max-charlamb mentioned this pull request Apr 1, 2025
[cDAC] Adds DAC like entrypoint with new COM interface #113899
Merged

This was referenced Apr 2, 2025
[QUIC & HTTP/3] Handshake Timeout on tests #104426
Closed
System.Net.Quic tests timeout #107761
Closed
System.Net.Requests test timeout #113883
Closed

max-charlamb force-pushed the cdac-strings branch from 7eef3b3 to c25c6b1Compare April 2, 2025 16:58

davmason reviewed Apr 2, 2025
View reviewed changes

This was referenced Apr 2, 2025
System.TimeoutException : The operation has timed out. dotnet/dnceng#5279
Closed
System.Net.WebSockets.Client.Tests timeout #114153
Closed

Max Charlamb added 2 commits April 3, 2025 15:35

implement runtime/cdac-built-tool portion of passing strings
feaa548

implement cdacreader portion of passing strings
799e5d4

max-charlamb force-pushed the cdac-strings branch from c25c6b1 to 799e5d4Compare April 3, 2025 19:35

max-charlamb closed this Apr 3, 2025

This was referenced Apr 3, 2025
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
Unable to checkout dotnet/dnceng#4115
Open

github-actionsBot locked and limited conversation to collaborators May 4, 2025

max-charlamb deleted the cdac-strings branch August 20, 2025 13:43

Uh oh!

Conversation

max-charlamb commented Mar 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Mar 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max-charlamb commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

max-charlamb commented Mar 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Mar 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max-charlamb commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

max-charlamb commented Mar 31, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Mar 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

max-charlamb commented Apr 3, 2025

Uh oh!

Reviewers

max-charlamb commented Mar 31, 2025•
edited
Loading

max-charlamb commented Mar 31, 2025•
edited
Loading

max-charlamb commented Mar 31, 2025•
edited
Loading

max-charlamb commented Mar 31, 2025•
edited
Loading