Make it possible to preinitialize `ComInterfaceEntry` by MichalStrehovsky · Pull Request #114459 · dotnet/runtime

MichalStrehovsky · 2025-04-09T21:14:16Z

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

MichalStrehovsky · 2025-04-09T21:14:16Z

Fixes#114355.

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

MichalStrehovsky · 2025-04-09T21:14:16Z

Fixes#114355.

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

MichalStrehovsky · 2025-04-09T21:14:16Z

Fixes#114355.

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

MichalStrehovsky · 2025-04-09T21:14:16Z

Fixes#114355.

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

MichalStrehovsky · 2025-04-09T21:14:16Z

Fixes#114355.

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

MichalStrehovsky · 2025-04-09T21:14:16Z

Fixes#114355.

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

MichalStrehovsky · 2025-04-09T21:14:16Z

Fixes#114355.

Special case ComWrappers.ComInterfaceEntry and types that only consist of these fields to achieve this.

Cc @dotnet/ilc-contrib @Sergio0694

Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

Copilot

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2705

In the Clone method of VTableLikeStructValue (line 2705), passing null for fieldThatOwnsMemory may cause loss of necessary context. Consider preserving the existing fieldThatOwnsMemory if applicable.

return new VTableLikeStructValue(_type, (MethodDesc[])_methods.Clone(), fieldThatOwnsMemory: null);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2727

The MemoryOwner property in VTableLikeSlotReferenceValue returns a non-null value only when _index is 0. Verify that this behavior is intentional for all indices.

public override FieldDesc MemoryOwner => _index == 0 ? _fieldThatOwnsMemory : null;

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs:2491

In the IsCompatible method of ComInterfaceEntryArrayValue, entryType is overwritten for each non-static field without verifying that all fields share the same ComInterfaceEntry type. Consider adding an explicit check to ensure consistency across all instance fields.

foreach (FieldDesc field in type.GetFields()) { ... entryType = field.FieldType; ... }

dotnet-policy-service · 2025-04-09T21:15:00Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Sergio0694 · 2025-04-10T06:29:55Z

Looks great!! Example use in CsWinRT 3.0 (assuming #114455 too), for reference: here 🙂

Make it possible to preinitialize ComInterfaceEntry
aeb1dca
Fixesdotnet#114355. Special case `ComWrappers.ComInterfaceEntry` and types that only consist of these fields to achieve this.

CopilotAI review requested due to automatic review settings April 9, 2025 21:14

ghost added the area-NativeAOT-coreclr label Apr 9, 2025

dotnet-policy-serviceBot assigned MichalStrehovsky Apr 9, 2025

CopilotAI reviewed Apr 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Apr 10, 2025
CI flakiness: mono interpreter build getting killed #114123
Open

noahfalk mentioned this pull request Apr 10, 2025
Make lttng-ust an optional dependency. #113876
Merged

jkotas reviewed Apr 12, 2025
View reviewed changes

Comment threadsrc/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs
Comment threadsrc/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs Outdated
Comment threadsrc/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs Outdated

MichalStrehovsky added 3 commits April 14, 2025 08:15

FB
4a5743b

Merge branch 'main' into fix114355
e47dcf0

Fallout
bcfc543

jkotas approved these changes Apr 21, 2025
View reviewed changes

MichalStrehovsky merged commit d9c4c3e into dotnet:mainApr 21, 2025

MichalStrehovsky deleted the fix114355 branch April 21, 2025 09:32

github-actionsBot locked and limited conversation to collaborators May 22, 2025