Uh oh!
There was an error while loading. Please reload this page.
Add internal intrinsics for instance-based calli - #114495
Conversation
Tagging subscribers to this area: @dotnet/area-system-reflection-emit |
There was a problem hiding this comment.
Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.
Files not reviewed (2)
- src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Language not supported
- src/coreclr/tools/aot/ILCompiler.ReadyToRun/ILCompiler.ReadyToRun.csproj: Language not supported
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Wouldn't it be simpler to just write those stubs in IL instead of having to implement them in every VM? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jkotas
commented
Apr 11, 2025
We would need to invent build infrastructure to merge this IL into CoreLib.... |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
steveharter
commented
Apr 16, 2025
/ba-g infra timeout on building Libraries Test Run release coreclr linux_musl x64 Debug |
Contributes to #112994. The next step in this process will use these intrinsics.
Adds support for both CoreClr JIT and R2R to modify the function pointer signature to add HasThis | ExplicitThis so specific function pointer signatures can be called on an instance method.
Local testing verified both:
The tests added here currently don't verify the intrinsics, but an earlier version did (see the first commit). Once the next step of hooking into reflection is done, these tests will cover the new intrinsics added here. In particular, the new tests address missing test cases of calling an instance-based method with non-primitive return types such as
Guid,DateTimeandTimeSpanthat would fail if reflection called these methods with function pointers \ Calli without HasThis | ExplicitThis.