Uh oh!
There was an error while loading. Please reload this page.
Support W3C Propagator - #114583
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj: Language not supported
- src/libraries/System.Diagnostics.DiagnosticSource/tests/System.Diagnostics.DiagnosticSource.Tests.csproj: Language not supported
Uh oh!
There was an error while loading. Please reload this page.
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
tarekgh
commented
Apr 12, 2025
@MihaZupan@antonfirsov we are changing the default propagator to use the new W3C one instead of the legacy one. Looks like many http/socket tests are failing because of that. Could you please help by looking at the failed tests and fix these? The new W3C propagator is not supporting If want to continue testing hierarchical activity ids, you can consider reset the current propagator to the legacy one. We haven't exposed API to return that yet, but the test can use reflection if want to. Let me know and I can help. |
tarekgh
commented
Apr 14, 2025
CC @JamesNK for awareness. |
noahfalk
left a comment
There was a problem hiding this comment.
A couple suggestions inline but other than that LGTM!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JamesNK
commented
Apr 14, 2025
Does ASP.NET Core need to do anything to read headers added to requests? Or does it already work? |
tarekgh
commented
Apr 14, 2025
aspnet core support both header names |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contribute to #103174
DistributedContextPropagator.CurrentandDistributedContextPropagator.CreateDefaultPropagator()now will have the W3C Propagator as the default propagator.DistributedContextPropagator.CreateLegacyPropagator()to allow user to opt-in to the legacy propagator.