Skip to content

Fix CA2256 in COM generator when using 'ManagedObjectWrapper' - #114642

Merged
jkoritzinsky merged 2 commits into
dotnet:mainfrom
Sergio0694:user/sergiopedri/fix-90922
Apr 15, 2025
Merged

Fix CA2256 in COM generator when using 'ManagedObjectWrapper'#114642
jkoritzinsky merged 2 commits into
dotnet:mainfrom
Sergio0694:user/sergiopedri/fix-90922

Conversation

@Sergio0694

@Sergio0694Sergio0694 commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Closes#90922

This PR updates the COM generator to not produce a warning when using ManagedObjectWrapper.

@Sergio0694
Sergio0694 requested review from Copilot and jkoritzinsky and removed request for CopilotApril 14, 2025 17:54
CopilotAI reviewed Apr 14, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Sergio0694Sergio0694 added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature and removed area-Interop-coreclr labels Apr 14, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Apr 14, 2025
@AaronRobinsonMSFTAaronRobinsonMSFT added this to the 10.0.0 milestone Apr 14, 2025
This was referenced Apr 14, 2025
Open
Closed
Closed
Closed
Closed
@Sergio0694
Sergio0694force-pushed the user/sergiopedri/fix-90922 branch from 9df77c3 to 699dc50CompareApril 14, 2025 23:55
@Sergio0694
Sergio0694force-pushed the user/sergiopedri/fix-90922 branch from 699dc50 to dee988eCompareApril 15, 2025 06:18
@build-analysisbuild-analysisBot mentioned this pull request Apr 15, 2025
Open
@jkoritzinsky
jkoritzinsky merged commit 0bf77b2 into dotnet:mainApr 15, 2025
@Sergio0694
Sergio0694 deleted the user/sergiopedri/fix-90922 branch April 15, 2025 22:55
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

No one assigned

Labels

area-System.Runtime.InteropServicescommunity-contributionIndicates that the PR has been added by a community membersource-generatorIndicates an issue with a source generator feature

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

[GeneratedComInterface] in CCW-only mode produces CA2256 warning

5 participants

@Sergio0694@jkoritzinsky@MichalStrehovsky@AaronRobinsonMSFT