Skip to content

Revert 114347 + MSBuild tasks leak workaround + HotReload workaround - #114643

Merged
pavelsavara merged 5 commits into
mainfrom
revert-114347-disable-failing-pipeline
Apr 15, 2025
Merged

Revert 114347 + MSBuild tasks leak workaround + HotReload workaround#114643
pavelsavara merged 5 commits into
mainfrom
revert-114347-disable-failing-pipeline

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Apr 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Apr 14, 2025
@pavelsavarapavelsavara added this to the 10.0.0 milestone Apr 14, 2025
@pavelsavarapavelsavara self-assigned this Apr 14, 2025
@pavelsavara
pavelsavara requested a review from lewingApril 14, 2025 18:04
@pavelsavarapavelsavara changed the title Revert "[wasm] Disable wasm linux library tests which are failing due to infrastructure"Revert 114347 + MSBuild tasks leak workaround + HotReload workaroundApr 14, 2025
@pavelsavarapavelsavara mentioned this pull request Apr 14, 2025
Closed
@pavelsavara
pavelsavara marked this pull request as ready for review April 14, 2025 18:09
CopilotAI review requested due to automatic review settings April 14, 2025 18:09
CopilotAI reviewed Apr 14, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • src/libraries/System.Runtime.Loader/tests/System.Runtime.Loader.Tests.csproj: Language not supported
  • src/libraries/tests.proj: Language not supported
  • src/mono/browser/build/WasmApp.InTree.CI.targets: Language not supported
  • src/mono/browser/build/WasmApp.InTree.targets: Language not supported
  • src/tests/FunctionalTests/WebAssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj: Language not supported
  • src/tests/FunctionalTests/WebAssembly/Browser/HotReload/WebAssembly.Browser.HotReload.Test.csproj: Language not supported

This was referenced Apr 14, 2025
Open
Open
Open
Closed
Closed
Open
Closed
Closed
maraf
maraf reviewed Apr 15, 2025
View reviewed changes
Comment thread...ssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj Outdated
Comment thread...ssembly/Browser/HotReload/ApplyUpdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj Outdated
pavelsavaraand others added 2 commits April 15, 2025 10:59
@pavelsavara@maraf
Update src/tests/FunctionalTests/WebAssembly/Browser/HotReload/ApplyU…
90dbe57
…pdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara@maraf
Update src/tests/FunctionalTests/WebAssembly/Browser/HotReload/ApplyU…
25dd6a2
…pdateReferencedAssembly/ApplyUpdateReferencedAssembly.csproj
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara
pavelsavara merged commit c893f68 into mainApr 15, 2025
@build-analysisbuild-analysisBot mentioned this pull request Apr 15, 2025
Open
3 tasks
@akoeplinger
akoeplinger deleted the revert-114347-disable-failing-pipeline branch April 17, 2025 12:16
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@marafmarafmaraf approved these changes
@ilonatommyilonatommyilonatommy approved these changes
@lewinglewingAwaiting requested review from lewing
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@maraf@ilonatommy