Uh oh!
There was an error while loading. Please reload this page.
Use extension everything to polyfill ArgumentNullException.ThrowIfNull - #114644
Merged
Conversation
stephentoub
requested review from
MichalStrehovsky and marek-safar
as code ownersApril 14, 2025 18:01
Contributor
There was a problem hiding this comment.
Copilot reviewed 564 out of 564 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.NativeAot.cs:92
- ArgumentNullException.ThrowIfNull is being applied to an IntPtr (a value type), which will never be null. If the intent is to validate that 'ptr' is not equal to IntPtr.Zero, consider an explicit check for that condition.
ArgumentNullException.ThrowIfNull(ptr);
src/libraries/Common/src/System/ExceptionPolyfills.cs:12
- [nitpick] Consider adding unit tests to verify the behavior of the new polyfill implementation for ThrowIfNull to ensure it correctly handles various argument types.
extension(ArgumentNullException)
Contributor
Tagging subscribers to this area: @dotnet/area-meta |
This was referenced Apr 14, 2025
3 tasks
tannergooding
approved these changes
Apr 15, 2025
This was referenced Apr 15, 2025
3 tasks
stephentoubforce-pushed
the
anepolyfill
branch
4 times, most recently
from
April 18, 2025 01:15
62dc115 to
ae42ea8Compare
This was referenced Apr 18, 2025
stephentoub
commented
Apr 18, 2025
MemberAuthor
/ba-g Failures in ZipArchive (ExtractToDirectoryExtension blocking on monitors on wasm) are known. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @jaredpar, @jcouv, @ericstj