Skip to content

[wasm][interp] Disable PackedSimd operator aliases while we investigate - #114659

Merged
lewing merged 1 commit into
dotnet:mainfrom
lewing:disable-operator-aliases
Apr 15, 2025
Merged

[wasm][interp] Disable PackedSimd operator aliases while we investigate#114659
lewing merged 1 commit into
dotnet:mainfrom
lewing:disable-operator-aliases

Conversation

@lewing

@lewinglewing commented Apr 14, 2025

Copy link
Copy Markdown
Member

There was a perf regression when enabling them and I would like to avoid regressing preview 4 while still having time to investigate more.

CopilotAI review requested due to automatic review settings April 14, 2025 23:05
@lewing
lewing requested review from kg and removed request for kotlarmilosApril 14, 2025 23:05
CopilotAI reviewed Apr 14, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment threadsrc/mono/mono/mini/interp/transform-simd.c
@dotnet-policy-service

dotnet-policy-serviceBot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

@lewing

lewing commented Apr 15, 2025

Copy link
Copy Markdown
MemberAuthor

it is the shift operators because they have a jiterp fastpath that is missed otherwise.

@lewing
lewing merged commit 9cdb28b into dotnet:mainApr 15, 2025
@lewing
lewing deleted the disable-operator-aliases branch April 15, 2025 02:28
This was referenced Apr 15, 2025
Open
Open
Closed
@lewinglewing mentioned this pull request Apr 15, 2025
Merged
@lewing

lewing commented Apr 15, 2025

Copy link
Copy Markdown
MemberAuthor

Proper fix plus some extras in #114669 but will let a few benchmark runs go by before we merge that.

This was referenced Apr 23, 2025
Open
Closed
@lewinglewing mentioned this pull request May 8, 2025
Open
12 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas is a code owner
@kgkgAwaiting requested review from kg

Assignees

@lewinglewing

Labels

area-Codegen-Interpreter-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lewing@steveisok