Ordered evaluation in FileSystemGlobbing Matcher

[kasperk81]

Recommend review with whitespace diffs off because converting ordered/unordered helpers to local functions caused indentation changes.

Resolve#109408

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[kasperk81]

@jeffhandley@ericstj@jozkee please take a look at this approved API implementation so it doesn't miss the .NET 10 release.

[Copilot]

Pull Request Overview

This PR adds support for ordered filter evaluation in the FileSystemGlobbing matcher by introducing a flag, updating the matching logic, and expanding tests accordingly.

• Introduce preserveFilterOrder flag and overloads in Matcher
• Implement ordered traversal in MatcherContext via MatchOrdered
• Update existing tests to pass an IsOrdered flag and add OrderedPatternMatchingTests

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
FileSystemGlobbingTestContext.cs	Constructor now takes isOrdered and creates matcher accordingly
PatternMatchingTests.cs	Updated to use IsOrdered instead of injecting a Matcher
OrderedPatternMatchingTests.cs	New test class exercising ordered filter behavior
Matcher.cs	Added preserveFilterOrder flag and switched execution paths
MatcherContext.cs	Extended to support ordered matching with local functions
InMemoryDirectoryInfo.cs	Modernized collection initialization to use new array syntax
Microsoft.Extensions.FileSystemGlobbing.csproj	Added System.ValueTuple package reference for .NET Framework

Comments suppressed due to low confidence (1)

src/libraries/Microsoft.Extensions.FileSystemGlobbing/tests/PatternMatchingTests.cs:12

• [nitpick] Fields in C# tests typically use camelCase or are declared as properties. Consider renaming IsOrdered to _isOrdered or exposing it as a protected property protected bool IsOrdered { get; set; } to follow naming conventions.

protected bool IsOrdered = false;

[kasperk81]

@PranavSenthilnathan feel free to take over and adjust this as you see fit. The PR is functionally complete, and I addressed all your feedback a month ago but now you're requesting a complete overhaul?

@jkotas could I get an authoritative review here? I'd like to avoid going back and forth with shifting feedback.

[jkotas]

@jkotas could I get an authoritative review here? I'd like to avoid going back and forth with shifting feedback.

You have the right people CCed here. I am not the right person to ask for an authoritative review on this one. https://github.com/dotnet/runtime/blob/main/docs/area-owners.md has the list of folks and aliases to tag for each area.

[PranavSenthilnathan]

Not sure why pushing to kasperk81:main automatically closed this PR... I'll create a new PR with the changes I tried to push.