Skip to content

Don't pass -os twice for windows in DotNetBuild.props - #114732

Merged
ViktorHofer merged 1 commit into
mainfrom
akoeplinger-patch-2
Apr 16, 2025
Merged

Don't pass -os twice for windows in DotNetBuild.props#114732
ViktorHofer merged 1 commit into
mainfrom
akoeplinger-patch-2

Conversation

@akoeplinger

@akoeplingerakoeplinger commented Apr 16, 2025

Copy link
Copy Markdown
Member

Fixes this error in dotnet/sdk#48477:

D:\a\_work\1\vmr\src\runtime\eng\build.ps1 : Cannot bind parameter because parameter 'os' is specified more than once.

CopilotAI reviewed Apr 16, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/DotNetBuild.props: Language not supported

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 16, 2025
@ViktorHofer

ViktorHofer commented Apr 16, 2025

Copy link
Copy Markdown
Member

/ba-g failures unrelated. This file isn't exercised in CI.

@ViktorHofer
ViktorHofer merged commit d4628a6 into mainApr 16, 2025
@ViktorHofer
ViktorHofer deleted the akoeplinger-patch-2 branch April 16, 2025 11:56
This was referenced Apr 16, 2025
Open
Open
Closed
Open
Closed
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@akoeplingerakoeplinger

Labels

needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akoeplinger@ViktorHofer