Skip to content

Disable the UTFStringConversionFailures test on CI runs - #114747

Merged
jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:skip-large-string-ci
Apr 17, 2025
Merged

Disable the UTFStringConversionFailures test on CI runs#114747
jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:skip-large-string-ci

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Disable the UTFStringConversionFailures test on CI runs as our Helix machines can't handle the load from allocating 2 2GB strings and the OOM killer was killing the process.

Fixes#114241

…machines can't handle the load from allocating 2 2GB strings and the OOM killer was killing the process.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionMarshallingFails.cs:113

  • Disabling the test reduces CI coverage; please ensure that issue #114241 tracks plans for addressing this or running the test in a memory-optimized environment.
[SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")]

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

{
[Fact]
[SkipOnCI("Allocates enough memory that the OOM killer can kill the process on our Helix machines.")]
public void UTFStringConversionFailures()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to name this as something specific to conversion failures due to the long string?

@jkoritzinsky

Copy link
Copy Markdown
MemberAuthor

/ba-g wasm failures unrelated

@jkoritzinsky
jkoritzinsky merged commit ce3c9df into dotnet:mainApr 17, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 17, 2025
@dotnetdotnet unlocked this conversation Jun 10, 2025
@jkoritzinsky

Copy link
Copy Markdown
MemberAuthor

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15550434935

@agocke

Copy link
Copy Markdown
Member

/backport to release/8.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/16183337745

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts

5 participants

@jkoritzinsky@agocke@AaronRobinsonMSFT@elinor-fung