Skip to content

[release/9.0-staging] Add support for more libicu versions - #115376

Merged
NikolaMilosavljevic merged 1 commit into
dotnet:release/9.0-stagingfrom
NikolaMilosavljevic:deb.libicu.9
May 8, 2025
Merged

[release/9.0-staging] Add support for more libicu versions#115376
NikolaMilosavljevic merged 1 commit into
dotnet:release/9.0-stagingfrom
NikolaMilosavljevic:deb.libicu.9

Conversation

@NikolaMilosavljevic

Copy link
Copy Markdown
Contributor

Fixes: #115274

Debian Trixie package repository was updated to include just libicu76. We require libicu72.

Besides version 76, this PR also adds versions 77 and 78, to limit the need to change this file often.

CopilotAI review requested due to automatic review settings May 7, 2025 18:57

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for additional libicu versions to accommodate updates in the Debian Trixie repository while preserving compatibility with the required libicu72.

  • Added versions 78, 77, and 76 to the KnownLibIcuVersion list
  • Adjusted the dependency list in dotnet-runtime-deps-debian.proj to reflect these new versions

@NikolaMilosavljevicNikolaMilosavljevic added the Servicing-consider Issue for next servicing release review label May 7, 2025
@NikolaMilosavljevicNikolaMilosavljevic changed the title Add support for more libicu versions[release/9.0-staging] Add support for more libicu versionsMay 7, 2025
@jozkee

Copy link
Copy Markdown
Member

@NikolaMilosavljevic friendly reminder that code complete is on Monday May 12th (2:00 PM Pacific) for the June Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that.

@NikolaMilosavljevic

Copy link
Copy Markdown
ContributorAuthor

This was approved for servicing - updating the label.

@NikolaMilosavljevicNikolaMilosavljevic added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 8, 2025
@NikolaMilosavljevic
NikolaMilosavljevic merged commit 7a98cb9 into dotnet:release/9.0-stagingMay 8, 2025
@NikolaMilosavljevicNikolaMilosavljevic added this to the 9.0.x milestone May 8, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Servicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@NikolaMilosavljevic@jozkee@jkoritzinsky