') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Remove dead code for parsing/emitting X86 instructions by filipnavara · Pull Request #116292 · dotnet/runtime · GitHub
Skip to content

Remove dead code for parsing/emitting X86 instructions - #116292

Merged
jkotas merged 11 commits into
dotnet:mainfrom
filipnavara:x86-dead-code
Jun 6, 2025
Merged

Remove dead code for parsing/emitting X86 instructions#116292
jkotas merged 11 commits into
dotnet:mainfrom
filipnavara:x86-dead-code

Conversation

@filipnavara

@filipnavarafilipnavara commented Jun 4, 2025

Copy link
Copy Markdown
Member

No description provided.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jun 4, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan

huoyaoyuan commented Jun 4, 2025

Copy link
Copy Markdown
Member

There are a bit more dead patterns: #103533 (comment)

A little portion of dead code accessing ESP+offset is not removed in stublinkerx86.

Can we figure out what are alive now?

@filipnavara

filipnavara commented Jun 4, 2025

Copy link
Copy Markdown
MemberAuthor

I removed bulk of the code in #115339 and now I checked every remaining method if it's used or not.

@filipnavara

filipnavara commented Jun 4, 2025

Copy link
Copy Markdown
MemberAuthor

On second look I found more things to remove. We can likely remove the single usage of X86EmitNearJump too and that will make another big chunk go away.

@filipnavara
filipnavara requested a review from jkotasJune 5, 2025 06:19
jkotas
jkotas reviewed Jun 5, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/i386/stublinkerx86.cpp Outdated
jkotas
jkotas reviewed Jun 5, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/i386/stublinkerx86.h
jkotas
jkotas reviewed Jun 5, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/i386/stublinkerx86.h Outdated
jkotas
jkotas approved these changes Jun 6, 2025
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
jkotas merged commit 259204a into dotnet:mainJun 6, 2025
@filipnavara
filipnavara deleted the x86-dead-code branch June 6, 2025 06:38
@build-analysisbuild-analysisBot mentioned this pull request Jun 6, 2025
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes

Assignees

No one assigned

Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filipnavara@huoyaoyuan@jkotas