Skip to content

[wasm][coreclr] Get further in the runtime initialization - #116383

Merged
radekdoulik merged 75 commits into
dotnet:mainfrom
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged

[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom
radekdoulik:wasm-coreclr-wip-3-squashed

Conversation

@radekdoulik

@radekdoulikradekdoulik commented Jun 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Add corewasmhost binary to test runtime initialization

Fix linking of the host binary with coreclr and interpreter

Allow calling interpreter with arguments and handle return value

Use fake precode stubs to pass the precode type and method desc

Make alternate signal stack calls no-op on wasm

Implement CallDescrWorkerInternal on wasm

Use flat PE image loading on wasm

Do not use unsupported syscalls

@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed the wasm-coreclr-wip-3-squashed branch from c49f135 to b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik added this to the Future milestone Jun 6, 2025
am11
am11 reviewed Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp Outdated
@am11am11 added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
This was referenced Jun 9, 2025
Open
Open
Open
Open
am11
am11 reviewed Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11 reviewed Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot mentioned this pull request Jun 10, 2025
Closed
jkotas
jkotas reviewed Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c Outdated
Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp Outdated
janvorli
janvorli reviewed Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake Outdated
janvorli
janvorli reviewed Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h Outdated
This was referenced Jul 18, 2025
Closed
Open
@build-analysisbuild-analysisBot mentioned this pull request Jul 18, 2025
Closed
jkotas
jkotas approved these changes Jul 21, 2025
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment threadsrc/coreclr/pal/src/thread/process.cpp Outdated
Comment threadsrc/coreclr/clrdefinitions.cmake Outdated
Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt Outdated
Comment threadsrc/coreclr/pal/src/exception/signal.cpp Outdated
Comment threadsrc/coreclr/pal/src/init/pal.cpp Outdated
Comment threadsrc/coreclr/pal/src/init/pal.cpp Outdated
Comment threadsrc/coreclr/pal/src/loader/module.cpp Outdated
Comment threadsrc/coreclr/pal/src/map/virtual.cpp Outdated
@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik mentioned this pull request Jul 23, 2025
Closed
radekdoulikand others added 8 commits July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas reviewed Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp Outdated
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp Outdated
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp Outdated
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp Outdated
Comment threadsrc/coreclr/pal/src/thread/process.cpp Outdated
Comment threadsrc/coreclr/pal/src/thread/process.cpp Outdated
@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik requested a review from kgJuly 23, 2025 14:40
kg
kg approved these changes Jul 23, 2025
View reviewed changes

@kgkg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes

@radekdoulik
radekdoulik enabled auto-merge (squash) July 23, 2025 16:44
This was referenced Jul 23, 2025
Closed
Open
Open
Closed
@radekdoulik

radekdoulik commented Jul 24, 2025

Copy link
Copy Markdown
MemberAuthor

/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591

@radekdoulik
radekdoulik merged commit 3c94a47 into dotnet:mainJul 24, 2025
152 of 162 checks passed
am11
am11 reviewed Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
+3 more reviewers
@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[wasm][coreclr] Get further in the runtime initialization by radekdoulik · Pull Request #116383 · dotnet/runtime · GitHub
Skip to content
[wasm][coreclr] Get further in the runtime initialization - #116383
Merged
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged
[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Conversation
@radekdoulik
@radekdoulikradekdoulik
commented
Jun 6, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls
@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed
the
wasm-coreclr-wip-3-squashed
branch
from
c49f135 to
b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik
added this to the Future milestone
Jun 6, 2025
am11
am11
reviewed
Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

@am11am11
added

arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

This was referenced Jun 9, 2025

Open


Open


Open


Open

am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 10, 2025

Closed

jkotas
jkotas
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c
Outdated

Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h
Outdated


This was referenced Jul 18, 2025

Closed


Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2025

Closed

jkotas
jkotas
approved these changes
Jul 21, 2025
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise
Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt
Outdated

Comment threadsrc/coreclr/pal/src/exception/signal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/loader/module.cpp
Outdated

Comment threadsrc/coreclr/pal/src/map/virtual.cpp
Outdated

@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik
mentioned this pull request
Jul 23, 2025

Closed

radekdoulikand others
added 8 commits
July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas
reviewed
Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik
requested a review
from kgJuly 23, 2025 14:40
kg
kg
approved these changes
Jul 23, 2025
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes
@radekdoulik
radekdoulik
enabled auto-merge (squash)
July 23, 2025 16:44

This was referenced Jul 23, 2025

Closed


Open


Open


Closed

@radekdoulik
radekdoulik
commented
Jul 24, 2025

Copy link


Copy Markdown

MemberAuthor
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591
@radekdoulik
radekdoulik
merged commit 3c94a47
into
dotnet:mainJul 24, 2025

152 of 162 checks passed

am11
am11
reviewed
Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner

+3 more reviewers

@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm][coreclr] Get further in the runtime initialization by radekdoulik · Pull Request #116383 · dotnet/runtime · GitHub
Skip to content
[wasm][coreclr] Get further in the runtime initialization - #116383
Merged
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged
[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Conversation
@radekdoulik
@radekdoulikradekdoulik
commented
Jun 6, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls
@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed
the
wasm-coreclr-wip-3-squashed
branch
from
c49f135 to
b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik
added this to the Future milestone
Jun 6, 2025
am11
am11
reviewed
Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

@am11am11
added

arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

This was referenced Jun 9, 2025

Open


Open


Open


Open

am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 10, 2025

Closed

jkotas
jkotas
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c
Outdated

Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h
Outdated


This was referenced Jul 18, 2025

Closed


Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2025

Closed

jkotas
jkotas
approved these changes
Jul 21, 2025
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise
Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt
Outdated

Comment threadsrc/coreclr/pal/src/exception/signal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/loader/module.cpp
Outdated

Comment threadsrc/coreclr/pal/src/map/virtual.cpp
Outdated

@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik
mentioned this pull request
Jul 23, 2025

Closed

radekdoulikand others
added 8 commits
July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas
reviewed
Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik
requested a review
from kgJuly 23, 2025 14:40
kg
kg
approved these changes
Jul 23, 2025
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes
@radekdoulik
radekdoulik
enabled auto-merge (squash)
July 23, 2025 16:44

This was referenced Jul 23, 2025

Closed


Open


Open


Closed

@radekdoulik
radekdoulik
commented
Jul 24, 2025

Copy link


Copy Markdown

MemberAuthor
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591
@radekdoulik
radekdoulik
merged commit 3c94a47
into
dotnet:mainJul 24, 2025

152 of 162 checks passed

am11
am11
reviewed
Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner

+3 more reviewers

@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm][coreclr] Get further in the runtime initialization by radekdoulik · Pull Request #116383 · dotnet/runtime · GitHub
Skip to content
[wasm][coreclr] Get further in the runtime initialization - #116383
Merged
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged
[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Conversation
@radekdoulik
@radekdoulikradekdoulik
commented
Jun 6, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls
@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed
the
wasm-coreclr-wip-3-squashed
branch
from
c49f135 to
b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik
added this to the Future milestone
Jun 6, 2025
am11
am11
reviewed
Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

@am11am11
added

arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

This was referenced Jun 9, 2025

Open


Open


Open


Open

am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 10, 2025

Closed

jkotas
jkotas
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c
Outdated

Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h
Outdated


This was referenced Jul 18, 2025

Closed


Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2025

Closed

jkotas
jkotas
approved these changes
Jul 21, 2025
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise
Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt
Outdated

Comment threadsrc/coreclr/pal/src/exception/signal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/loader/module.cpp
Outdated

Comment threadsrc/coreclr/pal/src/map/virtual.cpp
Outdated

@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik
mentioned this pull request
Jul 23, 2025

Closed

radekdoulikand others
added 8 commits
July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas
reviewed
Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik
requested a review
from kgJuly 23, 2025 14:40
kg
kg
approved these changes
Jul 23, 2025
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes
@radekdoulik
radekdoulik
enabled auto-merge (squash)
July 23, 2025 16:44

This was referenced Jul 23, 2025

Closed


Open


Open


Closed

@radekdoulik
radekdoulik
commented
Jul 24, 2025

Copy link


Copy Markdown

MemberAuthor
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591
@radekdoulik
radekdoulik
merged commit 3c94a47
into
dotnet:mainJul 24, 2025

152 of 162 checks passed

am11
am11
reviewed
Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner

+3 more reviewers

@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[wasm][coreclr] Get further in the runtime initialization by radekdoulik · Pull Request #116383 · dotnet/runtime · GitHub
Skip to content
[wasm][coreclr] Get further in the runtime initialization - #116383
Merged
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged
[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Conversation
@radekdoulik
@radekdoulikradekdoulik
commented
Jun 6, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls
@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed
the
wasm-coreclr-wip-3-squashed
branch
from
c49f135 to
b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik
added this to the Future milestone
Jun 6, 2025
am11
am11
reviewed
Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

@am11am11
added

arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

This was referenced Jun 9, 2025

Open


Open


Open


Open

am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 10, 2025

Closed

jkotas
jkotas
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c
Outdated

Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h
Outdated


This was referenced Jul 18, 2025

Closed


Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2025

Closed

jkotas
jkotas
approved these changes
Jul 21, 2025
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise
Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt
Outdated

Comment threadsrc/coreclr/pal/src/exception/signal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/loader/module.cpp
Outdated

Comment threadsrc/coreclr/pal/src/map/virtual.cpp
Outdated

@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik
mentioned this pull request
Jul 23, 2025

Closed

radekdoulikand others
added 8 commits
July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas
reviewed
Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik
requested a review
from kgJuly 23, 2025 14:40
kg
kg
approved these changes
Jul 23, 2025
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes
@radekdoulik
radekdoulik
enabled auto-merge (squash)
July 23, 2025 16:44

This was referenced Jul 23, 2025

Closed


Open


Open


Closed

@radekdoulik
radekdoulik
commented
Jul 24, 2025

Copy link


Copy Markdown

MemberAuthor
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591
@radekdoulik
radekdoulik
merged commit 3c94a47
into
dotnet:mainJul 24, 2025

152 of 162 checks passed

am11
am11
reviewed
Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner

+3 more reviewers

@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm][coreclr] Get further in the runtime initialization by radekdoulik · Pull Request #116383 · dotnet/runtime · GitHub
Skip to content
[wasm][coreclr] Get further in the runtime initialization - #116383
Merged
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged
[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Conversation
@radekdoulik
@radekdoulikradekdoulik
commented
Jun 6, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls
@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed
the
wasm-coreclr-wip-3-squashed
branch
from
c49f135 to
b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik
added this to the Future milestone
Jun 6, 2025
am11
am11
reviewed
Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

@am11am11
added

arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

This was referenced Jun 9, 2025

Open


Open


Open


Open

am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 10, 2025

Closed

jkotas
jkotas
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c
Outdated

Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h
Outdated


This was referenced Jul 18, 2025

Closed


Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2025

Closed

jkotas
jkotas
approved these changes
Jul 21, 2025
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise
Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt
Outdated

Comment threadsrc/coreclr/pal/src/exception/signal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/loader/module.cpp
Outdated

Comment threadsrc/coreclr/pal/src/map/virtual.cpp
Outdated

@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik
mentioned this pull request
Jul 23, 2025

Closed

radekdoulikand others
added 8 commits
July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas
reviewed
Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik
requested a review
from kgJuly 23, 2025 14:40
kg
kg
approved these changes
Jul 23, 2025
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes
@radekdoulik
radekdoulik
enabled auto-merge (squash)
July 23, 2025 16:44

This was referenced Jul 23, 2025

Closed


Open


Open


Closed

@radekdoulik
radekdoulik
commented
Jul 24, 2025

Copy link


Copy Markdown

MemberAuthor
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591
@radekdoulik
radekdoulik
merged commit 3c94a47
into
dotnet:mainJul 24, 2025

152 of 162 checks passed

am11
am11
reviewed
Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner

+3 more reviewers

@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[wasm][coreclr] Get further in the runtime initialization by radekdoulik · Pull Request #116383 · dotnet/runtime · GitHub
Skip to content
[wasm][coreclr] Get further in the runtime initialization - #116383
Merged
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged
[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Conversation
@radekdoulik
@radekdoulikradekdoulik
commented
Jun 6, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls
@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed
the
wasm-coreclr-wip-3-squashed
branch
from
c49f135 to
b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik
added this to the Future milestone
Jun 6, 2025
am11
am11
reviewed
Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

@am11am11
added

arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

This was referenced Jun 9, 2025

Open


Open


Open


Open

am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 10, 2025

Closed

jkotas
jkotas
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c
Outdated

Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h
Outdated


This was referenced Jul 18, 2025

Closed


Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2025

Closed

jkotas
jkotas
approved these changes
Jul 21, 2025
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise
Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt
Outdated

Comment threadsrc/coreclr/pal/src/exception/signal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/loader/module.cpp
Outdated

Comment threadsrc/coreclr/pal/src/map/virtual.cpp
Outdated

@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik
mentioned this pull request
Jul 23, 2025

Closed

radekdoulikand others
added 8 commits
July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas
reviewed
Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik
requested a review
from kgJuly 23, 2025 14:40
kg
kg
approved these changes
Jul 23, 2025
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes
@radekdoulik
radekdoulik
enabled auto-merge (squash)
July 23, 2025 16:44

This was referenced Jul 23, 2025

Closed


Open


Open


Closed

@radekdoulik
radekdoulik
commented
Jul 24, 2025

Copy link


Copy Markdown

MemberAuthor
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591
@radekdoulik
radekdoulik
merged commit 3c94a47
into
dotnet:mainJul 24, 2025

152 of 162 checks passed

am11
am11
reviewed
Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner

+3 more reviewers

@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[wasm][coreclr] Get further in the runtime initialization by radekdoulik · Pull Request #116383 · dotnet/runtime · GitHub
Skip to content
[wasm][coreclr] Get further in the runtime initialization - #116383
Merged
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Jul 24, 2025
Merged
[wasm][coreclr] Get further in the runtime initialization#116383
radekdoulik merged 75 commits into
dotnet:mainfrom 
radekdoulik:wasm-coreclr-wip-3-squashed
Conversation
@radekdoulik
@radekdoulikradekdoulik
commented
Jun 6, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls
@radekdoulik
[wasm][coreclr] Get further in the runtime initialization
b32ad25
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Fix PE image loading without RTR on wasm
Do not use unsupported syscalls
@radekdoulik
radekdoulikforce-pushed
the
wasm-coreclr-wip-3-squashed
branch
from
c49f135 to
b32ad25CompareJune 6, 2025 16:23
@radekdoulikradekdoulik
added this to the Future milestone
Jun 6, 2025
am11
am11
reviewed
Jun 8, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

@am11am11
added

arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Jun 8, 2025
@radekdoulik@am11
Fix condition
790712a
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

This was referenced Jun 9, 2025

Open


Open


Open


Open

am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/calldescrworkerwasm.cpp
am11
am11
reviewed
Jun 9, 2025
View reviewed changes
Comment threadsrc/coreclr/vm/wasm/helpers.cpp
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 10, 2025

Closed

jkotas
jkotas
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/native/minipal/random.c
Outdated

Comment threadsrc/native/libs/System.Globalization.Native/entrypoints.c
Comment threadsrc/coreclr/vm/corhost.cpp
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

janvorli
janvorli
reviewed
Jun 10, 2025
View reviewed changes
Comment threadsrc/coreclr/inc/clrnt.h
Outdated


This was referenced Jul 18, 2025

Closed


Open

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 18, 2025

Closed

jkotas
jkotas
approved these changes
Jul 21, 2025
View reviewed changes
@jkotasjkotas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise
Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/clrdefinitions.cmake
Outdated

Comment threadsrc/coreclr/hosts/corewasmrun/CMakeLists.txt
Outdated

Comment threadsrc/coreclr/pal/src/exception/signal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/init/pal.cpp
Outdated

Comment threadsrc/coreclr/pal/src/loader/module.cpp
Outdated

Comment threadsrc/coreclr/pal/src/map/virtual.cpp
Outdated

@radekdoulik
Feedback
4a2f57a
Make FlushProcessWriteBuffers no-op on wasm
@radekdoulikradekdoulik
mentioned this pull request
Jul 23, 2025

Closed

radekdoulikand others
added 8 commits
July 23, 2025 16:00
@radekdoulik
Feedback
3eae3d7
Fix path
@radekdoulik@jkotas
Fix whitespace
c2ecb47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
a9df639
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Update src/coreclr/pal/src/init/pal.cpp
ca1ce47
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik@jkotas
Prefer TARGET_WASM
17d9952
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
Prefer TARGET_WASM
1e2246f
@radekdoulik
Merge remote-tracking branch 'remotes/origin/main' into wasm-coreclr-…
2ba3bc8
…wip-3-squashed
@radekdoulik
Few more places to use more general TARGET_WASM
52dd3d2
jkotas
jkotas
reviewed
Jul 23, 2025
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

Comment threadsrc/coreclr/pal/src/thread/process.cpp
Outdated

@radekdoulik@jkotas
Prefer TARGET_WASM
4f6f578
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@radekdoulik
radekdoulik
requested a review
from kgJuly 23, 2025 14:40
kg
kg
approved these changes
Jul 23, 2025
View reviewed changes
@kgkg
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my requested changes
@radekdoulik
radekdoulik
enabled auto-merge (squash)
July 23, 2025 16:44

This was referenced Jul 23, 2025

Closed


Open


Open


Closed

@radekdoulik
radekdoulik
commented
Jul 24, 2025

Copy link


Copy Markdown

MemberAuthor
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591
@radekdoulik
radekdoulik
merged commit 3c94a47
into
dotnet:mainJul 24, 2025

152 of 162 checks passed

am11
am11
reviewed
Jul 24, 2025
View reviewed changes
Comment threadsrc/coreclr/pal/inc/pal.h
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 24, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@davidwrightondavidwrightondavidwrighton left review comments
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner

+3 more reviewers

@am11am11am11 left review comments
@SingleAccretionSingleAccretionSingleAccretion left review comments
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-VM-coreclros-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

Future

Development

Successfully merging this pull request may close these issues.

9 participants

@radekdoulik@risc-vv@kg@am11@jkotas@janvorli@davidwrighton@SingleAccretion@pavelsavara