Skip to content

[wasm] Consolidate native build logic for WASM - #116390

Merged
pavelsavara merged 11 commits into
dotnet:mainfrom
SingleAccretion:Wasm-Build-Cleanup
Aug 27, 2025
Merged

[wasm] Consolidate native build logic for WASM#116390
pavelsavara merged 11 commits into
dotnet:mainfrom
SingleAccretion:Wasm-Build-Cleanup

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Jun 6, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Make the Windows and not-Windows logic match.
  2. Remove unnecessary arguments.
  3. Simplify.

Fixes#119100.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jun 6, 2025
@build-analysisbuild-analysisBot mentioned this pull request Jun 6, 2025
Closed
@SingleAccretion
SingleAccretion marked this pull request as ready for review June 7, 2025 11:52
@SingleAccretionSingleAccretion added the arch-wasm WebAssembly architecture label Jun 7, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

This was referenced Jun 25, 2025
Closed
Closed
Closed
Closed
@SingleAccretion
SingleAccretionforce-pushed the Wasm-Build-Cleanup branch 2 times, most recently from 19991f3 to 02d7aeeCompareJune 26, 2025 13:03
@build-analysisbuild-analysisBot mentioned this pull request Jun 26, 2025
Closed
@SingleAccretion
SingleAccretion marked this pull request as draft July 11, 2025 10:19
@dotnet-policy-service

dotnet-policy-serviceBot commented Aug 10, 2025

Copy link
Copy Markdown
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

This was referenced Aug 14, 2025
Closed
Closed
Closed
Open
This was referenced Aug 15, 2025
Open
Closed
@SingleAccretion
SingleAccretion marked this pull request as ready for review August 15, 2025 20:14
@SingleAccretion

SingleAccretion commented Aug 18, 2025

Copy link
Copy Markdown
ContributorAuthor

@dotnet/wasm-eng

@pavelsavara

pavelsavara commented Aug 26, 2025

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 26, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara reviewed Aug 26, 2025
View reviewed changes
Comment threadeng/native/gen-buildsys.cmd
@pavelsavara

pavelsavara commented Aug 26, 2025

Copy link
Copy Markdown
Member

wasi build is broken at the moment, I filled #119100

@SingleAccretion

SingleAccretion commented Aug 26, 2025

Copy link
Copy Markdown
ContributorAuthor

wasi build is broken at the moment, I filled

Yeah, fixing in progress...

@pavelsavarapavelsavara mentioned this pull request Aug 26, 2025
Merged
@SingleAccretion

SingleAccretion commented Aug 26, 2025

Copy link
Copy Markdown
ContributorAuthor

The runtime-wasm failures looked pre-existing (checked against https://dev.azure.com/dnceng-public/public/_build/results?buildId=1130446&view=ms.vss-test-web.build-test-results-tab). With the pushed WASI build fixes we can take another turn.

jkotas
jkotas reviewed Aug 26, 2025
View reviewed changes
Comment threadsrc/native/minipal/descriptorlimit.c
@pavelsavara

pavelsavara commented Aug 26, 2025

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 26, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Aug 26, 2025
Closed
@SingleAccretion

SingleAccretion commented Aug 26, 2025

Copy link
Copy Markdown
ContributorAuthor

The latest run looks clean modulo preexisting failures.

@pavelsavara

pavelsavara commented Aug 27, 2025

Copy link
Copy Markdown
Member

The latest run looks clean modulo preexisting failures.

Yes. There is some issue with runtime config which is probably my fault.
I filled #119136
That should not be blocking this PR

@pavelsavara
pavelsavara merged commit 229aaef into dotnet:mainAug 27, 2025
163 of 169 checks passed
@pavelsavara

pavelsavara commented Aug 27, 2025

Copy link
Copy Markdown
Member

thanks @SingleAccretion !

@pavelsavarapavelsavara self-assigned this Aug 27, 2025
@SingleAccretion
SingleAccretion deleted the Wasm-Build-Cleanup branch August 31, 2025 18:00
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Oct 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@radekdoulikradekdoulikAwaiting requested review from radekdoulik
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@marafmarafAwaiting requested review from maraf

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-Build-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WASI] build is broken

3 participants

@SingleAccretion@pavelsavara@jkotas