Preserve entitlements in managed Mach-O signer by jtschuster · Pull Request #116659 · dotnet/runtime

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster · 2025-06-13T22:32:10Z

Preserves entitlements in the signature when signing with the managed signer. Works on regular apphost and singlefile apphost.

Adds EntitlementsBlob and DerEntitlementsBlob, and updates relevant code to include these blobs.
Adds an EmbeddedSignatureBlob to signing methods to preserve the entitlements from the previous signature.
Precalculates the maximum length required for the new apphost / bundle and allocates an memory-mapped file in memory, copies / modifies the file, then writes out the final length of the file.
Adds tests to ensure the inode of the apphost changes when CreateAppHost / GenerateBundle creates a new apphost/bundle to ensure the MacOS signature cache is dirtied.

…eEntitlementsInMachSigner

dotnet-policy-service · 2025-06-13T22:33:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

…r Manifest lengths

…odesign tests

…serveEntitlementsInMachSigner

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

…eEntitlementsInMachSigner

- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Copilot

Pull Request Overview

This PR introduces changes to preserve entitlements in the managed Mach‑O signer for macOS app hosts. Key changes include adjustments in the native CMake build file to conditionally include entitlements‐based signing; modifications to tests and signing utilities (e.g. Codesign, MachObjectFile, and related blobs) to support new EntitlementsBlob and DerEntitlementsBlob; and updates to the bundle and manifest code to accommodate the extended signature structure.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/native/corehost/apphost/static/CMakeLists.txt	Adds conditional invocation of adhoc_sign_with_entitlements on macOS.
src/installer/tests/*	Updates tests to use theory/member data for signing and rebundling; ensures signature cache clearing.
src/installer/managed/Microsoft.NET.HostModel/MachO/*	Introduces EntitlementsBlob and DerEntitlementsBlob support and updates signature creation logic.
src/installer/managed/Microsoft.NET.HostModel/Bundle/*	Adjusts bundle manifest and size calculations for new signature information.
src/installer/managed/Microsoft.NET.HostModel/AppHost/*	Updates host rewriting and signing routines to integrate Mach‑O signature updates.

Comments suppressed due to low confidence (3)

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:153

The use of arithmetic on enum values (subtracting 1 from CodeDirectorySpecialSlot.DerEntitlements) to determine the array index may be fragile if the enum values are non‐sequential. Consider introducing an explicit mapping from enum values to array indices to improve maintainability.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.DerEntitlements - 1] = hasher.ComputeHash(derStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/CodeDirectoryBlob.cs:161

Similarly, computing the array index by subtracting 1 from CodeDirectorySpecialSlot.Entitlements assumes a contiguous indexing scheme. A mapping structure would make the assignment clearer and more robust against future enum changes.

 specialSlotHashes[(int)CodeDirectorySpecialSlot.Entitlements - 1] = hasher.ComputeHash(entStream.GetBuffer());

src/installer/managed/Microsoft.NET.HostModel/MachO/BinaryFormat/Blobs/EmbeddedSignatureBlob.cs:43

Consider adding an inline comment to clarify the intended blob ordering and how the additional entitlements blobs are factored into the blob count. This will help maintainers understand how changes to the signature structure affect the overall blob layout.

 int blobCount = 3 + (entitlementsBlob is not null ? 1 : 0) + (derEntitlementsBlob is not null ? 1 : 0);

…er for getting inode

agocke

LGTM

…/jtschuster/runtime into PreserveEntitlementsInMachSigner

- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

jtschuster added 3 commits June 13, 2025 12:58

Preserve entitlements when signing mach files
7dc2929

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
f0190e9
…eEntitlementsInMachSigner

Add tests to verify new inodes are created in apphost signing
b705e32

github-actionsBot added the area-HostModel label Jun 13, 2025

dotnet-policy-serviceBot assigned jtschuster Jun 13, 2025

jtschuster added 2 commits June 13, 2025 18:02

Update blob parser and special slot count for new blobs, add tests fo…
e2ead97
…r Manifest lengths

Add tests to compare EmbeddedSignatureBlob data to codesign output
29f6fb8

jtschuster marked this pull request as ready for review June 14, 2025 01:15

CopilotAI review requested due to automatic review settings June 14, 2025 01:15

This comment was marked as outdated.
Sign in to view

jtschuster requested review from agocke and elinor-fung June 14, 2025 01:16

Make test platform specific
839c318

This was referenced Jun 16, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
WASM - Dev certificate error on Windows #116695
Closed

Remove RequirementsSize from CodesignInfo, preserve entitlements in c…
0466408
…odesign tests

build-analysisBot mentioned this pull request Jun 17, 2025
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

Make method public again
9d3c8c2

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
browser-wasm Windows build error #116746
Closed
Python3 not installed / available on wasm windows leg in runtime dotnet/dnceng#5904
Closed

jtschuster added 2 commits June 18, 2025 10:19

Merge branch 'main' ofhttps://github.com/jtschuster/runtimeinto Pre…
df1da52
…serveEntitlementsInMachSigner

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
5a70f55
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

build-analysisBot mentioned this pull request Jun 23, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

elinor-fung reviewed Jun 24, 2025
View reviewed changes

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto Preserv…
d795300
…eEntitlementsInMachSigner

elinor-fung mentioned this pull request Jun 24, 2025
Single file start time regression #116318
Closed

jtschuster added 2 commits June 24, 2025 16:51

Apply suggestions from code review
c1d5d75
- use explicit types for "using" statements - Make CodeDirectoryHeader fields private and expose properties that convert them from bigendian - Reenable codesign hash checks in tests - improve readability

Field -> Property
c668a03

jtschuster requested a review from Copilot June 25, 2025 18:38

CopilotAI reviewed Jun 25, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2025
wasm build failure in CI #117017
Closed

Merge branch 'main' into PreserveEntitlementsInMachSigner
93790cf

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

am11 reviewed Jun 30, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs Outdated

jtschuster added 2 commits June 30, 2025 09:58

Use ReadOnlySpan for header placeholder data
50eb029

Make property internal
b7f05cd

This was referenced Jun 30, 2025
ProcessThreadTests.TestStartTimeProperty failure in CI #105526
Closed
CultureNameGetLoweredByToAssemblyName test failed in CI #117172
Closed

jtschuster requested a review from elinor-fung June 30, 2025 20:36

elinor-fung approved these changes Jul 1, 2025
View reviewed changes

PR Feedback: Rename ReBundle, move tests to HostModel.Tests, use help…
2a33df4
…er for getting inode

agocke approved these changes Jul 1, 2025
View reviewed changes

Comment threadsrc/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs Outdated

jtschuster added 2 commits July 2, 2025 08:35

Merge branch 'PreserveEntitlementsInMachSigner' ofhttps://github.com…
9e2820c
…/jtschuster/runtime into PreserveEntitlementsInMachSigner

PR Feedback:
edaf00b
- Remove ConditionAttribute on test - Use File.SetUnixFileMode

jtschuster enabled auto-merge (squash) July 2, 2025 22:09

jtschuster merged commit b79c4fb into dotnet:mainJul 2, 2025

This was linked to issues Jul 3, 2025
Why it won't work on macOS 15.0 #108390
Closed
Codesigning the apphost on macOS should preserve entitlements #113707
Closed

elinor-fung mentioned this pull request Jul 23, 2025
[main] Source code updates from dotnet/dotnet dotnet/sdk#49740
Merged

baronfel mentioned this pull request Jul 24, 2025
Microsoft.NET.Publish.Tests.PublishItemsOutputGroupOutputsTests.RunPublishItemsOutputGroupOutputsTest fails for single-file win-x86 publishing dotnet/sdk#49926
Closed

github-actionsBot locked and limited conversation to collaborators Aug 2, 2025

Uh oh!

Conversation

jtschuster commented Jun 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Jun 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agocke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jtschuster commented Jun 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Jun 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agocke left a comment

Choose a reason for hiding this comment

jtschuster commented Jun 13, 2025•
edited
Loading

jtschuster commented Jun 13, 2025•
edited
Loading

jtschuster commented Jun 13, 2025•
edited
Loading