Revert back to JsonElement-backed JsonValue for deserialization by PranavSenthilnathan · Pull Request #116774 · dotnet/runtime

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

PranavSenthilnathan · 2025-06-18T01:22:04Z

JsonValueOfElement is more permissive than other classes derived from JsonValue. For example, it allows GetValue<Guid> even when the underlying value's JSON type is a JSON string. The following method has the implementation:

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs

Line 50 in 2dbdff1

publicoverrideboolTryGetValue<TypeToConvert>([NotNullWhen(true)]outTypeToConvertvalue)

#115856 changed deserialization of primitives to use JsonValue.Create instead of the JsonElement-backed creation, so the people relying on the previous behavior of GetValue will now be broken. This was a small part of that PR and only that part has been reverted in this PR.

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Fixes#116730

/cc @eiriktsarpalis @jeffhandley I'm planning to cherry pick this to the release branch as well after merging in main.

Copilot

Pull Request Overview

This PR reverts a recent change to primitive deserialization in JsonValue that broke the permissiveness of JsonValueOfElement when using GetValue. It restores behavior by reverting to the JsonElement-backed creation and updates the associated test harness to accommodate the change.

Revert deserialization of primitives to use JsonElement-backed JsonValue
Update tests to wrap primitive values using a new WrappedT helper type
Adjust JsonValueConverter to revert to the previous parsing logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs	Updated test signatures to use WrappedT and modified the Wrap helper to wrap values in WrappedT
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs	Reverted the primitive value deserialization to use JsonElement-backed JsonValue

dotnet-policy-service · 2025-06-18T01:22:38Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

PranavSenthilnathan · 2025-06-18T01:25:03Z

 yield return Wrap(new TimeOnly(10, 29), JsonValueKind.String);
 #endif
- static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [value, expectedKind];
+ static object[] Wrap<T>(T value, JsonValueKind expectedKind) => [new WrappedT<T> { Value = value }, expectedKind];


XUnit was coercing T? to T for some types (like char? to char) so the tests weren't actually running for those cases. It doesn't do that when using the custom type.

eiriktsarpalis · 2025-06-18T16:44:47Z

In the long term, we can reintroduce this change in a different way: have another class derived from JsonValue that (1) stores the value instead of JsonElement and (2) also allows the same conversions that JsonValueOfElement does. But for now, we revert to get back to baseline.

Any reason why we cannot do this right away? We're not backporting this fix so I think we can afford to do this in a way that both addresses the regression and makes TryGetValue behave consistently regardless of underlying implementation.

jeffhandley · 2025-06-18T17:31:42Z

If we can get the "long term" fix into Preview 7, I'm supportive of taking that fix instead of this one, and still having the regression in Preview 6.

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Revert back to JsonElement-backed JsonValue objects
e708b4b

PranavSenthilnathan added this to the 10.0.0 milestone Jun 18, 2025

PranavSenthilnathan requested a review from eiriktsarpalis June 18, 2025 01:22

PranavSenthilnathan self-assigned this Jun 18, 2025

CopilotAI review requested due to automatic review settings June 18, 2025 01:22

PranavSenthilnathan added the area-System.Text.Json label Jun 18, 2025

CopilotAI reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonNode/JsonValueTests.cs

PranavSenthilnathan commented Jun 18, 2025
View reviewed changes

This was referenced Jun 18, 2025
System.Net.Http.Functional.Tests timeouts #115683
Closed
iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET #116558
Open
browser-wasm Windows build error #116746
Closed

PranavSenthilnathan closed this Jun 18, 2025

github-actionsBot locked and limited conversation to collaborators Jul 19, 2025

Uh oh!

Conversation

PranavSenthilnathan commented Jun 18, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Jun 18, 2025

Uh oh!

PranavSenthilnathanJun 18, 2025

Choose a reason for hiding this comment

Uh oh!

eiriktsarpalis commented Jun 18, 2025

Uh oh!

jeffhandley commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

PranavSenthilnathan commented Jun 18, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Jun 18, 2025

Uh oh!

PranavSenthilnathanJun 18, 2025

Choose a reason for hiding this comment

Uh oh!

eiriktsarpalis commented Jun 18, 2025

Uh oh!

jeffhandley commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

PranavSenthilnathan commented Jun 18, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Jun 18, 2025

Uh oh!

PranavSenthilnathanJun 18, 2025

Choose a reason for hiding this comment

Uh oh!

eiriktsarpalis commented Jun 18, 2025

Uh oh!

jeffhandley commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!