Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add interpreter pipeline by eduardo-vp · Pull Request #116844 · dotnet/runtime · GitHub
Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add interpreter pipeline by eduardo-vp · Pull Request #116844 · dotnet/runtime · GitHub
Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add interpreter pipeline by eduardo-vp · Pull Request #116844 · dotnet/runtime · GitHub
Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Add interpreter pipeline by eduardo-vp · Pull Request #116844 · dotnet/runtime · GitHub
Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add interpreter pipeline by eduardo-vp · Pull Request #116844 · dotnet/runtime · GitHub
Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add interpreter pipeline by eduardo-vp · Pull Request #116844 · dotnet/runtime · GitHub
Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Add interpreter pipeline by eduardo-vp · Pull Request #116844 · dotnet/runtime · GitHub
Skip to content

Add interpreter pipeline - #116844

Merged
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci
Jul 1, 2025
Merged

Add interpreter pipeline#116844
eduardo-vp merged 10 commits into
dotnet:mainfrom
eduardo-vp:interpreter-tests-ci

Conversation

@eduardo-vp

@eduardo-vpeduardo-vp commented Jun 20, 2025

Copy link
Copy Markdown
Member

Adding a pipeline that runs pri1 tests using the interpreter.

After taking a look with @janvorli, updated src/tests/Common/CLRTest.Execute.Bash.targets since there were two BashCLRTestLaunchCmds blocks under the condition '$(CLRTestKind)' == 'BuildAndRun' And '$(TargetOS)' != 'browser' And '$(TargetOS)' != 'android', one for arm64 and one for everything but arm64. However, turns out it's no longer necessary to split in two separate blocks anymore, the logic should be the same one for both. In particular, the ability to use the interpreter and the support for lldb was present in only one of them whereas it should be present in both.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
eduardo-vpforce-pushed the interpreter-tests-ci branch from 42abcf8 to af49e63CompareJune 23, 2025 19:55
@eduardo-vp
eduardo-vp marked this pull request as ready for review June 23, 2025 20:07
CopilotAI review requested due to automatic review settings June 23, 2025 20:07

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running pri1 tests using the interpreter by introducing a dedicated pipeline and wiring a RunInterpreter flag through Helix publishing.

  • Extended helixpublishwitharcade.proj to define and consume a _RunInterpreter MSBuild property and emit Helix pre-commands.
  • Created eng/pipelines/coreclr/interpreter.yml to build CoreCLR in debug/release/checked configurations and invoke tests with runInterpreter: true.
  • Updated common templates (send-to-helix-step.yml, run-test-job.yml) to accept and forward the runInterpreter parameter.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/Common/helixpublishwitharcade.projAdded _RunInterpreter property and corresponding Windows/Linux Helix pre-commands.
eng/pipelines/coreclr/interpreter.ymlNew pipeline file for interpreter-based builds and test runs.
eng/pipelines/common/templates/runtimes/send-to-helix-step.ymlAdded runInterpreter parameter and mapped it to _RunInterpreter.
eng/pipelines/common/templates/runtimes/run-test-job.ymlIntroduced runInterpreter parameter with default false and propagated it.
Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/interpreter.yml:16

  • [nitpick] The pipeline duplicates the platform matrix definitions across multiple build and test jobs. Consider extracting the platform lists into a shared variable or template to reduce duplication and make future updates easier.
 - template: /eng/pipelines/common/platform-matrix.yml

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter-tests-ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-interpreter-tests-ci

Can we rename this to runtime-interpreter-tests or just runtime-interpreter for consistency? We do not have -ci suffix in names of any existing runs. (Noticed in #116310 (comment).)

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@eduardo-vp

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 27, 2025
Comment threadsrc/tests/Common/CLRTest.Execute.Bash.targets
@eduardo-vp
eduardo-vp merged commit 359769e into dotnet:mainJul 1, 2025
@eduardo-vp
eduardo-vp deleted the interpreter-tests-ci branch July 1, 2025 21:08
@jkotas

Copy link
Copy Markdown
Member

This is triggering and causing a lot of failures on most (all?) PRs now. For example, #109006 and #116471. Could you please look into it and switch it to manual trigger?

jkotas added a commit that referenced this pull request Jul 2, 2025
@jkotas

Copy link
Copy Markdown
Member

Submitted revert #117234

jkotas added a commit that referenced this pull request Jul 2, 2025
@mangod9

Copy link
Copy Markdown
Member

yeah this was always meant to be manually triggered initially. Eduardo please check why it's affecting PRs.

@jkoritzinsky

Copy link
Copy Markdown
Member

The manual trigger setting needs to be set up by Eng Services First Responder. We can't do it ourselves.

@eduardo-vpeduardo-vp mentioned this pull request Jul 2, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-vp@jkotas@janvorli@mangod9@jkoritzinsky