Skip to content

Implement the unsigned-source overflowing conversions in the interpreter - #116924

Merged
kg merged 1 commit into
dotnet:mainfrom
kg:interp-conv-ovf-un
Jul 8, 2025
Merged

Implement the unsigned-source overflowing conversions in the interpreter#116924
kg merged 1 commit into
dotnet:mainfrom
kg:interp-conv-ovf-un

Conversation

@kg

@kgkg commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Implements the _un versions of conv_ovf.
  • Fixes some incorrect/missing conversions in the original conv_ovfs I added in a previous PR.
  • Expands the conv_ovf helper so it can do same-size and growing conversions with sign changes.

CopilotAI review requested due to automatic review settings June 23, 2025 18:10
@kg
kg requested review from BrzVlad and janvorli as code ownersJune 23, 2025 18:10
@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 23, 2025

This comment was marked as outdated.

Sign in to view

@kg
kg marked this pull request as draft June 23, 2025 18:27
@kg

kg commented Jun 23, 2025

Copy link
Copy Markdown
ContributorAuthor

Noticed some other problems with our conversions so I'm going to clean them up.

janvorli
janvorli reviewed Jun 23, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp Outdated
Comment threadsrc/coreclr/interpreter/compiler.cpp Outdated
Comment threadsrc/coreclr/interpreter/compiler.cpp
@kg
kg requested a review from CopilotJune 23, 2025 20:09
CopilotAI reviewed Jun 23, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for unsigned-source overflow-checking conversions in the interpreter backend and corresponding compiler support, and adds a new unit test to validate these conversions.

  • Introduces new conv.u8.u4 and various conv.ovf.* opcodes in intops.def
  • Extends ConvOvfHelper and opcode dispatch in interpexec.cpp to handle unsigned-source cases
  • Updates compiler.cpp to emit the new overflow opcodes for unsigned conversions
  • Adds TestConvOvfUn (and console logging) in Interpreter.cs to cover unsigned overflow conversions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

FileDescription
src/tests/JIT/interpreter/Interpreter.csAdded TestConvOvfUn method and Console.WriteLine calls for clarity
src/coreclr/vm/interpexec.cppEnhanced ConvOvfHelper to support growing conversions with sign changes and added unsigned conversion cases
src/coreclr/interpreter/intops.defDefined new unsigned-source overflow-checking opcodes
src/coreclr/interpreter/compiler.cppUpdated code generator to emit the new unsigned conversion opcodes
Comments suppressed due to low confidence (2)

src/coreclr/interpreter/compiler.cpp:4078

  • In the CEE_CONV_OVF_U_UN case on 32-bit targets, using INTOP_CONV_OVF_U4_I8 treats the source as signed. To properly implement 'un' (treat source as unsigned), replace this with INTOP_CONV_OVF_U4_U8.
#else

src/tests/JIT/interpreter/Interpreter.cs:1570

  • [nitpick] Variables a, b, and c are non-descriptive; consider renaming them to clarify their purpose (e.g., resultFromU2, resultFromU4, resultFromU8).
 byte a = (byte)u2,

@teo-tsirpanisteo-tsirpanis added area-CodeGen-Interpreter-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 23, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@kg
kg marked this pull request as ready for review June 23, 2025 22:08
@build-analysisbuild-analysisBot mentioned this pull request Jun 23, 2025
Closed
BrzVlad
BrzVlad reviewed Jun 24, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp Outdated
BrzVlad
BrzVlad reviewed Jun 24, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jun 26, 2025
Closed
@kotlarmiloskotlarmilos mentioned this pull request Jul 3, 2025
Merged
1 task
@janvorli

janvorli commented Jul 7, 2025

Copy link
Copy Markdown
Member

@kg can you please resolve the conflict so that we can merge the change?

janvorli
janvorli approved these changes Jul 7, 2025
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kg
Add unsigned conv ovf test
1bfa6c7
Checkpoint
Checkpoint
Implement most of the unsigned source conversions
Generalize ConvOvfHelper to support growing conversions as well
Add some missing conv ovf opcodes
Fix up ovf conversion mappings in compiler
Fix copy paste error
Fix copy-paste error
Add missing check
Remove no-op movs
Remove no-op mov convs
@kg
kgforce-pushed the interp-conv-ovf-un branch from ae07142 to 1bfa6c7CompareJuly 7, 2025 23:32
@kg
kg enabled auto-merge (squash) July 7, 2025 23:50
@kg
kg disabled auto-merge July 7, 2025 23:50
@kg
kg enabled auto-merge (squash) July 7, 2025 23:50
This was referenced Jul 8, 2025
Open
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jul 8, 2025
Open
3 tasks
@kg
kg disabled auto-merge July 8, 2025 20:36
@kg

kg commented Jul 8, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I see "Merging is blocked: All comments must be resolved" but there are no unresolved comments on this PR. Does anyone know what causes that?

EDIT: Copilot had marked some unresolved comments as "outdated", making them invisible.

@kg
kg merged commit 8ec637d into dotnet:mainJul 8, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@BrzVladBrzVladBrzVlad approved these changes
@janvorlijanvorlijanvorli approved these changes

Assignees

@kgkg

Labels

area-CodeGen-Interpreter-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kg@janvorli@BrzVlad@teo-tsirpanis