Add riscv64 managed unwinder for cDAC by am11 · Pull Request #117436 · dotnet/runtime

am11 · 2025-07-08T20:37:56Z

No description provided.

risc-vv · 2025-07-08T20:40:41Z

@dotnet/samsung Could you please take a look? These changes may be related to riscv64.

am11 · 2025-07-08T20:57:47Z

@dotnet/samsung, @filipnavara, FYI. I haven't tested it with dotnet/diagnostics repo (libSOS lldb plugin) yet. But it would be easier to fine tune it once the bulk of change is in. Good thing is that it's an independent component at the moment, future replacement for existing/classic DAC.

risc-vv · 2025-07-09T10:50:19Z

{CONFIG}-CLR-tests FAILED

buildinfo.json
coreCLR tests failed for unknown reason. Check buildinfo.json or gocd for more details.

RISC-V Release-FX-QEMU: 281132 / 282209 (99.62%)

=======================
passed: 281132
failed: 1070
skipped: 39
killed: 7
------------------------
TOTAL tests: 282248
VIRTUAL time: 31h 22min 54s 333ms
REAL time: 1h 10min 24s 74ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 380606 / 381279 (99.82%)

=======================
passed: 380606
failed: 664
skipped: 20
killed: 9
------------------------
TOTAL tests: 381299
VIRTUAL time: 13h 34min 8s 859ms
REAL time: 1h 26min 37s 556ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 160881c34e6b2929f2082d6c15d21ae8181a4c1f
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-07-09T12:42:41Z

RISC-V Release-CLR-QEMU: 9082 / 9112 (99.67%)

=======================
passed: 9082
failed: 2
skipped: 597
killed: 28
------------------------
TOTAL tests: 9709
VIRTUAL time: 37h 24min 32s 497ms
REAL time: 38min 9s 665ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 51149e9a91ff508c22ffe3817cebbbab7498a6a0
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-07-09T13:25:10Z

RISC-V Release-FX-QEMU: 283572 / 284668 (99.61%)

=======================
passed: 283572
failed: 1086
skipped: 39
killed: 10
------------------------
TOTAL tests: 284707
VIRTUAL time: 33h 25min 43s 223ms
REAL time: 1h 11min 0s 332ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 51149e9a91ff508c22ffe3817cebbbab7498a6a0
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-07-09T15:04:54Z

RISC-V Release-CLR-QEMU: 9082 / 9112 (99.67%)

=======================
passed: 9082
failed: 2
skipped: 597
killed: 28
------------------------
TOTAL tests: 9709
VIRTUAL time: 37h 27min 31s 435ms
REAL time: 39min 35s 917ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 51149e9a91ff508c22ffe3817cebbbab7498a6a0
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-07-09T16:55:30Z

RISC-V Release-CLR-VF2: 9083 / 9113 (99.67%)

=======================
passed: 9083
failed: 2
skipped: 597
killed: 28
------------------------
TOTAL tests: 9710
VIRTUAL time: 11h 32min 7s 973ms
REAL time: 46min 45s 227ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 283220 / 284300 (99.62%)

=======================
passed: 283220
failed: 1073
skipped: 39
killed: 7
------------------------
TOTAL tests: 284339
VIRTUAL time: 32h 34min 53s 425ms
REAL time: 1h 12min 0s 380ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 309598 / 311346 (99.44%)

=======================
passed: 309598
failed: 1739
skipped: 39
killed: 9
------------------------
TOTAL tests: 311385
VIRTUAL time: 23h 3min 16s 627ms
REAL time: 2h 12min 4s 42ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 2f2e22063b0afaa65fa8d33c7170cc9f6f5b5743
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

max-charlamb

cDAC implementation looks good module comments. I don't have as much insight into the build changes.

Thanks for adding this!

risc-vv · 2025-07-09T18:11:27Z

RISC-V Release-CLR-VF2: 9083 / 9113 (99.67%)

=======================
passed: 9083
failed: 2
skipped: 597
killed: 28
------------------------
TOTAL tests: 9710
VIRTUAL time: 11h 34min 7s 471ms
REAL time: 46min 57s 341ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 53fad81d5fb4f5059264c51335c7fbe2b716bb1b
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

am11 · 2025-07-09T18:22:27Z

/runtime/.dotnet/sdk/10.0.100-preview.6.25315.102/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1047: Assets file '/runtime/artifacts/obj/Mono.Linker/project.assets.json' doesn't have a target for 'net10.0/linux-riscv64'. Ensure that restore has run and that you have included 'net10.0' in the TargetFrameworks for your project. You may also need to include 'linux-riscv64' in your project's RuntimeIdentifiers. [/runtime/src/tools/illink/src/linker/Mono.Linker.csproj]

This NETSDK1047 is being raised intermittently with live linker (sometimes freebsd-x64 bootstrapped fails, other times linux-riscv64 or loongarch64). I found a conversation between @ViktorHofer and @jkoritzinsky #92826 (comment), perhaps removing this global property:

src/native/managed/subproject.props: <SubprojectProps Include="RuntimeIdentifier" Value="$(TargetRid)" />

may help? I checked Mono.Linker.csproj's project.assets.json generated under obj/ dir, it sometimes have net10.0/linux-loongarch64 (or riscv64 etc.) at the point cDAC is published (when it passes), other times it doesn't have the RID node in that JSON file. Without importing live linker targets, it fails due to the missing PrepareForILLink target. We can hack this target as well. I'm not sure what's the proper way to address it.

risc-vv · 2025-07-09T21:02:18Z

RISC-V Release-CLR-VF2: 9083 / 9113 (99.67%)

=======================
passed: 9083
failed: 2
skipped: 597
killed: 28
------------------------
TOTAL tests: 9710
VIRTUAL time: 11h 12min 45s 59ms
REAL time: 45min 32s 750ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-QEMU: 9082 / 9112 (99.67%)

=======================
passed: 9082
failed: 2
skipped: 597
killed: 28
------------------------
TOTAL tests: 9709
VIRTUAL time: 37h 24min 50s 922ms
REAL time: 38min 7s 177ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 66c1fb239626593a5951d1f8b322a3e447216b09
CI: d6c9c1ab3a7411819463edc05ded301e89ba586a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-08-22T08:00:42Z

@dotnet/samsung Could you please take a look? These changes may be related to riscv64.

risc-vv · 2025-08-28T05:25:35Z

@dotnet/samsung Could you please take a look? These changes may be related to riscv64.

tomeksowi · 2025-08-28T10:05:00Z

@dotnet/samsung Could you please take a look? These changes may be related to riscv64.

Sorry for spam, disabled for now

am11 · 2025-08-30T21:24:06Z

@jkoritzinsky I tried a few more things (e.g., setting HasRuntimeOutput=false), but it didn’t help; three out of five builds are still failing. In CI, the failing bootstrap leg varies from run to run (sometimes riscv64, sometimes loongarch64, sometimes freebsd), so it seems to be intermittent rather than tied to a specific bootstrap platform.

If you have other ideas to make Mono.Linker.csproj restore more reliable, please let me know, or feel free to push commits directly to the PR branch.

am11 · 2025-09-05T21:53:58Z

Use the right property name (really wish this was better doc'd

Thanks a lot @jkoritzinsky! Six repeated builds passed (earlier three out of five builds were failing).

Can we test this change in dotnet/dotnet before merging the PR? We saw two issues earlier:

[main] Source code updates from dotnet/runtime dotnet#1392 (comment) P2P ref fails, I think we will need to separate cDAC _inbuild and _published csprojs same as ilc / cg2 to satisfy the matrix.
Punt on cdac transport pack for linux-musl dotnet#1464 something in linux-musl cDAC package fails, most likely linux vs. linux-musl in path but it's a guess since the PR description didn't specify the error it was fixing. Perhaps we can run specific CI leg which failed to find out the details.

jkoritzinsky · 2025-09-16T23:09:39Z

@am11 for 1) I would expect that doing the same GlobalPropertiesToRemove trick would work.
for 2) I'm unsure and I'd rather defer that to the cdac folks to figure out when they're shipping if we can.

JulieLeeMSFT · 2025-10-13T16:39:21Z

@max-charlamb, PTAL.
CC @steveisok.

am11 · 2025-10-15T16:43:38Z

Builds at dotnet/dotnet#2512 are passing. System.Net failures are unrelated (likely due to some recent change; failing on other recent runs as well).

jkoritzinsky · 2025-10-15T19:52:47Z

/ba-g lseek failures unrelated

github-actionsBot added the area-Diagnostics-coreclr label Jul 8, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 8, 2025

am11 added the arch-riscv Related to the RISC-V architecture label Jul 8, 2025

am11 requested review from a team and jkoritzinsky July 8, 2025 20:39

steveisok requested a review from max-charlamb July 8, 2025 20:42

This was referenced Jul 9, 2025
Occasional failure in "browser-wasm windows Release LibraryTests: Build Product" #116671
Closed
browser-wasm Windows build error #116746
Closed
wasm build failure in CI #117017
Closed

am11 force-pushed the feature/cdac/riscv64-unwinder branch 2 times, most recently from 62b5ef0 to 51149e9Compare July 9, 2025 11:51

am11 force-pushed the feature/cdac/riscv64-unwinder branch from 2f2e220 to d436429Compare July 9, 2025 17:13

max-charlamb reviewed Jul 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jul 9, 2025
STATUS_UNSUCCESSFUL in RsaCryptRoundtrip_OaepSHA1 #29683
Open

build-analysisBot mentioned this pull request Jul 9, 2025
browser-wasm windows Debug AllSubsets_CoreCLR builds failing in emcc seemingly unrelated to any code issues #116647
Closed

Merge branch 'main' into feature/cdac/riscv64-unwinder
be200ba

build-analysisBot mentioned this pull request Aug 28, 2025
[wasm] System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose failing with WebSocketException #117964
Open

am11 added 6 commits August 29, 2025 06:26

Update Directory.Build.targets
7c41779

Try a magic spell
ff87bac

Update Directory.Build.targets
30ecbda

Update Directory.Build.targets
d3183b1

Revert magic spell; didn't help
4e230c0

Merge branch 'main' into feature/cdac/riscv64-unwinder
981df48

Use the right property name (really wish this was better doc'd)
ecd8f17

Merge branch 'main' into feature/cdac/riscv64-unwinder
ed52c9b

am11 mentioned this pull request Sep 19, 2025
Apply cDAC riscv64 patch dotnet/dotnet#2512
Closed

build-analysisBot mentioned this pull request Sep 19, 2025
AppHost tests fail with "Failure extracting contents of the application bundle." #119249
Closed

am11 added 2 commits October 15, 2025 15:55

Merge branch 'main' into feature/cdac/riscv64-unwinder
f5e9da5

Apply GlobalPropertiesToRemove suggestion
4707e9b

jkoritzinsky approved these changes Oct 15, 2025
View reviewed changes

jkoritzinsky enabled auto-merge (squash) October 15, 2025 14:54

build-analysisBot mentioned this pull request Oct 15, 2025
Unable to pull image from mcr.microsoft.com #117164
Closed

jkoritzinsky merged commit a6fc6ad into dotnet:mainOct 15, 2025
149 of 152 checks passed

am11 deleted the feature/cdac/riscv64-unwinder branch October 16, 2025 07:10

dotnet-maestroBot mentioned this pull request Oct 21, 2025
[main] Source code updates from dotnet/runtime dotnet/dotnet#3024
Merged

github-actionsBot locked and limited conversation to collaborators Nov 15, 2025

Uh oh!

Conversation

am11 commented Jul 8, 2025

Uh oh!

risc-vv commented Jul 8, 2025

Uh oh!

am11 commented Jul 8, 2025

Uh oh!

risc-vv commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

risc-vv commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

am11 commented Jul 9, 2025

Uh oh!

risc-vv commented Jul 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Aug 22, 2025

Uh oh!

risc-vv commented Aug 28, 2025

Uh oh!

tomeksowi commented Aug 28, 2025

Uh oh!

am11 commented Aug 30, 2025

Uh oh!

am11 commented Sep 5, 2025

Uh oh!

jkoritzinsky commented Sep 16, 2025

Uh oh!

JulieLeeMSFT commented Oct 13, 2025

Uh oh!

am11 commented Oct 15, 2025

Uh oh!

jkoritzinsky commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

risc-vv commented Jul 9, 2025•
edited
Loading

risc-vv commented Jul 9, 2025•
edited
Loading

risc-vv commented Jul 9, 2025•
edited
Loading

risc-vv commented Jul 9, 2025•
edited
Loading

risc-vv commented Jul 9, 2025•
edited
Loading

risc-vv commented Jul 9, 2025•
edited
Loading

risc-vv commented Jul 9, 2025•
edited
Loading