Skip to content

Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465

Merged
vcsjones merged 6 commits into
dotnet:mainfrom
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged

Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom
vcsjones:no-macos-openssl-native

Conversation

@vcsjones

@vcsjonesvcsjones commented Jul 9, 2025

Copy link
Copy Markdown
Member

In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.

@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 9, 2025
@vcsjonesvcsjones added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 9, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@vcsjones

vcsjones commented Jul 9, 2025

Copy link
Copy Markdown
MemberAuthor

/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.

@vcsjonesvcsjones mentioned this pull request Jul 9, 2025
Merged
@vcsjones

vcsjones commented Jul 9, 2025

Copy link
Copy Markdown
MemberAuthor

Blocked on #117472.

This was referenced Jul 9, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@vcsjones

vcsjones commented Jul 9, 2025

Copy link
Copy Markdown
MemberAuthor

Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.

@vcsjonesvcsjones closed this Jul 9, 2025
@vcsjonesvcsjones reopened this Jul 11, 2025
This was referenced Jul 11, 2025
Closed
Closed
Closed
Closed
@vcsjones
vcsjones marked this pull request as ready for review July 11, 2025 21:11
CopilotAI review requested due to automatic review settings July 11, 2025 21:11
CopilotAI reviewed Jul 11, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.

Key changes:

  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements

@vcsjones

vcsjones commented Jul 11, 2025

Copy link
Copy Markdown
MemberAuthor

The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.

I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?

@bartonjs

bartonjs commented Jul 11, 2025

Copy link
Copy Markdown
Member

Are there parts of packaging and installer building that will need to be updated elsewhere?

I think

runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92 in e717202

<PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" />
<PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" />
(so, this repository)

@vcsjones

vcsjones commented Jul 11, 2025

Copy link
Copy Markdown
MemberAuthor

Are there parts of packaging and installer building that will need to be updated elsewhere?

I think

runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92 in e717202

<PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" />
<PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" />

(so, this repository)

I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.

akoeplinger
akoeplinger approved these changes Jul 14, 2025
View reviewed changes

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst

Comment threadeng/native/build-commons.sh Outdated
Comment threadsrc/native/libs/build-native.sh Outdated
@akoeplinger

akoeplinger commented Jul 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.

Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025
Open
Closed
@vcsjones
vcsjones enabled auto-merge (squash) July 15, 2025 21:39
@build-analysisbuild-analysisBot mentioned this pull request Jul 16, 2025
Closed
This was referenced Jul 16, 2025
Open
Closed
@akoeplinger

akoeplinger commented Jul 16, 2025

Copy link
Copy Markdown
Member

/ba-g all the failures on non-Apple platforms are unrelated

@vcsjones
vcsjones merged commit 91f8b1a into dotnet:mainJul 16, 2025
152 of 162 checks passed
@vcsjones
vcsjones deleted the no-macos-openssl-native branch July 16, 2025 16:29
@vcsjonesvcsjones added this to the 10.0.0 milestone Jul 24, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Stop building System.Security.Cryptography.Native.OpenSsl on macOS by vcsjones · Pull Request #117465 · dotnet/runtime · GitHub
Skip to content
Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465
Merged
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged
Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Conversation
@vcsjones
@vcsjonesvcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

Member
In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.
@github-actionsgithub-actionsBot
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 9, 2025
@vcsjonesvcsjones
added

area-Infrastructure-libraries

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 9, 2025
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 9, 2025

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.
@vcsjonesvcsjones
mentioned this pull request
Jul 9, 2025
 Merged

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Blocked on #117472.

This was referenced Jul 9, 2025

Closed


Closed


Closed


Closed


Closed


Closed

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.
@vcsjonesvcsjones
closed this
Jul 9, 2025
@vcsjonesvcsjones
reopened this
Jul 11, 2025

This was referenced Jul 11, 2025

Closed


Closed


Closed


Closed

@vcsjones
vcsjones
marked this pull request as ready for review
July 11, 2025 21:11
CopilotAI
review requested due to automatic review settings
July 11, 2025 21:11
CopilotAI
reviewed
Jul 11, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.
Key changes:
  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.
I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?
@bartonjs
bartonjs
commented
Jul 11, 2025

Copy link


Copy Markdown

Member
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think 
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 

(so, this repository)
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 
(so, this repository)
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
akoeplinger
akoeplinger
approved these changes
Jul 14, 2025
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst
Comment threadeng/native/build-commons.sh
Outdated

Comment threadsrc/native/libs/build-native.sh
Outdated

@akoeplinger
akoeplinger
commented
Jul 14, 2025•

edited

Loading

Copy link


Copy Markdown

Member
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025

Open


Closed

@vcsjones
vcsjones
enabled auto-merge (squash)
July 15, 2025 21:39
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 16, 2025

Closed


This was referenced Jul 16, 2025

Open


Closed

@akoeplinger
akoeplinger
commented
Jul 16, 2025

Copy link


Copy Markdown

Member
/ba-g all the failures on non-Apple platforms are unrelated
@vcsjones
vcsjones
merged commit 91f8b1a
into
dotnet:mainJul 16, 2025

152 of 162 checks passed

@vcsjones
vcsjones
deleted the

no-macos-openssl-native

branch
July 16, 2025 16:29
@vcsjonesvcsjones
added this to the 10.0.0 milestone
Jul 24, 2025
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stop building System.Security.Cryptography.Native.OpenSsl on macOS by vcsjones · Pull Request #117465 · dotnet/runtime · GitHub
Skip to content
Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465
Merged
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged
Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Conversation
@vcsjones
@vcsjonesvcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

Member
In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.
@github-actionsgithub-actionsBot
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 9, 2025
@vcsjonesvcsjones
added

area-Infrastructure-libraries

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 9, 2025
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 9, 2025

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.
@vcsjonesvcsjones
mentioned this pull request
Jul 9, 2025
 Merged

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Blocked on #117472.

This was referenced Jul 9, 2025

Closed


Closed


Closed


Closed


Closed


Closed

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.
@vcsjonesvcsjones
closed this
Jul 9, 2025
@vcsjonesvcsjones
reopened this
Jul 11, 2025

This was referenced Jul 11, 2025

Closed


Closed


Closed


Closed

@vcsjones
vcsjones
marked this pull request as ready for review
July 11, 2025 21:11
CopilotAI
review requested due to automatic review settings
July 11, 2025 21:11
CopilotAI
reviewed
Jul 11, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.
Key changes:
  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.
I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?
@bartonjs
bartonjs
commented
Jul 11, 2025

Copy link


Copy Markdown

Member
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think 
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 

(so, this repository)
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 
(so, this repository)
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
akoeplinger
akoeplinger
approved these changes
Jul 14, 2025
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst
Comment threadeng/native/build-commons.sh
Outdated

Comment threadsrc/native/libs/build-native.sh
Outdated

@akoeplinger
akoeplinger
commented
Jul 14, 2025•

edited

Loading

Copy link


Copy Markdown

Member
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025

Open


Closed

@vcsjones
vcsjones
enabled auto-merge (squash)
July 15, 2025 21:39
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 16, 2025

Closed


This was referenced Jul 16, 2025

Open


Closed

@akoeplinger
akoeplinger
commented
Jul 16, 2025

Copy link


Copy Markdown

Member
/ba-g all the failures on non-Apple platforms are unrelated
@vcsjones
vcsjones
merged commit 91f8b1a
into
dotnet:mainJul 16, 2025

152 of 162 checks passed

@vcsjones
vcsjones
deleted the

no-macos-openssl-native

branch
July 16, 2025 16:29
@vcsjonesvcsjones
added this to the 10.0.0 milestone
Jul 24, 2025
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stop building System.Security.Cryptography.Native.OpenSsl on macOS by vcsjones · Pull Request #117465 · dotnet/runtime · GitHub
Skip to content
Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465
Merged
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged
Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Conversation
@vcsjones
@vcsjonesvcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

Member
In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.
@github-actionsgithub-actionsBot
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 9, 2025
@vcsjonesvcsjones
added

area-Infrastructure-libraries

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 9, 2025
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 9, 2025

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.
@vcsjonesvcsjones
mentioned this pull request
Jul 9, 2025
 Merged

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Blocked on #117472.

This was referenced Jul 9, 2025

Closed


Closed


Closed


Closed


Closed


Closed

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.
@vcsjonesvcsjones
closed this
Jul 9, 2025
@vcsjonesvcsjones
reopened this
Jul 11, 2025

This was referenced Jul 11, 2025

Closed


Closed


Closed


Closed

@vcsjones
vcsjones
marked this pull request as ready for review
July 11, 2025 21:11
CopilotAI
review requested due to automatic review settings
July 11, 2025 21:11
CopilotAI
reviewed
Jul 11, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.
Key changes:
  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.
I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?
@bartonjs
bartonjs
commented
Jul 11, 2025

Copy link


Copy Markdown

Member
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think 
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 

(so, this repository)
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 
(so, this repository)
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
akoeplinger
akoeplinger
approved these changes
Jul 14, 2025
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst
Comment threadeng/native/build-commons.sh
Outdated

Comment threadsrc/native/libs/build-native.sh
Outdated

@akoeplinger
akoeplinger
commented
Jul 14, 2025•

edited

Loading

Copy link


Copy Markdown

Member
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025

Open


Closed

@vcsjones
vcsjones
enabled auto-merge (squash)
July 15, 2025 21:39
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 16, 2025

Closed


This was referenced Jul 16, 2025

Open


Closed

@akoeplinger
akoeplinger
commented
Jul 16, 2025

Copy link


Copy Markdown

Member
/ba-g all the failures on non-Apple platforms are unrelated
@vcsjones
vcsjones
merged commit 91f8b1a
into
dotnet:mainJul 16, 2025

152 of 162 checks passed

@vcsjones
vcsjones
deleted the

no-macos-openssl-native

branch
July 16, 2025 16:29
@vcsjonesvcsjones
added this to the 10.0.0 milestone
Jul 24, 2025
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Stop building System.Security.Cryptography.Native.OpenSsl on macOS by vcsjones · Pull Request #117465 · dotnet/runtime · GitHub
Skip to content
Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465
Merged
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged
Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Conversation
@vcsjones
@vcsjonesvcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

Member
In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.
@github-actionsgithub-actionsBot
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 9, 2025
@vcsjonesvcsjones
added

area-Infrastructure-libraries

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 9, 2025
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 9, 2025

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.
@vcsjonesvcsjones
mentioned this pull request
Jul 9, 2025
 Merged

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Blocked on #117472.

This was referenced Jul 9, 2025

Closed


Closed


Closed


Closed


Closed


Closed

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.
@vcsjonesvcsjones
closed this
Jul 9, 2025
@vcsjonesvcsjones
reopened this
Jul 11, 2025

This was referenced Jul 11, 2025

Closed


Closed


Closed


Closed

@vcsjones
vcsjones
marked this pull request as ready for review
July 11, 2025 21:11
CopilotAI
review requested due to automatic review settings
July 11, 2025 21:11
CopilotAI
reviewed
Jul 11, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.
Key changes:
  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.
I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?
@bartonjs
bartonjs
commented
Jul 11, 2025

Copy link


Copy Markdown

Member
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think 
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 

(so, this repository)
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 
(so, this repository)
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
akoeplinger
akoeplinger
approved these changes
Jul 14, 2025
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst
Comment threadeng/native/build-commons.sh
Outdated

Comment threadsrc/native/libs/build-native.sh
Outdated

@akoeplinger
akoeplinger
commented
Jul 14, 2025•

edited

Loading

Copy link


Copy Markdown

Member
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025

Open


Closed

@vcsjones
vcsjones
enabled auto-merge (squash)
July 15, 2025 21:39
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 16, 2025

Closed


This was referenced Jul 16, 2025

Open


Closed

@akoeplinger
akoeplinger
commented
Jul 16, 2025

Copy link


Copy Markdown

Member
/ba-g all the failures on non-Apple platforms are unrelated
@vcsjones
vcsjones
merged commit 91f8b1a
into
dotnet:mainJul 16, 2025

152 of 162 checks passed

@vcsjones
vcsjones
deleted the

no-macos-openssl-native

branch
July 16, 2025 16:29
@vcsjonesvcsjones
added this to the 10.0.0 milestone
Jul 24, 2025
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stop building System.Security.Cryptography.Native.OpenSsl on macOS by vcsjones · Pull Request #117465 · dotnet/runtime · GitHub
Skip to content
Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465
Merged
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged
Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Conversation
@vcsjones
@vcsjonesvcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

Member
In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.
@github-actionsgithub-actionsBot
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 9, 2025
@vcsjonesvcsjones
added

area-Infrastructure-libraries

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 9, 2025
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 9, 2025

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.
@vcsjonesvcsjones
mentioned this pull request
Jul 9, 2025
 Merged

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Blocked on #117472.

This was referenced Jul 9, 2025

Closed


Closed


Closed


Closed


Closed


Closed

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.
@vcsjonesvcsjones
closed this
Jul 9, 2025
@vcsjonesvcsjones
reopened this
Jul 11, 2025

This was referenced Jul 11, 2025

Closed


Closed


Closed


Closed

@vcsjones
vcsjones
marked this pull request as ready for review
July 11, 2025 21:11
CopilotAI
review requested due to automatic review settings
July 11, 2025 21:11
CopilotAI
reviewed
Jul 11, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.
Key changes:
  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.
I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?
@bartonjs
bartonjs
commented
Jul 11, 2025

Copy link


Copy Markdown

Member
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think 
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 

(so, this repository)
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 
(so, this repository)
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
akoeplinger
akoeplinger
approved these changes
Jul 14, 2025
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst
Comment threadeng/native/build-commons.sh
Outdated

Comment threadsrc/native/libs/build-native.sh
Outdated

@akoeplinger
akoeplinger
commented
Jul 14, 2025•

edited

Loading

Copy link


Copy Markdown

Member
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025

Open


Closed

@vcsjones
vcsjones
enabled auto-merge (squash)
July 15, 2025 21:39
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 16, 2025

Closed


This was referenced Jul 16, 2025

Open


Closed

@akoeplinger
akoeplinger
commented
Jul 16, 2025

Copy link


Copy Markdown

Member
/ba-g all the failures on non-Apple platforms are unrelated
@vcsjones
vcsjones
merged commit 91f8b1a
into
dotnet:mainJul 16, 2025

152 of 162 checks passed

@vcsjones
vcsjones
deleted the

no-macos-openssl-native

branch
July 16, 2025 16:29
@vcsjonesvcsjones
added this to the 10.0.0 milestone
Jul 24, 2025
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stop building System.Security.Cryptography.Native.OpenSsl on macOS by vcsjones · Pull Request #117465 · dotnet/runtime · GitHub
Skip to content
Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465
Merged
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged
Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Conversation
@vcsjones
@vcsjonesvcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

Member
In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.
@github-actionsgithub-actionsBot
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 9, 2025
@vcsjonesvcsjones
added

area-Infrastructure-libraries

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 9, 2025
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 9, 2025

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.
@vcsjonesvcsjones
mentioned this pull request
Jul 9, 2025
 Merged

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Blocked on #117472.

This was referenced Jul 9, 2025

Closed


Closed


Closed


Closed


Closed


Closed

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.
@vcsjonesvcsjones
closed this
Jul 9, 2025
@vcsjonesvcsjones
reopened this
Jul 11, 2025

This was referenced Jul 11, 2025

Closed


Closed


Closed


Closed

@vcsjones
vcsjones
marked this pull request as ready for review
July 11, 2025 21:11
CopilotAI
review requested due to automatic review settings
July 11, 2025 21:11
CopilotAI
reviewed
Jul 11, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.
Key changes:
  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.
I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?
@bartonjs
bartonjs
commented
Jul 11, 2025

Copy link


Copy Markdown

Member
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think 
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 

(so, this repository)
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 
(so, this repository)
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
akoeplinger
akoeplinger
approved these changes
Jul 14, 2025
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst
Comment threadeng/native/build-commons.sh
Outdated

Comment threadsrc/native/libs/build-native.sh
Outdated

@akoeplinger
akoeplinger
commented
Jul 14, 2025•

edited

Loading

Copy link


Copy Markdown

Member
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025

Open


Closed

@vcsjones
vcsjones
enabled auto-merge (squash)
July 15, 2025 21:39
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 16, 2025

Closed


This was referenced Jul 16, 2025

Open


Closed

@akoeplinger
akoeplinger
commented
Jul 16, 2025

Copy link


Copy Markdown

Member
/ba-g all the failures on non-Apple platforms are unrelated
@vcsjones
vcsjones
merged commit 91f8b1a
into
dotnet:mainJul 16, 2025

152 of 162 checks passed

@vcsjones
vcsjones
deleted the

no-macos-openssl-native

branch
July 16, 2025 16:29
@vcsjonesvcsjones
added this to the 10.0.0 milestone
Jul 24, 2025
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Stop building System.Security.Cryptography.Native.OpenSsl on macOS by vcsjones · Pull Request #117465 · dotnet/runtime · GitHub
Skip to content
Stop building System.Security.Cryptography.Native.OpenSsl on macOS - #117465
Merged
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Jul 16, 2025
Merged
Stop building System.Security.Cryptography.Native.OpenSsl on macOS#117465
vcsjones merged 6 commits into
dotnet:mainfrom 
vcsjones:no-macos-openssl-native
Conversation
@vcsjones
@vcsjonesvcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

Member
In #116481 we stopped supporting OpenSSL on macOS. This pull request stops building System.Security.Cryptography.Native.OpenSSL on macOS entirely, similarly to what we are doing for other Apple platforms today.
@github-actionsgithub-actionsBot
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 9, 2025
@vcsjonesvcsjones
added

area-Infrastructure-libraries

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 9, 2025
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 9, 2025

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
/cc @dotnet/area-system-security. This is a bit cross cutting in terms of area ownership but felt more "infrastructure-y", but something everyone should be aware of nonetheless.
@vcsjonesvcsjones
mentioned this pull request
Jul 9, 2025
 Merged

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Blocked on #117472.

This was referenced Jul 9, 2025

Closed


Closed


Closed


Closed


Closed


Closed

@vcsjones
vcsjones
commented
Jul 9, 2025

Copy link


Copy Markdown

MemberAuthor
Closing, because I am blocked, and the fix for blocking is blocked. Will re-open when / if it is feasible.
@vcsjonesvcsjones
closed this
Jul 9, 2025
@vcsjonesvcsjones
reopened this
Jul 11, 2025

This was referenced Jul 11, 2025

Closed


Closed


Closed


Closed

@vcsjones
vcsjones
marked this pull request as ready for review
July 11, 2025 21:11
CopilotAI
review requested due to automatic review settings
July 11, 2025 21:11
CopilotAI
reviewed
Jul 11, 2025
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview
This PR stops building System.Security.Cryptography.Native.OpenSsl on macOS, following the previous removal of OpenSSL support on macOS in #116481. The changes align macOS with other Apple platforms by excluding OpenSSL-related builds and using the Apple-specific cryptography implementation instead.
Key changes:
  • Excludes macOS from building OpenSSL cryptography native libraries
  • Updates build scripts to skip OpenSSL-related configuration on macOS
  • Consolidates Apple platform handling in CMake configurations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
src/native/libs/build-native.shAdds macOS to platforms that skip OpenSSL native library builds
src/native/libs/System.Security.Cryptography.Native/CMakeLists.txtRemoves macOS-specific OpenSSL configuration and build verification
src/native/libs/CMakeLists.txtConsolidates Apple platform handling to exclude OpenSSL and use Apple cryptography
src/native/corehost/hostpolicy/hostpolicy_context.cppExcludes macOS from OpenSSL DLL import resolution
src/native/corehost/build.shSkips OpenSSL-related CMake configuration on macOS
src/native/corehost/apphost/static/CMakeLists.txtExcludes Apple platforms from OpenSSL static library linking
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targetsUpdates condition to exclude all Apple platforms from OpenSSL
eng/native/build-commons.shAdds macOS to platforms that skip OpenSSL-related setup
docs/workflow/requirements/macos-requirements.mdRemoves OpenSSL from macOS build requirements
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
The Quic-on-MacOS using OpenSSL has been worked around, so this is feasible again.
I am suspicious how easy this change was. Are there parts of packaging and installer building that will need to be updated elsewhere?
@bartonjs
bartonjs
commented
Jul 11, 2025

Copy link


Copy Markdown

Member
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think 
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 

(so, this repository)
@vcsjones
vcsjones
commented
Jul 11, 2025

Copy link


Copy Markdown

MemberAuthor
Are there parts of packaging and installer building that will need to be updated elsewhere?
I think
runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props

Lines 91 to 92
in
e717202
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.a"IsNative="true" /> 
 <PlatformManifestFileEntryInclude="libSystem.Security.Cryptography.Native.Apple.dylib"IsNative="true" /> 
(so, this repository)
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
akoeplinger
akoeplinger
approved these changes
Jul 14, 2025
View reviewed changes
@akoeplingerakoeplinger
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment about catalyst
Comment threadeng/native/build-commons.sh
Outdated

Comment threadsrc/native/libs/build-native.sh
Outdated

@akoeplinger
akoeplinger
commented
Jul 14, 2025•

edited

Loading

Copy link


Copy Markdown

Member
I saw those, but I don't see them doing anything conditional. Like, libSystem.Security.Cryptography.Native.Apple.dylib is just "there" but clearly we don't build it for Linux or Windows. So I am not sure what an exclusion would look like there, if we had to do anything.
Yeah that list is basically a template which gets processed by https://github.com/dotnet/arcade/blob/4b2bc3e0e6de4355c126b544732481df97900c89/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L269-L272. Nothing to do here.

This was referenced Jul 15, 2025

Open


Closed

@vcsjones
vcsjones
enabled auto-merge (squash)
July 15, 2025 21:39
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 16, 2025

Closed


This was referenced Jul 16, 2025

Open


Closed

@akoeplinger
akoeplinger
commented
Jul 16, 2025

Copy link


Copy Markdown

Member
/ba-g all the failures on non-Apple platforms are unrelated
@vcsjones
vcsjones
merged commit 91f8b1a
into
dotnet:mainJul 16, 2025

152 of 162 checks passed

@vcsjones
vcsjones
deleted the

no-macos-openssl-native

branch
July 16, 2025 16:29
@vcsjonesvcsjones
added this to the 10.0.0 milestone
Jul 24, 2025
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 23, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@bartonjsbartonjsbartonjs approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@vcsjonesvcsjones

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vcsjones@bartonjs@akoeplinger