Uh oh!
There was an error while loading. Please reload this page.
disable multicast tests on AzureLinux - #117694
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR disables multicast tests on AzureLinux by introducing a new conditional check that excludes platforms where multicast functionality is not available or blocked. The change consolidates existing platform exclusions and adds AzureLinux to the list of platforms that cannot run multicast tests due to firewall restrictions.
Key Changes:
- Introduces a new
CanRunMulticastTestsproperty that consolidates platform checks for multicast test compatibility - Replaces individual
ConditionalFactandActiveIssueattributes with a single unified condition - Adds AzureLinux to the list of platforms excluded from multicast tests
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs:20
- [nitpick] The property name
CanRunMulticastTestsuses a positive naming convention but is implemented with negation logic. Consider renaming toShouldSkipMulticastTestsor restructuring the logic to avoid double negation for better readability.
private static readonly bool CanRunMulticastTests = !(PlatformDetection.IsNotWindowsNanoNorServerCore ||
Tagging subscribers to this area: @dotnet/ncl |
Uh oh!
There was an error while loading. Please reload this page.
ManickaP
commented
Jul 22, 2025
/ba-g failures unrelated |
jeffhandley
commented
Sep 8, 2025
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17566620163 |
related to #115502.
default AZL has firewall that blocks multicast.