Skip to content

[interp] Forcibly enable intrinsics when we encounter a must-expand call - #117727

Merged
kg merged 6 commits into
dotnet:mainfrom
kg:interp-mustexpand
Jul 30, 2025
Merged

[interp] Forcibly enable intrinsics when we encounter a must-expand call#117727
kg merged 6 commits into
dotnet:mainfrom
kg:interp-mustexpand

Conversation

@kg

@kgkg commented Jul 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Right now when testing individual methods from the startup path with the interpreter a lot of them fail due to stack overflow. This is because we're compiling a must expand intrinsic with the interpreter, which will recurse infinitely.

  • When encountering a must expand intrinsic self-call in an interpreted method, always expand it even if intrinsics are turned off.
  • Clean up a minor edge case in the 'is reference or contains references' intrinsic
  • Remove an alignment assert that is causing failures in the startup path

@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 16, 2025
kg
kg commented Jul 16, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/eeinterp.cpp Outdated
@kgkg mentioned this pull request Jul 16, 2025
Closed
12 tasks
@kg
kg marked this pull request as ready for review July 16, 2025 18:09
@kg
kg requested review from BrzVlad and janvorli as code ownersJuly 16, 2025 18:09
BrzVlad
BrzVlad reviewed Jul 16, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp
janvorli
janvorli reviewed Jul 16, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp Outdated
@kg

kg commented Jul 16, 2025

Copy link
Copy Markdown
ContributorAuthor

The failures on CI don't reproduce locally, it seems like when I run locally the test suite just exits early and is recorded as passing. Looking into it.

This was referenced Jul 16, 2025
Closed
Closed
@kg
kgforce-pushed the interp-mustexpand branch from 811e357 to c9feba0CompareJuly 17, 2025 04:39
jkotas
jkotas reviewed Jul 17, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jul 17, 2025
Closed
3 tasks
@dotnet-policy-service

dotnet-policy-serviceBot commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@jkotasjkotas removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 22, 2025
jkotas
jkotas reviewed Jul 22, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp
jkotas
jkotas reviewed Jul 22, 2025
View reviewed changes
Comment threadsrc/coreclr/interpreter/compiler.cpp
@kg@jkotas
Update src/coreclr/interpreter/compiler.cpp
06314c7
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@kgkg mentioned this pull request Jul 22, 2025
Open
This was referenced Jul 23, 2025
Closed
Open
This was referenced Jul 23, 2025
Closed
Closed
@kg
kg merged commit b6e34b8 into dotnet:mainJul 30, 2025
93 of 95 checks passed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrzVladBrzVladBrzVlad left review comments
@jkotasjkotasjkotas approved these changes
@janvorlijanvorlijanvorli approved these changes

Assignees

@kgkg

Labels

area-CodeGen-Interpreter-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kg@BrzVlad@jkotas@janvorli