Remove unnecessary length check in Guid parsing

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;

[PranavSenthilnathan]

Attempt to fix#118172

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -windows_x64 --filter "System.Text.Json.Tests.Perf_Get.GetGuid"

[PranavSenthilnathan]

This change is worth taking even if it doesn't improve perf since the check is unnecessary and does not follow the same pattern as other types. Marking as ready for review.

[Copilot]

Pull Request Overview

This PR removes an unnecessary length check in the TryGetGuidCore method within the Utf8JsonReader.TryGet.cs file, specifically targeting issue #118172. The change simplifies the GUID parsing logic by eliminating a redundant validation that was checking if the escaped GUID length exceeds the maximum allowed length.

Key Changes

• Removed the length validation check against JsonConstants.MaximumEscapedGuidLength in the GUID parsing path
• Streamlined the code flow by eliminating an early return condition

Comments suppressed due to low confidence (1)

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs:1354

• The removal of the length check means that extremely long strings will now be processed by subsequent GUID parsing logic. This behavior change should be covered by tests to ensure that oversized inputs are handled correctly by the downstream parsing code.

 span = ValueSpan;