Uh oh!
There was an error while loading. Please reload this page.
[clr-interp] Implement missing support for startup path - #118404
Conversation
…pport for CPBLK operation in interpreter; Special-case RuntimeHandle constructors
There was a problem hiding this comment.
Pull Request Overview
This PR implements missing support for interpreting methods on the startup path by adding CPBLK instruction support, refactoring string allocation to use native-sized integers, and handling special constructor cases for runtime handle types.
Key changes:
- Adds CPBLK (copy block) instruction implementation to the interpreter
- Changes string allocation methods from
inttonintfor length parameters - Special-cases constructors for RuntimeMethodHandle, RuntimeFieldHandle, and RuntimeArgumentHandle to use value-type semantics
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/vm/interpexec.cpp | Implements CPBLK instruction execution using memcpy |
| src/coreclr/interpreter/intops.def | Defines CPBLK instruction metadata |
| src/coreclr/interpreter/compiler.cpp | Adds CPBLK compilation support and special constructor handling |
| src/coreclr/System.Private.CoreLib/src/System/String.CoreCLR.cs | Changes string allocation length parameter from int to nint |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…th memcpyNoGCRefs for null reference safety
janvorli
commented
Aug 6, 2025
/ba-g The System.Net.WebSockets.Client.Tests.CancelTest_SharedHandler_Loopback.ConnectAsync_Cancel_ThrowsCancellationException test failure is unrelated and happens because of a timeout. |
Description
This PR includes several improvements to support interpreting methods on startup path:
Contributes to #117556