[clr-interp] Intrinic handling for Delegate Invoke methods by davidwrighton · Pull Request #118406 · dotnet/runtime

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

davidwrighton · 2025-08-05T18:47:09Z

Add a new opcode
Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

Copilot

Pull Request Overview

This PR implements intrinsic handling for delegate Invoke methods in the CoreCLR interpreter by introducing a specialized execution path for delegate invocations. The changes optimize delegate calls by avoiding generic method dispatch overhead.

Key changes:

Adds a new INTOP_CALLDELEGATE opcode specifically for delegate invoke operations
Implements InvokeDelegateInvokeMethod function that handles delegate-specific invocation logic
Updates the compiler to detect and emit the new opcode for delegate invoke methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/interpexec.cpp	Adds `InvokeDelegateInvokeMethod` function and `INTOP_CALLDELEGATE` case handler
src/coreclr/interpreter/intops.def	Defines the new `INTOP_CALLDELEGATE` opcode
src/coreclr/interpreter/compiler.cpp	Updates compiler to detect delegate invoke methods and emit the new opcode

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…dwrighton/runtime into MakeDelegateInvokeIntrinsic

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli

LGTM, thank you!

jkotas · 2025-08-06T15:49:07Z

Test failure looks related to the PR:

System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests()

[Interpreter] Intrinic handling for Delegate Invoke methods
3958506
- Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use

CopilotAI review requested due to automatic review settings August 5, 2025 18:47

davidwrighton requested review from BrzVlad, janvorli and kg as code owners August 5, 2025 18:47

github-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 5, 2025

davidwrighton added area-CodeGen-Interpreter-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 5, 2025

CopilotAI reviewed Aug 5, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/interpexec.cpp Outdated

Update src/coreclr/vm/interpexec.cpp
0b110cf
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dotnet-policy-serviceBot assigned davidwrighton Aug 5, 2025

kg reviewed Aug 5, 2025
View reviewed changes

Comment threadsrc/coreclr/interpreter/compiler.cpp

davidwrighton changed the title ~~[Interpreter] Intrinic handling for Delegate Invoke methods~~[clr-interp] Intrinic handling for Delegate Invoke methodsAug 5, 2025

kg approved these changes Aug 5, 2025
View reviewed changes

jkotas reviewed Aug 5, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/interpexec.cpp Outdated

davidwrighton added 2 commits August 5, 2025 13:25

Refactor slow path out of function, and make wasm build
232dee5

Merge branch 'MakeDelegateInvokeIntrinsic' ofhttps://github.com/davi…
5966d1e
…dwrighton/runtime into MakeDelegateInvokeIntrinsic

jkotas reviewed Aug 5, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/interpexec.cpp Outdated

Update src/coreclr/vm/interpexec.cpp
e04e978
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

janvorli approved these changes Aug 5, 2025
View reviewed changes

kotlarmilos mentioned this pull request Aug 6, 2025
CoreCLR Interpreter - ensure the whole startup path can run interpreted #117556
Closed
12 tasks

BrzVlad approved these changes Aug 6, 2025
View reviewed changes

Merge branch 'main' into MakeDelegateInvokeIntrinsic
5d5ebc9

davidwrighton merged commit 5c5ed27 into dotnet:mainAug 7, 2025
90 of 92 checks passed

build-analysisBot mentioned this pull request Aug 7, 2025
[android] System.Net.Http.Functional.Tests failure with TimeoutException #118118
Closed

github-actionsBot locked and limited conversation to collaborators Sep 7, 2025