Remove redundant #if NET directives from .NET-only files

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue

[Copilot]

This PR removes redundant #if NET conditional compilation directives from files that are only compiled in .NET builds, making the code cleaner and more maintainable.

Files Changed

Exception Classes (aspnetcore shared folder):

• HuffmanDecodingException.cs - removed 3 redundant #if NET blocks around [Obsolete] attributes
• QPackEncodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute
• QPackDecodingException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

Network Exception Class:

• NetworkInformationException.cs - removed 1 redundant #if NET block around [Obsolete] attribute

.NET-Only Reference Files:

• System.Text.Json.netcoreapp.cs - removed 1 redundant #if NET block around Int128/UInt128 converter properties
• System.Security.Permissions.netcoreapp.cs - removed 1 redundant #if NET block around XamlLoadPermission obsolete attribute

Rationale

These files are only included in .NET builds where the NET symbol is always defined:

• The aspnetcore HTTP exception classes only target $(NetCoreAppCurrent) and its platform-specific variants
• NetworkInformationException.cs is in Common folder but only used in .NET-only contexts
• .netcoreapp.cs files are conditionally included only when '$(TargetFrameworkIdentifier)' == '.NETCoreApp'

Since the NET symbol is always defined in these build contexts, the #if NET conditionals are always true and therefore redundant.

Testing

• Built affected libraries successfully for net10.0
• All [Obsolete] attributes and properties are now always applied as intended
• No functional changes - only removes unnecessary conditional compilation

Fixes#118421.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[jkotas]

LGTM

[Copilot]

Pull Request Overview

This PR removes redundant #if NET conditional compilation directives from exception classes that are only compiled in .NET builds, making the code cleaner and more maintainable.

• Removed #if NET blocks around [Obsolete] attributes for legacy serialization methods
• Changes affect 4 exception classes in HTTP and network libraries
• No functional changes - the [Obsolete] attributes are now always applied as intended

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
NetworkInformationException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackEncodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
QPackDecodingException.cs	Removed 1 redundant #if NET block around obsolete serialization constructor
HuffmanDecodingException.cs	Removed 3 redundant #if NET blocks around obsolete serialization constructor and GetObjectData methods

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[xtqqczze]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[jkotas]

@xtqqczze Copilot won't listed to external contributors.

[jkotas]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessary uses of the NET symbol, including inverse conditions such as #if !NET and other conditional forms.

[Copilot]

@copilot Your analysis currently focuses on instances of the "#if NET" pattern. To ensure a more comprehensive evaluation, consider generalizing your search logic to detect all redundant or unnecessar...

Expanded the search beyond #if NET patterns as requested. Found and removed redundant NET symbol usage in two additional .NET-only files:

• System.Text.Json.netcoreapp.cs - removed #if NET around Int128/UInt128 converters
• System.Security.Permissions.netcoreapp.cs - removed #if NET around XamlLoadPermission obsolete attribute

These .netcoreapp.cs files are only compiled for .NETCoreApp targets where the NET symbol is always defined, making the conditionals redundant. Both files build successfully after the changes.

Commit: 3db9939

.

[jkotas]

/ba-g intermittent network issue