Uh oh!
There was an error while loading. Please reload this page.
Update to zlib-ng 2.2.5 - #118457
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the zlib-ng library from version 2.2.4 to 2.2.5, marking this as a trial of an upstream pull request with the goal of getting test coverage. The update includes version string updates, build system improvements, and performance optimizations particularly for x86 and RISC-V architectures.
Key changes include:
- Version number updates across multiple files and build configurations
- Improvements to x86 feature detection and AVX512VNNI intrinsics handling
- Enhanced RISC-V architecture support with new toolchain configurations
- Build system refinements including additional compiler flag checks for Apple platforms
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/native/external/zlib-ng/zutil.c | Updates version string from 2.2.4 to 2.2.5 |
| src/native/external/zlib-ng/zlib.pc.in | Adds bindir variable to pkg-config template |
| src/native/external/zlib-ng/zlib.pc.cmakein | Adds bindir variable to CMake pkg-config template |
| src/native/external/zlib-ng/zlib.h.in | Updates version constants and macros to 2.2.5 |
| src/native/external/zlib-ng/zlib-ng.h.in | Updates version constants and macros to 2.2.5 |
| src/native/external/zlib-ng/deflate_medium.c | Optimizes match insertion logic and hash table management |
| src/native/external/zlib-ng/deflate.h | Updates comment about max_insert_length usage |
| src/native/external/zlib-ng/configure | Adds RISC-V support and additional compiler flag checks |
| src/native/external/zlib-ng/cmake/toolchain-riscv.cmake | Simplifies RISC-V toolchain configuration |
| src/native/external/zlib-ng/cmake/toolchain-riscv-clang.cmake | Adds new RISC-V Clang toolchain configuration |
| src/native/external/zlib-ng/cmake/detect-intrinsics.cmake | Improves AVX512VNNI intrinsics test robustness |
| src/native/external/zlib-ng/cmake/detect-arch.cmake | Removes redundant enable_language(C) call |
| src/native/external/zlib-ng/arch/x86/x86_functions.h | Minor formatting and comment improvements |
| src/native/external/zlib-ng/arch/x86/x86_features.c | Reorders feature detection logic and improves comments |
| src/native/external/zlib-ng/arch/x86/chunkset_avx512.c | Adds MSVC compiler workaround for optimization bug |
| src/native/external/zlib-ng/arch/s390/s390_functions.h | Fixes macro definition syntax error |
| src/native/external/zlib-ng/arch/riscv/chunkset_rvv.c | Adds safety check for negative distance values |
| src/native/external/zlib-ng/arch/riscv/Makefile.in | Adds complete RISC-V architecture Makefile |
| src/native/external/zlib-ng/Makefile.in | Updates version number in main Makefile |
| src/native/external/zlib-ng/CMakeLists.txt | Improves C++ language enablement and adds Apple-specific compiler flags |
| src/native/external/zlib-ng/.gitignore | Adds test data directories to ignore list |
| src/native/external/zlib-ng-version.txt | Updates version reference and upstream URL |
Uh oh!
There was an error while loading. Please reload this page.
risc-vv
commented
Aug 6, 2025
@dotnet/samsung Could you please take a look? These changes may be related to riscv64. |
ericstj
commented
Aug 6, 2025
MemberAuthor
I've confirmed this fixes the performance regression in highly compressible data that we reported.
https://gist.github.com/ericstj/5655e50ef8c3daf22b432ee9c2d6ce56 |
ericstj
commented
Aug 6, 2025
MemberAuthor
@MihuBot benchmark System.IO.Compression |
ericstj
commented
Aug 6, 2025
MemberAuthor
The dotnet/performance benchmark results look mostly a wash to me - which is to be expected since those didn't catch the original regression (due to small payload sizes). |
MihaZupan
commented
Aug 6, 2025
Member
For the test mentioned in dotnet/performance#4900: MihuBot/runtime-utils#1362
|
ericstj
enabled auto-merge (squash)
August 7, 2025 20:38
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: 8/7/2025 -- this is now ready to merge as zlib-ng published the release https://github.com/zlib-ng/zlib-ng/releases/tag/2.2.5
This is a trial of zlib-ng/zlib-ng#1943 with the goal of getting test coverage. We should update with final hash/tag once it's merged.We should see if we can get performance results on this.