Skip to content

[mono][debugger] Fix assertion when stepping - #118458

Merged
thaystg merged 2 commits into
dotnet:mainfrom
thaystg:dev/thays/fix_110016
Aug 6, 2025
Merged

[mono][debugger] Fix assertion when stepping#118458
thaystg merged 2 commits into
dotnet:mainfrom
thaystg:dev/thays/fix_110016

Conversation

@thaystg

@thaystgthaystg commented Aug 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Using the same logic used on amd64.
Fixes#110016

CopilotAI review requested due to automatic review settings August 6, 2025 16:46
CopilotAI reviewed Aug 6, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes assertion failures when stepping in the Mono debugger on ARM64 by aligning the breakpoint address calculation logic with the AMD64 implementation. The changes remove the division by 4 that was causing incorrect indexing into the breakpoint addresses array.

  • Removes division by 4 from the breakpoint trampoline offset calculation
  • Updates array indexing to use native_offset directly instead of native_offset/4
  • Eliminates assertions that required 4-byte alignment

Comment threadsrc/mono/mono/mini/mini-arm64.c Outdated
@dotnet-policy-service

dotnet-policy-serviceBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@thaystg

thaystg commented Aug 6, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to release/9.0-staging

@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/16783124435

@github-actionsgithub-actionsBot mentioned this pull request Aug 6, 2025
Merged
4 tasks
steveisok
steveisok approved these changes Aug 6, 2025
View reviewed changes

@steveisoksteveisok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build-analysisbuild-analysisBot mentioned this pull request Aug 6, 2025
Closed
@thaystg

thaystg commented Aug 6, 2025

Copy link
Copy Markdown
MemberAuthor

/ba-g unrelated failure

@thaystg
thaystg merged commit 4da283c into dotnet:mainAug 6, 2025
62 of 65 checks passed
@BrzVladBrzVlad mentioned this pull request Aug 8, 2025
Merged
@BrzVlad

BrzVlad commented Aug 8, 2025

Copy link
Copy Markdown
Member

@thaystg I don't really understand why the code offset would ever not be 4 byte aligned. I thought all arm64 instructions are 4 bytes ?

steveisok pushed a commit that referenced this pull request Aug 8, 2025
@BrzVlad
[mono][arm64] Fix SeqPointInfo allocation (#118542)
ee4be3d
`bp_addrs` now needs to contain a pointer slot for every single byte in the code.
Regressed after #118458Fixes#118519
@kotlarmiloskotlarmilos mentioned this pull request Aug 11, 2025
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Sep 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas is a code owner
@lateralusXlateralusXAwaiting requested review from lateralusX

Assignees

@thaystgthaystg

Labels

area-Codegen-JIT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion when stepping over breakpoint

4 participants

@thaystg@BrzVlad@steveisok