[clr-interp] Handle some forms of unboxing stub by davidwrighton · Pull Request #118501 · dotnet/runtime

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

davidwrighton · 2025-08-07T21:57:16Z

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

This is probably not the long term fix here, as it won't work for WASM scenarios, but it should be good enough for now as we bring up the interpreter on non WASM workloads

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Copilot

Pull Request Overview

This PR addresses execution of unboxing stubs in the CLR interpreter by ensuring they are invoked as compiled methods rather than interpreted ones. This is a temporary solution for non-WASM workloads while the interpreter is being developed.

Modifies the condition in InterpExecMethod to exclude unboxing stubs from interpreter preparation
Adds a check for IsUnboxingStub() to prevent unboxing stubs from being prepared as interpreted code

janvorli

LGTM, thank you!

[clr-interp] Handle some forms of unboxing stub
3504d51
When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

CopilotAI review requested due to automatic review settings August 7, 2025 21:57

davidwrighton requested review from BrzVlad, janvorli and kg as code owners August 7, 2025 21:57

github-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 7, 2025

dotnet-policy-serviceBot assigned davidwrighton Aug 7, 2025

CopilotAI reviewed Aug 7, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/interpexec.cpp

janvorli approved these changes Aug 7, 2025
View reviewed changes

davidwrighton enabled auto-merge (squash) August 8, 2025 01:11

davidwrighton merged commit d61ca90 into dotnet:mainAug 8, 2025
93 checks passed

github-actionsBot locked and limited conversation to collaborators Sep 7, 2025

pavelsavara added the arch-wasm WebAssembly architecture label Jun 16, 2026