[clr-interp] Fix INTOP_CGT_UN_I8 - #118511

Merged
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:more_interpreter_fixes_3
Aug 8, 2025
Merged

[clr-interp] Fix INTOP_CGT_UN_I8#118511
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:more_interpreter_fixes_3

Conversation

@davidwrighton

@davidwrightondavidwrighton commented Aug 8, 2025

Copy link
Copy Markdown
Member

It was treating its inputs as 4 byte integers instead of 8 byte integers

@davidwrighton
[clr-interp] Fix INTOP_CGT_UN_I8
b3b9a44
It was treating its inputs as 4 byte integers instead of 8 byte integers
CopilotAI review requested due to automatic review settings August 8, 2025 00:56
CopilotAI reviewed Aug 8, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the CLR interpreter where the INTOP_CGT_UN_I8 operation was incorrectly treating 8-byte integer inputs as 4-byte integers, causing incorrect comparison results.

Key Changes

  • Corrected the data types in the unsigned 8-byte integer comparison operation from uint32_t to uint64_t

Comment threadsrc/coreclr/vm/interpexec.cpp
@dotnet-policy-service

dotnet-policy-serviceBot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@davidwrighton
davidwrighton enabled auto-merge (squash) August 8, 2025 01:11
@davidwrighton
davidwrighton merged commit 4bbd32d into dotnet:mainAug 8, 2025
93 checks passed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Sep 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@kgkgAwaiting requested review from kg

Assignees

@davidwrightondavidwrighton

Labels

area-Interop-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidwrighton@jkoritzinsky@AaronRobinsonMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); })();
Skip to content

[clr-interp] Fix INTOP_CGT_UN_I8 - #118511

Merged
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:more_interpreter_fixes_3
Aug 8, 2025
Merged

[clr-interp] Fix INTOP_CGT_UN_I8#118511
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:more_interpreter_fixes_3

Conversation

@davidwrighton

@davidwrightondavidwrighton commented Aug 8, 2025

Copy link
Copy Markdown
Member

It was treating its inputs as 4 byte integers instead of 8 byte integers

@davidwrighton
[clr-interp] Fix INTOP_CGT_UN_I8
b3b9a44
It was treating its inputs as 4 byte integers instead of 8 byte integers
CopilotAI review requested due to automatic review settings August 8, 2025 00:56
CopilotAI reviewed Aug 8, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the CLR interpreter where the INTOP_CGT_UN_I8 operation was incorrectly treating 8-byte integer inputs as 4-byte integers, causing incorrect comparison results.

Key Changes

  • Corrected the data types in the unsigned 8-byte integer comparison operation from uint32_t to uint64_t

Comment threadsrc/coreclr/vm/interpexec.cpp
@dotnet-policy-service

dotnet-policy-serviceBot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@davidwrighton
davidwrighton enabled auto-merge (squash) August 8, 2025 01:11
@davidwrighton
davidwrighton merged commit 4bbd32d into dotnet:mainAug 8, 2025
93 checks passed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Sep 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@janvorlijanvorliAwaiting requested review from janvorlijanvorli is a code owner
@kgkgAwaiting requested review from kg

Assignees

@davidwrightondavidwrighton

Labels

area-Interop-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidwrighton@jkoritzinsky@AaronRobinsonMSFT