Uh oh!
There was an error while loading. Please reload this page.
Adding GetILForModule cDAC API - #118546
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the GetILForModule cDAC API, which retrieves the address of IL (Intermediate Language) code for a given module and relative virtual address (RVA). The implementation replaces a placeholder that delegated to legacy code with a full cDAC-based solution.
Key changes:
- Adds complete implementation of
GetILForModulein SOSDacImpl with proper parameter validation and error handling - Introduces new
GetILAddrmethod in the ILoader contract to calculate IL addresses from PE assembly data - Includes DEBUG-only verification against legacy implementation to ensure compatibility
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SOSDacImpl.cs | Replaces placeholder with full GetILForModule implementation including validation, error handling, and debug verification |
| Loader_1.cs | Implements GetILAddr method to calculate IL addresses by traversing PE assembly, image, and layout structures |
| ILoader.cs | Adds GetILAddr method signature to the ILoader contract interface |
Uh oh!
There was an error while loading. Please reload this page.
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
jkotas
commented
Aug 8, 2025
That's only true on Windows for files loaded from disk. IsMapped is typically false on non-Windows for non-R2R binaries. Also, it is likely false for binaries loaded from memory (e.g. using |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jkotas
commented
Aug 14, 2025
Test build break, LGTM otherwise |
Uh oh!
There was an error while loading. Please reload this page.
…er/ContractDescriptorTarget.cs Co-authored-by: Max Charlamb <44248479+max-charlamb@users.noreply.github.com>
max-charlamb
left a comment
There was a problem hiding this comment.
lgtm except for a couple of small comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
A couple comments on this one: