Skip to content

Adding GetMethodDescFromToken cDAC API - #118619

Merged
rcj1 merged 2 commits into
dotnet:mainfrom
rcj1:GetMethodDescFromToken
Aug 19, 2025
Merged

Adding GetMethodDescFromToken cDAC API#118619
rcj1 merged 2 commits into
dotnet:mainfrom
rcj1:GetMethodDescFromToken

Conversation

@rcj1

@rcj1rcj1 commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@rcj1
rcj1 requested review from Copilot and max-charlamb and removed request for CopilotAugust 12, 2025 00:49
@dotnet-policy-service

dotnet-policy-serviceBot commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@rcj1rcj1 mentioned this pull request Aug 12, 2025
Closed
32 tasks
@rcj1

rcj1 commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

SOS failing tests are EnumMethodInstanceByAddress and DrainQueue related

max-charlamb
max-charlamb reviewed Aug 13, 2025
View reviewed changes
Comment threadsrc/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs Outdated
CopilotAI review requested due to automatic review settings August 13, 2025 23:23
CopilotAI reviewed Aug 13, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the GetMethodDescFromToken method in the cDAC (Contract Data Access Component) API to retrieve method descriptors from metadata tokens. This replaces the previous implementation that simply delegated to the legacy DAC implementation.

  • Adds a new CorTokenType enum to define metadata token types and their bitmasks
  • Implements the core logic to handle different token types (FieldDef, MethodDef, TypeDef, TypeRef) using the loader contract
  • Includes debug validation to compare results with the legacy implementation

Comment threadsrc/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
Comment threadsrc/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
Comment threadsrc/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
max-charlamb
max-charlamb approved these changes Aug 19, 2025
View reviewed changes

@max-charlambmax-charlamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rcj1
rcj1 merged commit e6d984a into dotnet:mainAug 19, 2025
41 of 43 checks passed
@rcj1
rcj1 deleted the GetMethodDescFromToken branch August 19, 2025 21:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Sep 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalknoahfalknoahfalk left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@max-charlambmax-charlambmax-charlamb approved these changes

Assignees

@rcj1rcj1

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk@max-charlamb