Skip to content

Disable tests parallelization in flaky OleDB tests - #119018

Merged
roji merged 1 commit into
dotnet:mainfrom
roji:OleDbTestHangs
Aug 28, 2025
Merged

Disable tests parallelization in flaky OleDB tests#119018
roji merged 1 commit into
dotnet:mainfrom
roji:OleDbTestHangs

Conversation

@roji

@rojiroji commented Aug 22, 2025

Copy link
Copy Markdown
Member

There's reason to believe that the flakiness in #87783 is caused by concurrency issues in the ACE/Access OleDB driver being used (e.g. here). So as an easy attempt to get rid of the flakiness, I'm disabling parallelization altogether in these tests. I suggest we merge this and observe what happens in the next few days/weeks.

If this doesn't fix the flakiness, we should move away from ACE to SQL Server / LocalDB. There's a good chance we'd need to install components on the runner image though, so we'd probably want to skip the tests until that happens.

@jeffschwMSFT@jeffhandley@SamMonoRT

@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 22, 2025
@rojiroji added area-System.Data.OleDB and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 22, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @roji, @SamMonoRT
See info in area-owners.md if you want to be subscribed.

@roji
rojiforce-pushed the OleDbTestHangs branch 2 times, most recently from fb60001 to 963fc33CompareAugust 23, 2025 07:27
@roji
roji marked this pull request as ready for review August 23, 2025 07:32
CopilotAI review requested due to automatic review settings August 23, 2025 07:32

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses flaky OleDB tests by disabling test parallelization to work around concurrency issues in the ACE/Access OleDB driver.

  • Adds an AssemblyInfo.cs file to disable test parallelization for the OleDB test suite
  • Implements a temporary workaround for known concurrency issues in the Microsoft ACE OleDB driver

@roji

roji commented Aug 28, 2025

Copy link
Copy Markdown
MemberAuthor

@jeffschwMSFT@jeffhandley@SamMonoRT ping - this is a tiny PR that may solve the OleDB test flakiness that's been plaguing us, would be great to get it in (I'll backport to release/10.0). If this doesn't solve the problem I'll continue to look further.

@roji
roji merged commit 3d86284 into dotnet:mainAug 28, 2025
87 of 89 checks passed
@roji
roji deleted the OleDbTestHangs branch August 28, 2025 21:04
@SamMonoRT

Copy link
Copy Markdown
Member

@jeffschwMSFT@jeffhandley@SamMonoRT ping - this is a tiny PR that may solve the OleDB test flakiness that's been plaguing us, would be great to get it in (I'll backport to release/10.0). If this doesn't solve the problem I'll continue to look further.

@roji - did we ever submit a backport PR - The RC2 window is closing, making sure we get that in time.

@roji

roji commented Sep 12, 2025

Copy link
Copy Markdown
MemberAuthor

@SamMonoRT nope - good point. Am noting that this is a test-only fix, but I agree it's a good idea to backport to make previous version builds more stable too.

@roji

roji commented Sep 12, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17666435697

@roji

roji commented Sep 12, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/17666442938

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@roji@SamMonoRT