') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Disable UnhandledExceptionHandler tests with native components on `llvmfullaot` by VSadov · Pull Request #119039 · dotnet/runtime · GitHub
Skip to content

Disable UnhandledExceptionHandler tests with native components on llvmfullaot - #119039

Merged
VSadov merged 1 commit into
dotnet:mainfrom
VSadov:unhLLVM
Aug 25, 2025
Merged

Disable UnhandledExceptionHandler tests with native components on llvmfullaot#119039
VSadov merged 1 commit into
dotnet:mainfrom
VSadov:unhLLVM

Conversation

@VSadov

@VSadovVSadov commented Aug 24, 2025

Copy link
Copy Markdown
Member

Fixes: #118981

These tests load a native .dll/.so , which starts threads, enters the runtime, runs managed code, throws unhandled exceptions...

We have other similar tests. They are marked as incompatible with llvmfullaot.
I guess, these should be marked incompatible as well.

@VSadov
Disable UnhandledExceptionHandler tests with foreign threads on `llvm…
faad284
…fullaot`
These kind of tests are not compatible.
@VSadovVSadov added the disabled-test The test is disabled in source code against the issue label Aug 24, 2025
CopilotAI review requested due to automatic review settings August 24, 2025 00:54
@VSadovVSadov added area-VM-meta-mono runtime-mono specific to the Mono runtime labels Aug 24, 2025
CopilotAI reviewed Aug 24, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables UnhandledExceptionHandler tests with native components on llvmfullaot runtime to address compatibility issues. The tests involve loading native libraries that interact with the runtime in ways that cause problems with LLVM full AOT compilation.

  • Adds exclusion rules for UnhandledExceptionHandler tests in Foreign and PInvoke subdirectories
  • Follows existing pattern used for similar tests that have native component interactions

@build-analysisbuild-analysisBot mentioned this pull request Aug 24, 2025
Closed
3 tasks
@VSadov
VSadov requested a review from steveisokAugust 24, 2025 04:25
@VSadov

VSadov commented Aug 25, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks!!

@VSadov
VSadov merged commit d258af5 into dotnet:mainAug 25, 2025
79 checks passed
@VSadov
VSadov deleted the unhLLVM branch August 25, 2025 01:19
VSadov added a commit that referenced this pull request Aug 25, 2025
@VSadov
Disable UnhandledExceptionHandler tests with foreign threads on `llvm…
3b637f0
…fullaot` (#119039)
These kind of tests are not compatible.
VSadov added a commit that referenced this pull request Aug 26, 2025
@VSadov
Disable UnhandledExceptionHandler tests with foreign threads on `llvm…
6bd4976
…fullaot` (#119039)
These kind of tests are not compatible.
VSadov added a commit that referenced this pull request Aug 28, 2025
@VSadov
Disable UnhandledExceptionHandler tests with foreign threads on `llvm…
1856d3d
…fullaot` (#119039)
These kind of tests are not compatible.
VSadov added a commit that referenced this pull request Aug 28, 2025
@VSadov
Disable UnhandledExceptionHandler tests with foreign threads on `llvm…
1ed52da
…fullaot` (#119039)
These kind of tests are not compatible.
jeffschwMSFT pushed a commit that referenced this pull request Aug 29, 2025
@github-actions@VSadov
[release/10.0] Implement UnhandledException hook for finalizer scenar…
39349e8
…io in Mono. (#118878)
* Implement UnhandledException hook for finalizers in Mono.
* Cache the finalize method on wasm
* Precompile invoke helper for GuardedFinalize
* only check for GuardedFinalize in corlib
* make GuardedFinalize virtual
* use mono_runtime_try_invoke, since we can wih instance methods
* comment out unused
* Move GuardedFinalize to a helper class
* make it static
* some cleanup
* remove no longer relevant comment
* Disable UnhandledExceptionHandler tests with foreign threads on `llvmfullaot` (#119039)
These kind of tests are not compatible.
---------
Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
Co-authored-by: Vladimir Sadov <vsadov@microsoft.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Sep 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@steveisoksteveisoksteveisok approved these changes

Assignees

@VSadovVSadov

Labels

area-VM-meta-monodisabled-testThe test is disabled in source code against the issueruntime-monospecific to the Mono runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[linux][x64][mono][aot] Test fails - baseservices/exceptions/UnhandledExceptionHandler/Foreign/ForeignUnhandled/ForeignUnhandled.cmd

3 participants

@VSadov@steveisok