Skip to content

[HTTP] Stress fix for docker compose - #119274

Merged
ManickaP merged 2 commits into
mainfrom
dev/mapichov/httpstress
Sep 4, 2025
Merged

[HTTP] Stress fix for docker compose#119274
ManickaP merged 2 commits into
mainfrom
dev/mapichov/httpstress

Conversation

@ManickaP

Copy link
Copy Markdown
Member

CopilotAI review requested due to automatic review settings September 2, 2025 14:59
@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 2, 2025
@ManickaP

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dotnetdotnet deleted a comment from azure-pipelinesBotSep 2, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a Docker Compose cleanup issue in the HTTP stress test pipeline by adding explicit docker-compose down commands after each stress test run. The change ensures proper resource cleanup between individual HTTP protocol version tests (3.0, 2.0, and 1.1) to prevent conflicts and failures in subsequent test runs.

Key changes:

  • Added docker-compose down command after each HTTP stress test execution
  • Applied consistently across all three HTTP protocol version tests (3.0, 2.0, 1.1)

@ManickaPManickaP added area-System.Net.Http and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 2, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-libraries stress-http

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
ManickaP requested a review from a teamSeptember 3, 2025 14:57
@ManickaP

Copy link
Copy Markdown
MemberAuthor

Http stress is green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1138189&view=results
@dotnet/ncl please another quick review here.

The fix is based on the second answer here: https://askubuntu.com/questions/1508129/docker-compose-giving-containerconfig-errors-after-update-today as we don't have docker compose in the images yet.

@ManickaP
ManickaP merged commit 4c301c7 into mainSep 4, 2025
89 checks passed
@ManickaP
ManickaP deleted the dev/mapichov/httpstress branch September 4, 2025 21:29
@ManickaP

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/17544665607

@ManickaP

Copy link
Copy Markdown
MemberAuthor

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17544677561

@ManickaP

Copy link
Copy Markdown
MemberAuthor

/backport to release/10.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17544683950

@github-actions

Copy link
Copy Markdown
Contributor

@ManickaP backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Wind down docker compose between individual runs in HTTP stress
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
Applying: Experiment 2
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/stress/http.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Experiment 2
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions

Copy link
Copy Markdown
Contributor

@ManickaP backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Wind down docker compose between individual runs in HTTP stress
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
Applying: Experiment 2
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/stress/http.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Experiment 2
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

ManickaP added a commit that referenced this pull request Sep 8, 2025
Backport of #119274 to release/10.0
/cc @ManickaP
## Customer Impact
- [ ] Customer reported
- [x] Found internally
Wind down docker compose between individual runs in HTTP stress.
## Regression
- [x] Yes
- [ ] No
Infra update.
## Testing
CI stress runs.
## Risk
Low. Test only change.
ManickaP added a commit that referenced this pull request Sep 8, 2025
Backport of #119274 to release/10.0
/cc @ManickaP
## Customer Impact
- [ ] Customer reported
- [x] Found internally
Wind down docker compose between individual runs in HTTP stress.
## Regression
- [x] Yes
- [ ] No
Infra update.
## Testing
CI stress runs.
## Risk
Low. Test only change.
ManickaP added a commit that referenced this pull request Sep 9, 2025
* [HTTP] Stress fix for docker compose
Backport of #119274 to release/10.0
/cc @ManickaP
## Customer Impact
- [ ] Customer reported
- [x] Found internally
Wind down docker compose between individual runs in HTTP stress.
## Regression
- [x] Yes
- [ ] No
Infra update.
## Testing
CI stress runs.
## Risk
Low. Test only change.
* Remove unnecessary docker-compose down commands
Removed 'docker-compose down' command from HTTP 1.1 and 2.0 stress test configurations.
ManickaP added a commit that referenced this pull request Sep 9, 2025
* [HTTP] Stress fix for docker compose
Backport of #119274 to release/10.0
/cc @ManickaP
## Customer Impact
- [ ] Customer reported
- [x] Found internally
Wind down docker compose between individual runs in HTTP stress.
## Regression
- [x] Yes
- [ ] No
Infra update.
## Testing
CI stress runs.
## Risk
Low. Test only change.
* Add docker-compose down command before up
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Oct 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ManickaP@MihaZupan