Uh oh!
There was an error while loading. Please reload this page.
[9.0] Preserve Lock ID Members - #119281
Merged
jkoritzinsky merged 1 commit intoSep 10, 2025
Merged
Conversation
jkoritzinsky
commented
Sep 2, 2025
MemberAuthor
/backport to release/10.0 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR preserves Lock ID members in the ThreadBlockingInfo class to prevent them from being trimmed during IL linking. These properties are needed by external tooling that depends on these APIs for functionality.
Key Changes
- Adds ILLink descriptor entries for ThreadBlockingInfo Lock ID properties
- Prevents trimming of LockOwnerManagedThreadId and LockOwnerOSThreadId properties
Contributor
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17412174592 |
Contributor
Tagging subscribers to this area: @mangod9 |
1 task
jeffschwMSFT
approved these changes
Sep 2, 2025
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
AaronRobinsonMSFT
approved these changes
Sep 2, 2025
jkoritzinsky
merged commit Sep 10, 2025
df7805b
into
dotnet:release/9.0-staging
152 of 156 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These members were meant to be preserved to enable utilization by other tools.
Customer Impact
Features meant to be built on these properties don't function.
Regression
No
Testing
Local validation with the tooling built on these APIs.
Risk
Low, only preserves members that were otherwise trimmed out.