Fix runtime build when tiered compilation is disabled by kotlarmilos · Pull Request #119355 · dotnet/runtime

kotlarmilos · 2025-09-04T16:34:28Z

Description

This PR ensures that tiered compilation–related logic is compiled only when FEATURE_TIERED_COMPILATION is enabled. Several components like DAC variables, vtable pointer lists, assembly constants, thunk templates, and event tracing unconditionally referenced these stubs. On builds without tiered compilation, this resulted in runtime build errors.

This change fixes CoreCLR builds for Apple mobile.

Copilot

Pull Request Overview

This PR fixes runtime build errors that occur when tiered compilation is disabled by properly wrapping tiered compilation-related code with FEATURE_TIERED_COMPILATION guards. The changes ensure that code referencing tiered compilation stubs and data structures is only compiled when the feature is enabled.

Key Changes

Added conditional compilation guards around call counting stub definitions and references
Fixed incorrect feature flags for on-stack replacement code sections
Protected tiered compilation ETW event tracing code

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/vm/riscv64/asmhelpers.S	Fixed feature guards for patchpoint stubs
src/coreclr/vm/riscv64/asmconstants.h	Added guards around call counting stub constants
src/coreclr/vm/loongarch64/thunktemplates.S	Protected call counting stub template
src/coreclr/vm/loongarch64/asmhelpers.S	Fixed feature guards for patchpoint stubs
src/coreclr/vm/loongarch64/asmconstants.h	Added guards around call counting stub constants
src/coreclr/vm/i386/thunktemplates.S	Protected call counting stub template
src/coreclr/vm/i386/asmconstants.h	Added guards around call counting stub constants
src/coreclr/vm/eventtrace.cpp	Protected tiered compilation ETW events
src/coreclr/vm/arm64/thunktemplates.S	Protected call counting stub templates
src/coreclr/vm/arm64/asmhelpers.S	Fixed feature guards for patchpoint stubs
src/coreclr/vm/arm64/asmconstants.h	Added guards around call counting stub constants
src/coreclr/vm/arm/asmconstants.h	Added guards around call counting stub constants
src/coreclr/vm/amd64/thunktemplates.S	Protected call counting stub template
src/coreclr/vm/amd64/asmconstants.h	Added guards around call counting stub constants
src/coreclr/inc/vptr_list.h	Protected call counting stub manager declaration
src/coreclr/inc/dacvars.h	Protected call counting stub manager DAC variable
src/coreclr/debug/daccess/dacdbiimpl.cpp	Fixed assignment to boolean pointer

dotnet-policy-service · 2025-09-04T16:35:28Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

kotlarmilos · 2025-09-04T20:16:26Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-04T20:16:38Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2025-09-04T22:00:23Z

/azp run runtime-extra-platforms

kotlarmilos · 2025-09-04T22:01:06Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-04T22:01:26Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Aaron Robinson <arobins@microsoft.com>

kotlarmilos · 2025-09-22T10:53:04Z

/azp run runtime-extra-platforms

azure-pipelines · 2025-09-22T10:53:16Z

Azure Pipelines successfully started running 1 pipeline(s).

AaronRobinsonMSFT

LGTM. I'd like to see #119355 (comment) applied before merge.

…tlarmilos/runtime into improvement/clr-interp-build-features

Fix build when tiered compilation is disabled
a9ca220

CopilotAI review requested due to automatic review settings September 4, 2025 16:34

github-actionsBot added the area-VM-coreclr label Sep 4, 2025

Merge branch 'main' into improvement/clr-interp-build-features
e8864e8

dotnet-policy-serviceBot assigned kotlarmilos Sep 4, 2025

kotlarmilos requested a review from janvorli September 4, 2025 16:34

CopilotAI reviewed Sep 4, 2025
View reviewed changes

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp

kotlarmilos added area-TieredCompilation-coreclr and removed area-VM-coreclr labels Sep 4, 2025

kotlarmilos added 2 commits September 4, 2025 22:13

Merge branch 'main' into improvement/clr-interp-build-features
425e2a8

Fix build
eb3ad20

Check for precode in JIT helper indirection
e86025a

This comment was marked as outdated.
Sign in to view

kotlarmilos requested a review from AaronRobinsonMSFT September 4, 2025 22:00

AaronRobinsonMSFT reviewed Sep 4, 2025
View reviewed changes

kotlarmilosand others added 5 commits September 5, 2025 09:26

Update src/coreclr/inc/dacvars.h
ca4e4d6
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Update src/coreclr/inc/vptr_list.h
f8ded3f
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Update src/coreclr/vm/amd64/asmconstants.h
51a2896
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Update src/coreclr/vm/arm/asmconstants.h
6c0315b
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Update src/coreclr/vm/arm64/asmconstants.h
dbb63c6
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

kotlarmilosand others added 4 commits September 5, 2025 09:27

Update src/coreclr/vm/eventtrace.cpp
304332a
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Update src/coreclr/vm/i386/asmconstants.h
cab6136
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Update src/coreclr/vm/loongarch64/asmconstants.h
d7a3784
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

Update src/coreclr/vm/riscv64/asmconstants.h
7052a5c
Co-authored-by: Aaron Robinson <arobins@microsoft.com>

kotlarmilos marked this pull request as draft September 6, 2025 05:56

jkotas mentioned this pull request Sep 9, 2025
Empty Main works for corerun on WASM #119448
Merged

kotlarmilos added 2 commits September 22, 2025 12:47

Revert HasPrecode change
2743a0a

Merge branch 'main' into improvement/clr-interp-build-features
e524ccc

build-analysisBot mentioned this pull request Sep 22, 2025
System.Diagnostics.Tests.PerformanceCounterTests.PerformanceCounter_IncrementBy_IncrementByReadOnly failed with "Attempted to perform an unauthorized operation" #116014
Closed

Merge branch 'main' into improvement/clr-interp-build-features
3cd2370

kotlarmilos marked this pull request as ready for review September 22, 2025 13:38

kotlarmilos requested review from AaronRobinsonMSFT and jkotas September 22, 2025 13:38

jkotas reviewed Sep 22, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/arm64/asmhelpers.S

jkotas approved these changes Sep 22, 2025
View reviewed changes

AaronRobinsonMSFT approved these changes Sep 22, 2025
View reviewed changes

kotlarmilos added 3 commits September 23, 2025 11:13

Condition FEATURE_ON_STACK_REPLACEMENT tiered compilation
99a4ded

Merge branch 'improvement/clr-interp-build-features' of github.com:ko…
6f768ad
…tlarmilos/runtime into improvement/clr-interp-build-features

Add comment
aed16ca

kotlarmilos enabled auto-merge (squash) September 23, 2025 09:31

kotlarmilos merged commit a2d130a into dotnet:mainSep 23, 2025
98 checks passed

github-actionsBot locked and limited conversation to collaborators Oct 24, 2025

Uh oh!

Conversation

kotlarmilos commented Sep 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Sep 4, 2025

Uh oh!

kotlarmilos commented Sep 4, 2025

Uh oh!

azure-pipelinesBot commented Sep 4, 2025

Uh oh!

kotlarmilos commented Sep 4, 2025

Uh oh!

This comment was marked as outdated.

kotlarmilos commented Sep 4, 2025

Uh oh!

azure-pipelinesBot commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kotlarmilos commented Sep 22, 2025

Uh oh!

azure-pipelinesBot commented Sep 22, 2025

Uh oh!

Uh oh!

AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kotlarmilos commented Sep 4, 2025•
edited
Loading