Uh oh!
There was an error while loading. Please reload this page.
[release/10.0] [DAC] fix dac_gc_heap marshalling - #119471
Merged
Merged
Conversation
Contributor
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
AaronRobinsonMSFT
approved these changes
Sep 8, 2025
JulieLeeMSFT
left a comment
Member
There was a problem hiding this comment.
LGTM. Please check the pipeline results.
JulieLeeMSFT
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #119393 to release/10.0
/cc @max-charlamb
Customer Impact
Found while working on #119324. Since the
GetGCInterestingInfoDataDAC API marshalled thedac_gc_heapincorrectly, the SOS command!dumpgcdatagives incorrect results on server builds.Regression
Unclear if this ever worked, or if other logic changed causing this to fail at some point.
Testing
Verfied by new test in the diagnostic repo.
See new test: dotnet/diagnostics#5562
See successful run with new test: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1140803&view=results
Risk
Low. This change does not modify the runtime; it only modifies the DAC build.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.