Uh oh!
There was an error while loading. Please reload this page.
[release/10.0] [DAC] Properly dereference internal_root_array - #119496
Merged
Conversation
max-charlamb
requested review from
AaronRobinsonMSFT, noahfalk, rcj1 and steveisokSeptember 11, 2025 20:24
jeffschwMSFT
approved these changes
Sep 14, 2025
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. please get a code review. we can merge when ready
Contributor
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
steveisok
approved these changes
Sep 15, 2025
steveisok
enabled auto-merge (squash)
September 15, 2025 14:08
agocke
disabled auto-merge
September 22, 2025 23:00
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #119396 to release/10.0
/cc @max-charlamb
Customer Impact
Found while working on #119324. Improper dereferencing of a DAC variable leads to
GetHeapAnalyzeStaticDatareturning garbage data. This impacts CLRMD and SOS. In particular the SOS!findrootscommand is broken without this fix on workstation mode GC.Regression
Unknown when introduced.
Testing
Fix was verified by adding a test to the SOS test suite in the diagnostics repo dotnet/diagnostics#5562.
Successful test run with fix: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1143226&view=results
Risk
Low. This change does not modify the runtime, only the DAC build.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.