Move coreclr EH second pass to native code by janvorli · Pull Request #119863 · dotnet/runtime

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli · 2025-09-18T20:04:09Z

There were some GC holes discovered caused by the fact that GC can be triggered during 2nd pass of EH in-between calls to finally handlers and catch handler. After considering options, moving the 2nd pass to native code seems the most reasonable solution.

janvorli · 2025-09-18T20:05:08Z

The current state is that it almost works. A catch handler is correctly invoked, but then something crashes.

Copilot

Pull Request Overview

This PR moves the CoreCLR exception handling second pass from managed to native code to fix GC holes that can occur when GC is triggered between finally handlers and catch handlers during the second pass of exception handling.

Splits existing RhThrowEx/RhThrowHwEx methods into separate first-pass handler finding methods and second-pass execution
Moves the second pass execution logic (DispatchExPass2) from managed to native code
Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet as they're now called directly from native code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/vm/qcallentrypoints.cpp`	Removes QCALL exports for CallCatchFunclet and CallFinallyFunclet
`src/coreclr/vm/metasig.h`	Updates method signatures to include handlingFrameSP and pCatchHandler out parameters
`src/coreclr/vm/exinfo.h`	Adds ContainsCodeOffset helper method to RhEHClause
`src/coreclr/vm/exceptionhandlingqcalls.h`	Removes QCALL declarations for catch/finally funclets
`src/coreclr/vm/exceptionhandling.h`	Adds declaration for new native DispatchExPass2 function
`src/coreclr/vm/exceptionhandling.cpp`	Major refactoring: converts QCALL functions to native, adds new DispatchExPass2 implementation
`src/coreclr/vm/excep.cpp`	Updates managed fault handling to use new method signatures
`src/coreclr/vm/corelib.h`	Updates method name mappings for exception handling entry points
`src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs`	Splits exception handling into separate first/second pass methods

janvorli · 2025-09-18T20:37:23Z

Also, please note that the collided unwind detection is not working yet, as I cannot rely on the pinvokes from the managed EH code anymore. I am working on a fix.
With the contract and EH clauses enumeration fixes based on David's feedback, many EH tests now pass until I hit one with collided unwind. I am reusing the interpreter test ran without interpreter for now.

janvorli · 2025-09-18T22:08:19Z

And one more thing not done yet is rethrow.

* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

dotnet-policy-service · 2025-09-19T00:39:25Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-09-19T15:15:13Z

I am considering reducing the number of changes in the exceptionhandling.cs by a slightly different approach - keeping only the methods we had and adding an extra argument "firstPassOnly" to them. Then if that argument is set to true, in DispatchEx store the handlingFrameSP/PC, _pReversePInvokePropagationCallback/Context and the pCatchHandler into the ExInfo and return;
The native side would then take these from the ExInfo. On NativeAOT, this argument would be ignored.

The current state is that, with some additional changes that I am going to commit after I fix the offsets in StackFrameIterator for some targets, it passes all diagnostics tests and coreclr tests (except ForeignThreadExceptionTest where it ends up messing GC mode when calling managed callback from native code catch)

I also need to add proper contracts here and there.

janvorli · 2025-09-23T18:05:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2025-09-23T18:06:17Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli · 2025-09-23T18:07:43Z

/azp run runtime-coreclr gcstress0x3-gcstress0xc

azure-pipelines · 2025-09-23T18:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

janvorli · 2025-09-24T20:47:43Z

@jkotas, @davidwrighton the current state of this PR is final from my point of view. Can you please review it?

davidwrighton

I believe this is correct and will fix the gc issue. I wish this invariant could be better documented/tested.

janvorli · 2025-09-29T18:03:21Z

/backport to release/10.0

github-actions · 2025-09-29T18:03:31Z

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18106203717

github-actions · 2025-09-29T18:05:18Z

@janvorli backporting to "release/10.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: [WIP] Move coreclr EH second pass to native code
Applying: Several fixes
Applying: Fix arm64 build and remove now useless stuff from stackwalk
Applying: Fix build break
Applying: Fix offsets, exception interception and MUSL build break
Applying: Alternative change with minimalistic managed code differences
error: sha1 information is lacking or useless (src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/AsmOffsets.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0006 Alternative change with minimalistic managed code differences
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

janvorli added this to the 10.0.0 milestone Sep 18, 2025

janvorli requested review from davidwrighton and jkotas September 18, 2025 20:04

janvorli self-assigned this Sep 18, 2025

janvorli requested a review from MichalStrehovsky as a code owner September 18, 2025 20:04

CopilotAI review requested due to automatic review settings September 18, 2025 20:04

janvorli added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-ExceptionHandling-coreclr only use for closed issues labels Sep 18, 2025

CopilotAI reviewed Sep 18, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/exceptionhandling.cpp Outdated
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Comment threadsrc/coreclr/vm/exceptionhandling.cpp

davidwrighton reviewed Sep 18, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/exceptionhandling.cpp Outdated

davidwrighton reviewed Sep 18, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/exceptionhandling.cpp Outdated

SingleAccretion reviewed Sep 18, 2025
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs Outdated

build-analysisBot mentioned this pull request Sep 18, 2025
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922
Open
3 tasks

Several fixes
9a066bf
* Reflect PR feedback * Implement rethrow * Implement new way of collided unwind detection now that the CallCatchFunclet is not called via pinvoke * Remove forced reporting of EH code from stack frame iterator, as we now cannot have that code on the stack during 2nd pass

jkotas added the arch-wasm WebAssembly architecture label Sep 19, 2025

davidwrighton mentioned this pull request Sep 19, 2025
[clr-interp] Add support for a new model of stack handling for funclets in the interpreter #119787
Closed

janvorli added 2 commits September 19, 2025 13:58

Fix arm64 build and remove now useless stuff from stackwalk
cf5d23c

Fix build break
0887cff

jkotas reviewed Sep 19, 2025
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs

This was referenced Sep 19, 2025
Cannot find 'arm64-v8a' device dotnet/dnceng#2284
Closed
LibraryImportGenerator.Unit.Tests crashing on linux-x64 mono interpreter #100800
Open

AndyAyersMS mentioned this pull request Sep 19, 2025
Missing GC live range in a catch handler for a variable unused in the handler #119657
Closed

janvorli added 2 commits September 19, 2025 20:35

Fix offsets, exception interception and MUSL build break
cdfae1a

Alternative change with minimalistic managed code differences
dd51b6d

kg reviewed Sep 22, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/exceptionhandling.cpp Outdated

janvorli added 2 commits September 23, 2025 00:55

Change the GC prevention to single frame only
608b877

Fix one new contract issue
dde85e2

This was referenced Sep 23, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
Unable to pull image from mcr.microsoft.com #117164
Closed

janvorli mentioned this pull request Sep 23, 2025
Fix several issues with interpreter and EH #119784
Merged

Update GC forbid locations
53bcc9a
This is done to ensure that no GC is allowed between the scanned stack range is extended and a funclet for the current frame is called.

jkotas reviewed Sep 24, 2025
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs

kg reviewed Sep 24, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/exceptionhandling.cpp Outdated

davidwrighton reviewed Sep 24, 2025
View reviewed changes

Comment threadsrc/coreclr/vm/exceptionhandling.cpp

build-analysisBot mentioned this pull request Sep 25, 2025
Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173
Open

davidwrighton approved these changes Sep 25, 2025
View reviewed changes

Fix/add comment based on review
280e651

jkotas reviewed Sep 26, 2025
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs

jkotas approved these changes Sep 29, 2025
View reviewed changes

janvorli merged commit bf4802d into dotnet:mainSep 29, 2025
98 checks passed

kg mentioned this pull request Sep 29, 2025
[interp] Disable tests in the interop suite so that it can complete executing #120074
Merged

janvorli mentioned this pull request Sep 30, 2025
[release/10.0] Move coreclr EH second pass to native code #120263
Merged
4 tasks

max-charlamb mentioned this pull request Oct 2, 2025
Remove check from SOS test dotnet/diagnostics#5582
Merged

LoopedBard3 mentioned this pull request Oct 2, 2025
[Perf] Linux/arm64: 6 Improvements on 9/29/2025 6:54:39 PM +00:00 dotnet/perf-autofiling-issues#63238
Closed

jkotas mentioned this pull request Oct 6, 2025
!PreemptiveGCDisabled assert failure from FiberDetachCallback during System.Runtime.Tests on win-arm64 #120437
Closed

github-actionsBot locked and limited conversation to collaborators Oct 30, 2025