Skip to content

Add asserts to catch unintentional use of generic overloads - #1200

Merged
jkotas merged 2 commits into
dotnet:masterfrom
jkotas:sequence-equal-asserts
Jan 6, 2020
Merged

Add asserts to catch unintentional use of generic overloads#1200
jkotas merged 2 commits into
dotnet:masterfrom
jkotas:sequence-equal-asserts

Conversation

@jkotas

@jkotasjkotas commented Dec 28, 2019

Copy link
Copy Markdown
Member

Delete unnecessary ifdefs

@jkotas

jkotas commented Dec 28, 2019

Copy link
Copy Markdown
MemberAuthor

This is follow up on #1113 . cc @gfoidl

gfoidl
gfoidl reviewed Dec 28, 2019
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs Outdated
huoyaoyuan
huoyaoyuan reviewed Dec 31, 2019
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs
@jkotas
jkotas merged commit f6d14ee into dotnet:masterJan 6, 2020
@jkotas
jkotas deleted the sequence-equal-asserts branch January 8, 2020 18:22
@halter73halter73 mentioned this pull request Jan 8, 2020
Closed
jkotas added a commit that referenced this pull request Jan 11, 2020
@jkotas
Partial Revert "Add asserts to catch unintentional use of generic ove…
9112086
…rloads (#1200)" (#1628)
This reverts commit f6d14ee.
@ghostghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
+2 more reviewers
@huoyaoyuanhuoyaoyuanhuoyaoyuan left review comments
@gfoidlgfoidlgfoidl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Memory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@stephentoub@huoyaoyuan@gfoidl