Skip to content

Enhance documentation on updating reference source for new APIs - #120062

Merged
jkotas merged 3 commits into
dotnet:mainfrom
SadPencil:doc-add-update-ref-reminder
Sep 25, 2025
Merged

Enhance documentation on updating reference source for new APIs#120062
jkotas merged 3 commits into
dotnet:mainfrom
SadPencil:doc-add-update-ref-reminder

Conversation

@SadPencil

Copy link
Copy Markdown
Contributor

Updated documentation to emphasize implementing API modifications and updating the reference source when adding new APIs, in response to the discussion here.

Updated documentation to emphasize implementing API modifications and updating the reference source when adding new APIs.
CopilotAI review requested due to automatic review settings September 24, 2025 17:16

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances documentation to provide clearer guidance on updating reference source when adding new APIs to the dotnet/runtime repository. The changes emphasize the importance of implementing API modifications and updating reference source rather than suppressing compatibility errors.

Key changes:

  • Added explicit guidance in the libraries build documentation about updating reference source for new APIs
  • Enhanced the API adding guidelines with step-by-step instructions for implementing API modifications

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
docs/workflow/building/libraries/README.mdAdded note clarifying that new APIs require reference source updates instead of suppressing compatibility errors
docs/coding-guidelines/adding-api-guidelines.mdAdded structured steps for implementing API modifications and updating reference source

@github-actionsgithub-actionsBot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 24, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 24, 2025
@jkotasjkotas added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 24, 2025

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@GerardSmitGerardSmit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be relative paths instead of URLs?

Comment threaddocs/coding-guidelines/adding-api-guidelines.md Outdated
Comment threaddocs/workflow/building/libraries/README.md Outdated
SadPenciland others added 2 commits September 25, 2025 01:36
Co-authored-by: Gerard Smit <gsmit1996@gmail.com>
Co-authored-by: Gerard Smit <gsmit1996@gmail.com>
@SadPencil

SadPencil commented Sep 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Shouldn't these be relative paths instead of URLs?

Oops! Right. Thanks for the reminder.

@jkotas

Copy link
Copy Markdown
Member

/ba-g docs only change

@jkotas
jkotas merged commit 28954c7 into dotnet:mainSep 25, 2025
15 of 16 checks passed
@SadPencil
SadPencil deleted the doc-add-update-ref-reminder branch September 25, 2025 06:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Oct 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-librariescommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SadPencil@jkotas@GerardSmit