Uh oh!
There was an error while loading. Please reload this page.
[mono][hotreload] Ignore if we receive an empty update. - #120333
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a check to ignore empty hot reload updates in the Mono runtime. This prevents unnecessary processing when ASP.NET Core sends empty updates in WebAssembly debugger scenarios where the debugger itself applies the real updates.
Key Changes
- Added early return when both metadata and IL byte counts are zero
- Prevents redundant processing of empty hot reload updates
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
thaystg
commented
Oct 2, 2025
/backport to release/10.0 |
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18202185862 |
thaystg
commented
Oct 2, 2025
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18202189764 |
tmat
commented
Oct 2, 2025
Do we need a test? |
steveisok
commented
Oct 2, 2025
Can we pull that off in runtime? |
thaystg
commented
Oct 3, 2025
I think it's not possible to add a test here. Not super sure. |
thaystg
commented
Jan 23, 2026
/backport to release/8.0-staging |
Started backporting to |
This PR adds a check to ignore empty hot reload updates in the Mono runtime. This prevents unnecessary processing when ASP.NET Core sends empty updates in WebAssembly debugger scenarios where the debugger itself applies the real updates.
And also avoids assertion for receiving updates from System.Reflection.Metadata.MetadataUpdater.ApplyUpdate and from debugger even if one of them was empty.